From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A401CC46467 for ; Tue, 3 Jan 2023 12:54:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237622AbjACMyx (ORCPT ); Tue, 3 Jan 2023 07:54:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233216AbjACMtl (ORCPT ); Tue, 3 Jan 2023 07:49:41 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA38D30C; Tue, 3 Jan 2023 04:49:40 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id A2BB56602CF4; Tue, 3 Jan 2023 12:49:38 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1672750179; bh=8ji9uM0rPrYHIz3P734RsmkYAcXteBVac3pmsXFW90Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n6G0SNZjtaBdV/0/2Fd7PbL6pO+oO5JW0vDldxzUZnOI8gHX8lJ/Wx/uX0mxAjmJp OZrxOV6gtRankj1cdmrQ+kKsUDtV2DiWe626RinwkegpPV7iaTicYmbYaUtwd0on3w bXEAzTRbbxZaybjJg0o5JsmAT/He8PPj1HLIM4Pyi/2OV3UeMcQjGsMtN9a62cYSVw Rgi4RkDum2H+Xxrk1TFz+zvBw05dWj/+w7f+sktffPBao72r69/l1GDV72/+ALTyXE 6slxPKIpLjNW70nc8hxFwgaIfh7P9IXeqVLkmCQZCjVFQS4gR3sBPuH/rZdc46nuX/ OkAls005mxgMg== Message-ID: <2f4a78f8-9cdd-9e44-20a2-b3bd6abd5cc7@collabora.com> Date: Tue, 3 Jan 2023 13:49:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Content-Language: en-US To: Roger Lu , Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Nicolas Boichat Cc: Fan Chen , Jia-wei Chang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20221226094248.4506-1-roger.lu@mediatek.com> <20221226094248.4506-14-roger.lu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221226094248.4506-14-roger.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/12/22 10:42, Roger Lu ha scritto: > Some projects might not support DEBUG_FS but still needs svs to be > supported. Therefore, keep svs alive even though debug cmd create fail. > > Signed-off-by: Roger Lu > --- > drivers/soc/mediatek/mtk-svs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index af3a12e29e78..c780a115543e 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2390,10 +2390,8 @@ static int svs_probe(struct platform_device *pdev) > } > Instead of ignoring a planned failure, it's sensible to not fail at all: enclose this call and the svs_create_debug_cmds() function in an ifdef. #ifdef CONFIG_DEBUG_FS > ret = svs_create_debug_cmds(svsp); > - if (ret) { > + if (ret) > dev_err(svsp->dev, "svs create debug cmds fail: %d\n", ret); > - goto svs_probe_iounmap; > - } #endif > > return 0; > > Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A72AC3DA7D for ; Tue, 3 Jan 2023 14:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nFTVMGPzzEOMvq8JWrLTW2w5Q5UzXIrxk/gOXDm0MEU=; b=poYmWONO249xXJ m1WNNIJWIAAjbrYUqpS1Pu6UjsDsBC/ZUzzZpATAyT/uKY7LkpBVwcAUYMgrgYJ+TfQsS8eOITGKD haeZSulMHQM0mVSdjZ1ViC4DfZnFRg0weimSxsVctooS1RKLUF4MeTfLqRhLFypOhpHw6H6BiaaFj pGhOmlQePbnGGQrQ+/6mu7zsmul8EGEXHyAhnEOwaDJq4726f6tSPawcaHzdv9d6UODYXe5+BeY7I YiTmv/BFWZXV3JbQonw8tc9NI9NrfQFdTGWhBKoMlTR+WaW6+VwSYlxL2p+l7VTKmtUAQSjM1jeQY 6URD/5metyV/3dCDQZZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCiH5-001xu8-Ji; Tue, 03 Jan 2023 14:28:21 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCgjf-001LRe-5v; Tue, 03 Jan 2023 12:49:44 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id A2BB56602CF4; Tue, 3 Jan 2023 12:49:38 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1672750179; bh=8ji9uM0rPrYHIz3P734RsmkYAcXteBVac3pmsXFW90Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n6G0SNZjtaBdV/0/2Fd7PbL6pO+oO5JW0vDldxzUZnOI8gHX8lJ/Wx/uX0mxAjmJp OZrxOV6gtRankj1cdmrQ+kKsUDtV2DiWe626RinwkegpPV7iaTicYmbYaUtwd0on3w bXEAzTRbbxZaybjJg0o5JsmAT/He8PPj1HLIM4Pyi/2OV3UeMcQjGsMtN9a62cYSVw Rgi4RkDum2H+Xxrk1TFz+zvBw05dWj/+w7f+sktffPBao72r69/l1GDV72/+ALTyXE 6slxPKIpLjNW70nc8hxFwgaIfh7P9IXeqVLkmCQZCjVFQS4gR3sBPuH/rZdc46nuX/ OkAls005mxgMg== Message-ID: <2f4a78f8-9cdd-9e44-20a2-b3bd6abd5cc7@collabora.com> Date: Tue, 3 Jan 2023 13:49:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Content-Language: en-US To: Roger Lu , Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Nicolas Boichat Cc: Fan Chen , Jia-wei Chang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20221226094248.4506-1-roger.lu@mediatek.com> <20221226094248.4506-14-roger.lu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221226094248.4506-14-roger.lu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_044943_503138_82599CE2 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 26/12/22 10:42, Roger Lu ha scritto: > Some projects might not support DEBUG_FS but still needs svs to be > supported. Therefore, keep svs alive even though debug cmd create fail. > > Signed-off-by: Roger Lu > --- > drivers/soc/mediatek/mtk-svs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index af3a12e29e78..c780a115543e 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2390,10 +2390,8 @@ static int svs_probe(struct platform_device *pdev) > } > Instead of ignoring a planned failure, it's sensible to not fail at all: enclose this call and the svs_create_debug_cmds() function in an ifdef. #ifdef CONFIG_DEBUG_FS > ret = svs_create_debug_cmds(svsp); > - if (ret) { > + if (ret) > dev_err(svsp->dev, "svs create debug cmds fail: %d\n", ret); > - goto svs_probe_iounmap; > - } #endif > > return 0; > > Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel