From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25EBAC433DF for ; Thu, 9 Jul 2020 01:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D3EB206F6 for ; Thu, 9 Jul 2020 01:40:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbgGIBkD (ORCPT ); Wed, 8 Jul 2020 21:40:03 -0400 Received: from regular1.263xmail.com ([211.150.70.199]:58194 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbgGIBkD (ORCPT ); Wed, 8 Jul 2020 21:40:03 -0400 X-Greylist: delayed 468 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Jul 2020 21:40:02 EDT Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id A14ADF1B; Thu, 9 Jul 2020 09:32:06 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.236] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P14852T139810280818432S1594258325506381_; Thu, 09 Jul 2020 09:32:06 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: zhangqing@rock-chips.com X-SENDER: zhangqing@rock-chips.com X-LOGIN-NAME: zhangqing@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 Subject: Re: [PATCH] clk: rockchip: mark pclk_uart2 as critical on rk3328 To: Johan Jonker , heiko@sntech.de Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200708144528.20465-1-jbx6244@gmail.com> From: "elaine.zhang" Organization: rockchip Message-ID: <2f58b9df-9bcd-5639-65cc-306a6d36b310@rock-chips.com> Date: Thu, 9 Jul 2020 09:32:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200708144528.20465-1-jbx6244@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/7/8 下午10:45, Johan Jonker 写道: > The rk3328 uart2 port is used as boot console and to debug. > During the boot pclk_uart2 is disabled by a clk_disable_unused > initcall. Fix the uart2 function by marking pclk_uart2 > as critical on rk3328. Also add sclk_uart2 as that is needed > for the same DT node. > > Signed-off-by: Johan Jonker > --- > drivers/clk/rockchip/clk-rk3328.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/rockchip/clk-rk3328.c b/drivers/clk/rockchip/clk-rk3328.c > index c186a1985..cb7749cb7 100644 > --- a/drivers/clk/rockchip/clk-rk3328.c > +++ b/drivers/clk/rockchip/clk-rk3328.c > @@ -875,6 +875,8 @@ static const char *const rk3328_critical_clocks[] __initconst = { > "aclk_gmac_niu", > "pclk_gmac_niu", > "pclk_phy_niu", > + "pclk_uart2", > + "sclk_uart2", > }; > Not need to mark the uart2 as critical clocks, the uart clk will enabled by uart driver probe(dw8250_probe()). For your question,  Please check the uart2 dts node "status = okay". Or You can send me the complete log, I check the status of uart2. > static void __init rk3328_clk_init(struct device_node *np) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80822C433E0 for ; Thu, 9 Jul 2020 01:33:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DFC520739 for ; Thu, 9 Jul 2020 01:33:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i1KY/Txc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DFC520739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xu6NwwtO+M7PU1gzAMxFT+w6nu7dU2UBTAXWyLXe5ig=; b=i1KY/TxczMyQMrlTt0ivuM6pQ oS7ANfpIZlM5/RThUkEsV59F+GalHESsxa33wr6/lV6ztHa6KAz+iDmR4bYbsOp67IR7o0b1jYeNo PWXVXCZiGushcx6rhYA4bVZ39zs8fwGYR1Tfk/2Skzsvda0X+TUvY3J8j0hlK+9JyuEvumfyACdfG fcvmsBJrugUCYvbX4cE7GaH99CaADNGwTBBq8PDuKBWyzbiSowNnVQkIa9iFmO55h120gLmF8kEcE EbWPRiOq7/TbLdYGgl0BwO8goV1xLOEb/W173wwSYECU+yxPdnbv4RZlXmZyd6/V2Mkkfv5GgD26l 3qJsrV+IQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtLQD-0004mE-D2; Thu, 09 Jul 2020 01:32:21 +0000 Received: from regular1.263xmail.com ([211.150.70.199]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtLQA-0004lX-QN; Thu, 09 Jul 2020 01:32:20 +0000 Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id A14ADF1B; Thu, 9 Jul 2020 09:32:06 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.236] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P14852T139810280818432S1594258325506381_; Thu, 09 Jul 2020 09:32:06 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: zhangqing@rock-chips.com X-SENDER: zhangqing@rock-chips.com X-LOGIN-NAME: zhangqing@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 Subject: Re: [PATCH] clk: rockchip: mark pclk_uart2 as critical on rk3328 To: Johan Jonker , heiko@sntech.de References: <20200708144528.20465-1-jbx6244@gmail.com> From: "elaine.zhang" Organization: rockchip Message-ID: <2f58b9df-9bcd-5639-65cc-306a6d36b310@rock-chips.com> Date: Thu, 9 Jul 2020 09:32:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200708144528.20465-1-jbx6244@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_213219_123977_F9093611 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 5ZyoIDIwMjAvNy84IOS4i+WNiDEwOjQ1LCBKb2hhbiBKb25rZXIg5YaZ6YGTOgo+IFRoZSByazMz MjggdWFydDIgcG9ydCBpcyB1c2VkIGFzIGJvb3QgY29uc29sZSBhbmQgdG8gZGVidWcuCj4gRHVy aW5nIHRoZSBib290IHBjbGtfdWFydDIgaXMgZGlzYWJsZWQgYnkgYSBjbGtfZGlzYWJsZV91bnVz ZWQKPiBpbml0Y2FsbC4gRml4IHRoZSB1YXJ0MiBmdW5jdGlvbiBieSBtYXJraW5nIHBjbGtfdWFy dDIKPiBhcyBjcml0aWNhbCBvbiByazMzMjguIEFsc28gYWRkIHNjbGtfdWFydDIgYXMgdGhhdCBp cyBuZWVkZWQKPiBmb3IgdGhlIHNhbWUgRFQgbm9kZS4KPgo+IFNpZ25lZC1vZmYtYnk6IEpvaGFu IEpvbmtlciA8amJ4NjI0NEBnbWFpbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2Nsay9yb2NrY2hp cC9jbGstcmszMzI4LmMgfCAyICsrCj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvcm9ja2NoaXAvY2xrLXJrMzMyOC5jIGIvZHJp dmVycy9jbGsvcm9ja2NoaXAvY2xrLXJrMzMyOC5jCj4gaW5kZXggYzE4NmExOTg1Li5jYjc3NDlj YjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9jbGsvcm9ja2NoaXAvY2xrLXJrMzMyOC5jCj4gKysr IGIvZHJpdmVycy9jbGsvcm9ja2NoaXAvY2xrLXJrMzMyOC5jCj4gQEAgLTg3NSw2ICs4NzUsOCBA QCBzdGF0aWMgY29uc3QgY2hhciAqY29uc3QgcmszMzI4X2NyaXRpY2FsX2Nsb2Nrc1tdIF9faW5p dGNvbnN0ID0gewo+ICAgCSJhY2xrX2dtYWNfbml1IiwKPiAgIAkicGNsa19nbWFjX25pdSIsCj4g ICAJInBjbGtfcGh5X25pdSIsCj4gKwkicGNsa191YXJ0MiIsCj4gKwkic2Nsa191YXJ0MiIsCj4g ICB9Owo+ICAgCgpOb3QgbmVlZCB0byBtYXJrIHRoZSB1YXJ0MiBhcyBjcml0aWNhbCBjbG9ja3Ms IHRoZSB1YXJ0IGNsayB3aWxsIGVuYWJsZWQgCmJ5IHVhcnQgZHJpdmVyIHByb2JlKGR3ODI1MF9w cm9iZSgpKS4KCkZvciB5b3VyIHF1ZXN0aW9uLMKgIFBsZWFzZSBjaGVjayB0aGUgdWFydDIgZHRz IG5vZGUgInN0YXR1cyA9IG9rYXkiLgoKT3IgWW91IGNhbiBzZW5kIG1lIHRoZSBjb21wbGV0ZSBs b2csIEkgY2hlY2sgdGhlIHN0YXR1cyBvZiB1YXJ0Mi4KCj4gICBzdGF0aWMgdm9pZCBfX2luaXQg cmszMzI4X2Nsa19pbml0KHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK