From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 2/3] x86/mm: Replace opencoded forms of map_l?t_from_l?e() Date: Fri, 25 Aug 2017 15:57:30 +0100 Message-ID: <2f793479-888c-93ff-7ed7-c9a97927b9b1@citrix.com> References: <1503580497-22936-1-git-send-email-andrew.cooper3@citrix.com> <1503580497-22936-3-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1503580497-22936-3-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: George Dunlap , Tim Deegan , Wei Liu , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMDgvMjQvMjAxNyAwMjoxNCBQTSwgQW5kcmV3IENvb3BlciB3cm90ZToKPiBObyBmdW5jdGlv bmFsIGNoYW5nZSAoY29uZmlybWVkIGJ5IGRpZmZpbmcgdGhlIGRpc2Fzc2VtYmx5KS4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgoK UmV2aWV3ZWQtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KCj4g LS0tCj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogV2VpIExpdSA8 d2VpLmxpdTJAY2l0cml4LmNvbT4KPiBDQzogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+Cj4gQ0M6 IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAZXUuY2l0cml4LmNvbT4KPiAtLS0KPiAgeGVu L2FyY2gveDg2L21tLmMgICAgICAgICAgICB8IDggKysrKy0tLS0KPiAgeGVuL2FyY2gveDg2L21t L3AybS1wdC5jICAgICB8IDYgKysrLS0tCj4gIHhlbi9hcmNoL3g4Ni9wdi9kb20wX2J1aWxkLmMg fCA2ICsrKy0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEwIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbW0uYyBiL3hlbi9hcmNoL3g4 Ni9tbS5jCj4gaW5kZXggZTZiNzgyOS4uMWUwYWUyZiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94 ODYvbW0uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS5jCj4gQEAgLTYxMzEsNyArNjEzMSw3IEBA IGludCBjcmVhdGVfcGVyZG9tYWluX21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQg bG9uZyB2YSwKPiAgICAgICAgICBsM3RhYltsM190YWJsZV9vZmZzZXQodmEpXSA9IGwzZV9mcm9t X3BhZ2UocGcsIF9fUEFHRV9IWVBFUlZJU09SX1JXKTsKPiAgICAgIH0KPiAgICAgIGVsc2UKPiAt ICAgICAgICBsMnRhYiA9IG1hcF9kb21haW5fcGFnZShfbWZuKGwzZV9nZXRfcGZuKGwzdGFiW2wz X3RhYmxlX29mZnNldCh2YSldKSkpOwo+ICsgICAgICAgIGwydGFiID0gbWFwX2wydF9mcm9tX2wz ZShsM3RhYltsM190YWJsZV9vZmZzZXQodmEpXSk7Cj4gIAo+ICAgICAgdW5tYXBfZG9tYWluX3Bh Z2UobDN0YWIpOwo+ICAKPiBAQCAtNjE3Myw3ICs2MTczLDcgQEAgaW50IGNyZWF0ZV9wZXJkb21h aW5fbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIHZhLAo+ICAgICAgICAg ICAgICAqcGwyZSA9IGwyZV9mcm9tX3BhZ2UocGcsIF9fUEFHRV9IWVBFUlZJU09SX1JXKTsKPiAg ICAgICAgICB9Cj4gICAgICAgICAgZWxzZSBpZiAoICFsMXRhYiApCj4gLSAgICAgICAgICAgIGwx dGFiID0gbWFwX2RvbWFpbl9wYWdlKF9tZm4obDJlX2dldF9wZm4oKnBsMmUpKSk7Cj4gKyAgICAg ICAgICAgIGwxdGFiID0gbWFwX2wxdF9mcm9tX2wyZSgqcGwyZSk7Cj4gIAo+ICAgICAgICAgIGlm ICggcHBnICYmCj4gICAgICAgICAgICAgICAhKGwxZV9nZXRfZmxhZ3MobDF0YWJbbDFfdGFibGVf b2Zmc2V0KHZhKV0pICYgX1BBR0VfUFJFU0VOVCkgKQo+IEBAIC02MjI0LDcgKzYyMjQsNyBAQCB2 b2lkIGRlc3Ryb3lfcGVyZG9tYWluX21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQg bG9uZyB2YSwKPiAgCj4gICAgICBpZiAoIGwzZV9nZXRfZmxhZ3MoKnBsM2UpICYgX1BBR0VfUFJF U0VOVCApCj4gICAgICB7Cj4gLSAgICAgICAgY29uc3QgbDJfcGdlbnRyeV90ICpsMnRhYiA9IG1h cF9kb21haW5fcGFnZShfbWZuKGwzZV9nZXRfcGZuKCpwbDNlKSkpOwo+ICsgICAgICAgIGNvbnN0 IGwyX3BnZW50cnlfdCAqbDJ0YWIgPSBtYXBfbDJ0X2Zyb21fbDNlKCpwbDNlKTsKPiAgICAgICAg ICBjb25zdCBsMl9wZ2VudHJ5X3QgKnBsMmUgPSBsMnRhYiArIGwyX3RhYmxlX29mZnNldCh2YSk7 Cj4gICAgICAgICAgdW5zaWduZWQgaW50IGkgPSBsMV90YWJsZV9vZmZzZXQodmEpOwo+ICAKPiBA QCAtNjIzMiw3ICs2MjMyLDcgQEAgdm9pZCBkZXN0cm95X3BlcmRvbWFpbl9tYXBwaW5nKHN0cnVj dCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgdmEsCj4gICAgICAgICAgewo+ICAgICAgICAgICAg ICBpZiAoIGwyZV9nZXRfZmxhZ3MoKnBsMmUpICYgX1BBR0VfUFJFU0VOVCApCj4gICAgICAgICAg ICAgIHsKPiAtICAgICAgICAgICAgICAgIGwxX3BnZW50cnlfdCAqbDF0YWIgPSBtYXBfZG9tYWlu X3BhZ2UoX21mbihsMmVfZ2V0X3BmbigqcGwyZSkpKTsKPiArICAgICAgICAgICAgICAgIGwxX3Bn ZW50cnlfdCAqbDF0YWIgPSBtYXBfbDF0X2Zyb21fbDJlKCpwbDJlKTsKPiAgCj4gICAgICAgICAg ICAgICAgICBmb3IgKCA7IG5yICYmIGkgPCBMMV9QQUdFVEFCTEVfRU5UUklFUzsgLS1uciwgKytp ICkKPiAgICAgICAgICAgICAgICAgIHsKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21tL3Ay bS1wdC5jIGIveGVuL2FyY2gveDg2L21tL3AybS1wdC5jCj4gaW5kZXggNjI4YTUzZS4uZjBkODA3 NiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLXB0LmMKPiArKysgYi94ZW4vYXJj aC94ODYvbW0vcDJtLXB0LmMKPiBAQCAtMTAyNiw3ICsxMDI2LDcgQEAgbG9uZyBwMm1fcHRfYXVk aXRfcDJtKHN0cnVjdCBwMm1fZG9tYWluICpwMm0pCj4gICAgICAgICAgICAgICAgICBnZm4gKz0g MSA8PCAoTDRfUEFHRVRBQkxFX1NISUZUIC0gUEFHRV9TSElGVCk7Cj4gICAgICAgICAgICAgICAg ICBjb250aW51ZTsKPiAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICBsM2UgPSBtYXBfZG9t YWluX3BhZ2UoX21mbihsNGVfZ2V0X3BmbihsNGVbaTRdKSkpOwo+ICsgICAgICAgICAgICBsM2Ug PSBtYXBfbDN0X2Zyb21fbDRlKGw0ZVtpNF0pOwo+ICAgICAgICAgICAgICBmb3IgKCBpMyA9IDA7 Cj4gICAgICAgICAgICAgICAgICAgIGkzIDwgTDNfUEFHRVRBQkxFX0VOVFJJRVM7Cj4gICAgICAg ICAgICAgICAgICAgIGkzKysgKQo+IEBAIC0xMDYxLDcgKzEwNjEsNyBAQCBsb25nIHAybV9wdF9h dWRpdF9wMm0oc3RydWN0IHAybV9kb21haW4gKnAybSkKPiAgICAgICAgICAgICAgICAgICAgICB9 Cj4gICAgICAgICAgICAgICAgICB9Cj4gIAo+IC0gICAgICAgICAgICAgICAgbDJlID0gbWFwX2Rv bWFpbl9wYWdlKF9tZm4obDNlX2dldF9wZm4obDNlW2kzXSkpKTsKPiArICAgICAgICAgICAgICAg IGwyZSA9IG1hcF9sMnRfZnJvbV9sM2UobDNlW2kzXSk7Cj4gICAgICAgICAgICAgICAgICBmb3Ig KCBpMiA9IDA7IGkyIDwgTDJfUEFHRVRBQkxFX0VOVFJJRVM7IGkyKysgKQo+ICAgICAgICAgICAg ICAgICAgewo+ICAgICAgICAgICAgICAgICAgICAgIGlmICggIShsMmVfZ2V0X2ZsYWdzKGwyZVtp Ml0pICYgX1BBR0VfUFJFU0VOVCkgKQo+IEBAIC0xMDk3LDcgKzEwOTcsNyBAQCBsb25nIHAybV9w dF9hdWRpdF9wMm0oc3RydWN0IHAybV9kb21haW4gKnAybSkKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgY29udGludWU7Cj4gICAgICAgICAgICAgICAgICAgICAgfQo+ICAKPiAtICAgICAgICAg ICAgICAgICAgICBsMWUgPSBtYXBfZG9tYWluX3BhZ2UoX21mbihsMmVfZ2V0X3BmbihsMmVbaTJd KSkpOwo+ICsgICAgICAgICAgICAgICAgICAgIGwxZSA9IG1hcF9sMXRfZnJvbV9sMmUobDJlW2ky XSk7Cj4gIAo+ICAgICAgICAgICAgICAgICAgICAgIGZvciAoIGkxID0gMDsgaTEgPCBMMV9QQUdF VEFCTEVfRU5UUklFUzsgaTErKywgZ2ZuKysgKQo+ICAgICAgICAgICAgICAgICAgICAgIHsKPiBk aWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3B2L2RvbTBfYnVpbGQuYyBiL3hlbi9hcmNoL3g4Ni9w di9kb20wX2J1aWxkLmMKPiBpbmRleCBlNjdmZmRkLi5lYzdmOTZkIDEwMDY0NAo+IC0tLSBhL3hl bi9hcmNoL3g4Ni9wdi9kb20wX2J1aWxkLmMKPiArKysgYi94ZW4vYXJjaC94ODYvcHYvZG9tMF9i dWlsZC5jCj4gQEAgLTE0Miw3ICsxNDIsNyBAQCBzdGF0aWMgX19pbml0IHZvaWQgc2V0dXBfcHZf cGh5c21hcChzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIHBndGJsX3BmbiwKPiAgICAg ICAgICAgICAgY2xlYXJfcGFnZShwbDNlKTsKPiAgICAgICAgICAgICAgKnBsNGUgPSBsNGVfZnJv bV9wYWdlKHBhZ2UsIEw0X1BST1QpOwo+ICAgICAgICAgIH0gZWxzZQo+IC0gICAgICAgICAgICBw bDNlID0gbWFwX2RvbWFpbl9wYWdlKF9tZm4obDRlX2dldF9wZm4oKnBsNGUpKSk7Cj4gKyAgICAg ICAgICAgIHBsM2UgPSBtYXBfbDN0X2Zyb21fbDRlKCpwbDRlKTsKPiAgCj4gICAgICAgICAgcGwz ZSArPSBsM190YWJsZV9vZmZzZXQodnBoeXNtYXBfc3RhcnQpOwo+ICAgICAgICAgIGlmICggIWwz ZV9nZXRfaW50cHRlKCpwbDNlKSApCj4gQEAgLTE2OSw3ICsxNjksNyBAQCBzdGF0aWMgX19pbml0 IHZvaWQgc2V0dXBfcHZfcGh5c21hcChzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIHBn dGJsX3BmbiwKPiAgICAgICAgICAgICAgKnBsM2UgPSBsM2VfZnJvbV9wYWdlKHBhZ2UsIEwzX1BS T1QpOwo+ICAgICAgICAgIH0KPiAgICAgICAgICBlbHNlCj4gLSAgICAgICAgICAgIHBsMmUgPSBt YXBfZG9tYWluX3BhZ2UoX21mbihsM2VfZ2V0X3BmbigqcGwzZSkpKTsKPiArICAgICAgICAgICAg cGwyZSA9IG1hcF9sMnRfZnJvbV9sM2UoKnBsM2UpOwo+ICAKPiAgICAgICAgICBwbDJlICs9IGwy X3RhYmxlX29mZnNldCh2cGh5c21hcF9zdGFydCk7Cj4gICAgICAgICAgaWYgKCAhbDJlX2dldF9p bnRwdGUoKnBsMmUpICkKPiBAQCAtMTk1LDcgKzE5NSw3IEBAIHN0YXRpYyBfX2luaXQgdm9pZCBz ZXR1cF9wdl9waHlzbWFwKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgcGd0YmxfcGZu LAo+ICAgICAgICAgICAgICAqcGwyZSA9IGwyZV9mcm9tX3BhZ2UocGFnZSwgTDJfUFJPVCk7Cj4g ICAgICAgICAgfQo+ICAgICAgICAgIGVsc2UKPiAtICAgICAgICAgICAgcGwxZSA9IG1hcF9kb21h aW5fcGFnZShfbWZuKGwyZV9nZXRfcGZuKCpwbDJlKSkpOwo+ICsgICAgICAgICAgICBwbDFlID0g bWFwX2wxdF9mcm9tX2wyZSgqcGwyZSk7Cj4gIAo+ICAgICAgICAgIHBsMWUgKz0gbDFfdGFibGVf b2Zmc2V0KHZwaHlzbWFwX3N0YXJ0KTsKPiAgICAgICAgICBCVUdfT04obDFlX2dldF9pbnRwdGUo KnBsMWUpKTsKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBz Oi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK