From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8C1C48BDF for ; Fri, 18 Jun 2021 12:44:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C8FA613EB for ; Fri, 18 Jun 2021 12:44:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C8FA613EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luDrK-0005xj-E6 for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 08:44:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luDqh-0005Ie-Ms for qemu-devel@nongnu.org; Fri, 18 Jun 2021 08:43:51 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:47564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luDqf-0004a0-Ep for qemu-devel@nongnu.org; Fri, 18 Jun 2021 08:43:51 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AC4EE1FDAE; Fri, 18 Jun 2021 12:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624020227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDTyHmX/98ZO3jVmF9kNgyJ0QTonCLfq+ml6AnTWslA=; b=keOMuR0Mwap0u/ulDtAAws7cCt4LHvpOd0S9RAbzPHwkasFndiEjJTddm6aJrpgM/LfEVJ 1eRSyyC4Kvo13TPGQ/Ew0W20hCeIHBxAWMVLC55pcnelzN59leJMHOE2k78a1HwnY5kBbw W2iOeSPvD+MnSN3od/S0ALRsApkgkX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624020227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDTyHmX/98ZO3jVmF9kNgyJ0QTonCLfq+ml6AnTWslA=; b=SAmppzUB735ULLJMd9/IGant6a86BWFXpSCukrdHkvnMGBfsyr8EmUtFmFzWxwu8ElFvYh Bv3/DG0wG1uPX6DA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 4E609118DD; Fri, 18 Jun 2021 12:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624020227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDTyHmX/98ZO3jVmF9kNgyJ0QTonCLfq+ml6AnTWslA=; b=keOMuR0Mwap0u/ulDtAAws7cCt4LHvpOd0S9RAbzPHwkasFndiEjJTddm6aJrpgM/LfEVJ 1eRSyyC4Kvo13TPGQ/Ew0W20hCeIHBxAWMVLC55pcnelzN59leJMHOE2k78a1HwnY5kBbw W2iOeSPvD+MnSN3od/S0ALRsApkgkX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624020227; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDTyHmX/98ZO3jVmF9kNgyJ0QTonCLfq+ml6AnTWslA=; b=SAmppzUB735ULLJMd9/IGant6a86BWFXpSCukrdHkvnMGBfsyr8EmUtFmFzWxwu8ElFvYh Bv3/DG0wG1uPX6DA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id QrbCEAOVzGBZHgAALh3uQQ (envelope-from ); Fri, 18 Jun 2021 12:43:47 +0000 Subject: Re: [RFC 0/3] qtest: pick tests that require KVM at runtime To: Igor Mammedov References: <20210616152455.1270264-1-imammedo@redhat.com> <20210618132647.07cf2008@redhat.com> From: Claudio Fontana Message-ID: <2f7ae379-92e0-3274-6944-84a5bce6e82e@suse.de> Date: Fri, 18 Jun 2021 14:43:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210618132647.07cf2008@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.202, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, Eduardo Habkost , mst@redhat.com, Richard Henderson , qemu-devel@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/18/21 1:26 PM, Igor Mammedov wrote: > On Thu, 17 Jun 2021 18:49:17 +0200 > Claudio Fontana wrote: > >> On 6/16/21 5:24 PM, Igor Mammedov wrote: >>> >>> Sometimes it's necessary to execute a test that depends on KVM, >>> however qtest is not aware if tested QEMU binary supports KVM >>> on the host it the test is executed. >> >> Hello, >> >> It seems to me that we are constantly re-implementing the same feature with slight variations? >> >> Didn't we have a generic series to introduce qtest_has_accel() from Philippe before? > It's mentioned in cover letter (PS: part) and in [1/3] with rationale > why this was posted. Thought it was separate, but now I see that it uses query-accel underneath. Seems strange to add another check to do the same thing, it may point to qtest_has_accel() needing some update? You mention it is time consuming to use qtest_has_accel(), have you measured an important overhead? With qtest_has_accel() not even being committed yet, is it already necessary to work around it because it's too slow? > >> Does this series work with --disable-kvm builds? (TCG-only builds?) > I'll test. But on the first glance it should work without issues. > (i.e. kvm only tests will be skipped). > >> >> Thanks, >> >> CLaudio >> >> >>> >>> For an example: >>> test q35 machine with intel_iommu >>> This test will run only is KVM is available and fail >>> to start QEMU if it fallsback to TCG, thus failing whole test. >>> So if test is executed in VM where nested KVM is not enabled >>> or on other than x86 host, it will break 'make check-qtest' >>> >>> Series adds a lightweight qtest_has_kvm() check, which abuses >>> build system and should help to avoid running KVM only tests >>> on hosts that do not support it. >>> >>> PS: >>> there is an alternative 'query-accels' QMP command proposal >>> https://patchwork.kernel.org/project/qemu-devel/patch/20210503211020.894589-3-philmd@redhat.com/ >>> which I think is more robust compared to qtest_has_kvm() and >>> could be extended to take into account machine type. >>> But it's more complex and what I dislike about it most, >>> it requires execution of 'probing' QEMU instance to find >>> execute 'query-accels' QMP command, which is rather resource >>> consuming. So I'd use query-accels approach only when it's >>> the only possible option to minimize load on CI systems. >>> >>> Igor Mammedov (2): >>> tests: acpi: q35: test for x2APIC entries in SRAT >>> tests: acpi: update expected tables blobs >>> >>> root (1): >>> tests: qtest: add qtest_has_kvm() to check if tested bynary supports >>> KVM >>> >>> tests/qtest/libqos/libqtest.h | 7 +++++++ >>> meson.build | 1 + >>> tests/data/acpi/q35/APIC.numamem | Bin 0 -> 2686 bytes >>> tests/data/acpi/q35/DSDT.numamem | Bin 7865 -> 35222 bytes >>> tests/data/acpi/q35/FACP.numamem | Bin 0 -> 244 bytes >>> tests/data/acpi/q35/SRAT.numamem | Bin 224 -> 5080 bytes >>> tests/qtest/bios-tables-test.c | 10 +++++++--- >>> tests/qtest/libqtest.c | 20 ++++++++++++++++++++ >>> 8 files changed, 35 insertions(+), 3 deletions(-) >>> create mode 100644 tests/data/acpi/q35/APIC.numamem >>> create mode 100644 tests/data/acpi/q35/FACP.numamem >>> >> >