From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB34C433E0 for ; Wed, 3 Mar 2021 20:20:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A850A64EE6 for ; Wed, 3 Mar 2021 20:20:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A850A64EE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHXz6-0001cp-06 for qemu-devel@archiver.kernel.org; Wed, 03 Mar 2021 15:20:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHXyB-0001AC-4s for qemu-devel@nongnu.org; Wed, 03 Mar 2021 15:19:43 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:57439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHXy7-0001xQ-Jo for qemu-devel@nongnu.org; Wed, 03 Mar 2021 15:19:42 -0500 Received: from [192.168.100.1] ([82.252.139.98]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.103]) with ESMTPSA (Nemesis) id 1N3Xvv-1lyTYN23G7-010ev4; Wed, 03 Mar 2021 21:19:32 +0100 Subject: Re: [PATCH v2 40/42] esp: add trivial implementation of the ESP_RFLAGS register To: Mark Cave-Ayland , qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net References: <20210209193018.31339-1-mark.cave-ayland@ilande.co.uk> <20210209193018.31339-41-mark.cave-ayland@ilande.co.uk> From: Laurent Vivier Message-ID: <2f7de1b7-d178-d5f0-cf0a-7240331576ad@vivier.eu> Date: Wed, 3 Mar 2021 21:19:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210209193018.31339-41-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:CCGmryG5HoouMqn9/X7SbvHrJjfs+v1NP0Nm00GNJNxMTJDValI 2P5IvF1BBMMV9BWylDHl1Y4hL4P8hT/WC4HS+4Ra6MGHmmUMhI0BDQFKRtBMiW68j3Vrs0U 1ATMgjQHufV3UbsrSzYmqmh/WY8WEt3+eRwoxZDP3X0xMZ6TPRvIYee2L/FCdBQey5F1Jin Wisy2G7BwGsFj6yosmzaQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:7YXVVh1qQwo=:yk1hUxlj/IDqN8U5GCM2VH TpvqR7GhJqZgro7cv5d6COfMgh/1daVDIU6BUV/m1YQeq4td3/jBJW5HUX01+JYH5Rt+bok8W vtJyMTFYoF0u/KD1Ft2sxnqMdkm9bzkJOazhUAecz1Fe7NsJ/apti/vLnyNUdaxp5QqNOy+Wr zmlVzpDJRLIKCZ41ClXKD2nJKTLkQyQSDmddJEKFWSM/hQefccxROPotksEjXHw08/3fF0W89 7B+tyfTDxKk4+ziMCEvEZaYmFkDurFVSD/BuHegcU1gWe4tT9bhhUy+05nY6NE3qPMhcmU3KO JsjukD+ZMbpBNdPnQJQyAsKwiwj5JAjmRDOK1GttOqtkkA12xu3GMwn0eruEHhTw0x8BnlIEI 4U/6brzjlkcqWhjGGWqbqquLYXK6glgww02CStb1X+E6D7sptPW9OsqB3DFoNqWok/lkp4I1P x+tB7oXaNg== Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 09/02/2021 à 20:30, Mark Cave-Ayland a écrit : > The bottom 5 bits contain the number of bytes remaining in the FIFO which is > trivial to implement with Fifo8 (the remaining bits are unimplemented and left > as 0 for now). > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c > index 9dd9947307..1f01f2314b 100644 > --- a/hw/scsi/esp.c > +++ b/hw/scsi/esp.c > @@ -825,6 +825,10 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr) > val = s->rregs[saddr]; > } > break; > + case ESP_RFLAGS: > + /* Bottom 5 bits indicate number of bytes in FIFO */ > + val = fifo8_num_used(&s->fifo); > + break; > default: > val = s->rregs[saddr]; > break; > Reviewed-by: Laurent Vivier