All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: haozhong.zhang@intel.com, yi.y.sun@linux.intel.com,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	zhangchen.fnst@cn.fujitsu.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 02/12] libxl: make some functions global to prepare splitting up libxl.c
Date: Thu, 9 Feb 2017 17:06:27 +0100	[thread overview]
Message-ID: <2f8011f8-21de-bfa7-4d60-c57024e2f0ef@suse.com> (raw)
In-Reply-To: <20170209154408.2vcnrfavjwf4v6bi@citrix.com>

On 09/02/17 16:44, Wei Liu wrote:
> On Thu, Feb 09, 2017 at 12:42:41PM +0100, Juergen Gross wrote:
>> On 09/02/17 12:36, Ian Jackson wrote:
>>> Juergen Gross writes ("[PATCH v2 02/12] libxl: make some functions global to prepare splitting up libxl.c"):
>>>> Splitting up libxl.c will require two functions to be globally visible.
>>>> Add their prototypes to libxl_internal.h.
>>>
>>> Thanks.  However,
>>>
>>>> -static void xcinfo2xlinfo(libxl_ctx *ctx,
>>>> -                          const xc_domaininfo_t *xcinfo,
>>>> -                          libxl_dominfo *xlinfo)
>>>> +void xcinfo2xlinfo(libxl_ctx *ctx,
>>>> +                   const xc_domaininfo_t *xcinfo,
>>>> +                   libxl_dominfo *xlinfo)
>>>
>>> This function needs a libxl__ prefix adding to its name.
>>
>> Aah, of course!
>>
>> Will send V3 after waiting for more comments for a while...
>>
> 
> If there are no more significant comments, you can just fold in
> everything and provide a branch. No need to repost.

Okay. Please pull from

https://github.com/jgross1/xen.git libxl-split-v3


Thanks,

Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-09 16:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09  9:30 [PATCH v2 00/12] libxl: split up libxl.c Juergen Gross
2017-02-09  9:30 ` [PATCH v2 01/12] libxl: adjust copyright comment of libxl.c Juergen Gross
2017-02-09 10:18   ` Wei Liu
2017-02-09 11:37   ` Ian Jackson
2017-02-09  9:30 ` [PATCH v2 02/12] libxl: make some functions global to prepare splitting up libxl.c Juergen Gross
2017-02-09 11:36   ` Ian Jackson
2017-02-09 11:42     ` Juergen Gross
2017-02-09 15:44       ` Wei Liu
2017-02-09 16:06         ` Juergen Gross [this message]
2017-02-09  9:30 ` [PATCH v2 03/12] libxl: white space cleanup Juergen Gross
2017-02-09 11:37   ` Ian Jackson
2017-02-09  9:30 ` [PATCH v2 04/12] libxl: carve out cpupool specific functions from libxl.c Juergen Gross
2017-02-09  9:30 ` [PATCH v2 05/12] libxl: carve out scheduler " Juergen Gross
2017-02-09  9:30 ` [PATCH v2 06/12] libxl: carve out disk " Juergen Gross
2017-02-09  9:30 ` [PATCH v2 07/12] libxl: carve out console " Juergen Gross
2017-02-09  9:30 ` [PATCH v2 08/12] libxl: carve out memory " Juergen Gross
2017-02-09  9:30 ` [PATCH v2 09/12] libxl: move device specific functions out of libxl.c Juergen Gross
2017-02-09  9:30 ` [PATCH v2 10/12] libxl: carve out tmem specific functions from libxl.c Juergen Gross
2017-02-09  9:30 ` [PATCH v2 11/12] libxl: carve out domain " Juergen Gross
2017-02-09  9:30 ` [PATCH v2 12/12] libxl: make one function static Juergen Gross
2017-02-09 11:42   ` Ian Jackson
2017-02-09 10:22 ` [PATCH v2 00/12] libxl: split up libxl.c Wei Liu
2017-02-09 11:41 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f8011f8-21de-bfa7-4d60-c57024e2f0ef@suse.com \
    --to=jgross@suse.com \
    --cc=haozhong.zhang@intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yi.y.sun@linux.intel.com \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.