[PATCH -next] scsi: elx: efct: Fix error handling in efct_hw_init()

[PATCH -next] scsi: elx: efct: Fix error handling in efct_hw_init()

[Wei Yongjun]

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, also fix typo in error message.

Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/scsi/elx/efct/efct_hw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c
index ce4736c41564..6324683f9e8e 100644
--- a/drivers/scsi/elx/efct/efct_hw.c
+++ b/drivers/scsi/elx/efct/efct_hw.c
@@ -1044,8 +1044,8 @@ efct_hw_init(struct efct_hw *hw)
 	 */
 	hw->wq_reqtag_pool = efct_hw_reqtag_pool_alloc(hw);
 	if (!hw->wq_reqtag_pool) {
-		efc_log_err(hw->os, "efct_hw_reqtag_init failed %d\n", rc);
-		return rc;
+		efc_log_err(hw->os, "efct_hw_reqtag_pool_alloc failed\n");
+		return -ENOMEM;
 	}
 
 	rc = efct_hw_setup_io(hw);

Re: [PATCH -next] scsi: elx: efct: Fix error handling in efct_hw_init()

[James Smart]

On 6/16/2021 7:48 PM, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, also fix typo in error message.
> 
> Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>   drivers/scsi/elx/efct/efct_hw.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

Re: [PATCH -next] scsi: elx: efct: Fix error handling in efct_hw_init()

[Martin K. Petersen]

Wei,

> Fix to return negative error code -ENOMEM from the error handling case
> instead of 0, also fix typo in error message.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering