From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 17 May 2021 11:04:59 +0200
Subject: [PATCH 1/1] xilinx: disable Unicode capitalization
In-Reply-To: <24351350-e12b-3ab6-e3d0-6ba0138cdb9e@gmx.de>
References: <20210516091731.26845-1-xypron.glpk@gmx.de>
 <5784507a-58e5-d6e8-3555-36c033131977@xilinx.com>
 <24351350-e12b-3ab6-e3d0-6ba0138cdb9e@gmx.de>
Message-ID: <2f9dee4a-331b-c5fb-797a-d8a4821790e7@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Added Tom to Cc.

On 17.05.21 10:01, Heinrich Schuchardt wrote:
> On 17.05.21 08:39, Michal Simek wrote:
>>
>>
>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>> Save some KiB when building  xilinx_versal_virt_defconfig by disabling
>>> Unicode capitalization support. This avoids build failures when adding new
>>> features for the UEFI sub-system.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>> ---
>>> It would be preferable to have a size check for the u-boot binary.
>>> This would avoid seeing problems only during execution.
>>> ---
>>>   configs/xilinx_versal_virt_defconfig | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilinx_versal_virt_defconfig
>>> index 707693713a..8bc2ff4a4c 100644
>>> --- a/configs/xilinx_versal_virt_defconfig
>>> +++ b/configs/xilinx_versal_virt_defconfig
>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>>   CONFIG_USB_GADGET_DOWNLOAD=y
>>>   CONFIG_USB_FUNCTION_THOR=y
>>>   CONFIG_OF_LIBFDT_OVERLAY=y
>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>> --
>>> 2.30.2
>>>
>>
>> What's the build issue? Any log? U-Boot is getting bigger and bigger and
> 
> Hello Michal,
> 
> this job failed:
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
> 
> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620

I had a similar, most likely related issue a few days ago:

https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results

Tom git bi-sected this to this commit, which only adds a bit tiny bit
of image size I assume:

"I bisected this down to:
commit 368b3f6db4540f913c436e5287be8356bc9a2891
Author: Stefan Chulski <stefanc@marvell.com>
Date:   Mon May 3 08:08:44 2021 +0200

     phy: introduce 1000BaseX and 2500BaseX modes

     Signed-off-by: Stefan Chulski <stefanc@marvell.com>
     Signed-off-by: Stefan Roese <sr@denx.de>

And while I'm not sure off-hand how it does it, it's causing the
breakage.  Maybe something is overflowing now?"

Thanks,
Stefan