From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E2C1C433EF for ; Tue, 30 Nov 2021 13:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240787AbhK3Nhi (ORCPT ); Tue, 30 Nov 2021 08:37:38 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53678 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbhK3Nhg (ORCPT ); Tue, 30 Nov 2021 08:37:36 -0500 Received: from [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5] (unknown [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 331AC1F450C4; Tue, 30 Nov 2021 13:34:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638279251; bh=8dFt0ved6B1YlHXel+R6Z2zNSNgLE7JvZbncVuRC5Qw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CXXTXeNJfZ9/XZgE6YFUstBI4Ouw4A5FsgohbT2N95JbtcK2UIipznG5/gVg8Sfem JCpbIkg8WQz69wj4MwV68UV40duRU21gjgJFkjoUma0tvpF6V3TmFiLdyhORfTItD9 /R124eq8PRPWQYM4QqhiMUgfBZnzdfyvYb3rb37PdMwAOuSOQGehdscmDifViugAFH mEhQ/PuzYsPcY/L0OCUhp4r0Gf/lYpE1D+9ZT3iiYuLqFxocIyV+GNSdae1CRYolzI 2PMMkcwokvYFBO1SwrmmVUTFgsj8//HfcsE9pyAjEBFQtt3oBrbKPl3TbheQKrlmRO 8jrbiFcGxJf1A== Subject: Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-5-yunfei.dong@mediatek.com> From: Benjamin Gaignard Message-ID: <2fa4e19f-d57c-6264-4284-8387c4182d1f@collabora.com> Date: Tue, 30 Nov 2021 14:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-5-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/11/2021 à 04:41, Yunfei Dong a écrit : > Register each hardware as platform device, need to call pm functions > to open/close power and clock from module mtk-vcodec-dec, export these > functions. The commit message confuse me, maybe something like: "When mtk vcodec decoder is build as a module we need to export mtk-vcodec-dec pm functions to make them visible by the other components" With that: Reviewed-by: Benjamin Gaignard > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > index 20bd157a855c..221cf60e9fbf 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > @@ -77,12 +77,14 @@ int mtk_vcodec_init_dec_pm(struct platform_device *pdev, > put_device(pm->larbvdec); > return ret; > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_init_dec_pm); > > void mtk_vcodec_release_dec_pm(struct mtk_vcodec_pm *pm) > { > pm_runtime_disable(pm->dev); > put_device(pm->larbvdec); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_release_dec_pm); > > int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm) > { > @@ -94,6 +96,7 @@ int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm) > > return ret; > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_pw_on); > > void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm) > { > @@ -103,6 +106,7 @@ void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm) > if (ret) > mtk_v4l2_err("pm_runtime_put_sync fail %d", ret); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_pw_off); > > void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm) > { > @@ -129,6 +133,7 @@ void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm) > for (i -= 1; i >= 0; i--) > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_clock_on); > > void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm) > { > @@ -139,3 +144,4 @@ void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm) > for (i = dec_clk->clk_num - 1; i >= 0; i--) > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_clock_off); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0D8FC433F5 for ; Tue, 30 Nov 2021 13:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5QB3weT6E+jBtorKIzspBTgq8JXDzfuSEOYF+kKcWYs=; b=GOpOWSZqU73eNH+/m14asNkWSj RHhOnjpZ/39tzc8+eBdZrmm8cjxIFCuMUKSS3RO7byYcsbbSlg1nh+a7T2zLaxD6/J2JGMLBS7UEs Gco61IVRsxRACGCYFTi35gz6m1NOx2tRP0KTW/84xtjKwzYGpPZ9afrk54UashNtKU8toVoNvWbbU G/KQ5ndXP+/l3DI2xTsdULcCyZglA73CDf9n0zoxErrCTjBwF3ja6BRhgzsaW4U/HoZmKdO8jqbGO i8J2dSmASFTPZpKOwOvplriCCUKQeBkU1la7h9XPZLuKmyYxagisVjy93osqoTIER6hB7NTk5R5dt yVDZOqEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3HE-005Lzi-Iz; Tue, 30 Nov 2021 13:34:32 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3Gz-005LvY-OQ; Tue, 30 Nov 2021 13:34:19 +0000 Received: from [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5] (unknown [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 331AC1F450C4; Tue, 30 Nov 2021 13:34:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638279251; bh=8dFt0ved6B1YlHXel+R6Z2zNSNgLE7JvZbncVuRC5Qw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CXXTXeNJfZ9/XZgE6YFUstBI4Ouw4A5FsgohbT2N95JbtcK2UIipznG5/gVg8Sfem JCpbIkg8WQz69wj4MwV68UV40duRU21gjgJFkjoUma0tvpF6V3TmFiLdyhORfTItD9 /R124eq8PRPWQYM4QqhiMUgfBZnzdfyvYb3rb37PdMwAOuSOQGehdscmDifViugAFH mEhQ/PuzYsPcY/L0OCUhp4r0Gf/lYpE1D+9ZT3iiYuLqFxocIyV+GNSdae1CRYolzI 2PMMkcwokvYFBO1SwrmmVUTFgsj8//HfcsE9pyAjEBFQtt3oBrbKPl3TbheQKrlmRO 8jrbiFcGxJf1A== Subject: Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-5-yunfei.dong@mediatek.com> From: Benjamin Gaignard Message-ID: <2fa4e19f-d57c-6264-4284-8387c4182d1f@collabora.com> Date: Tue, 30 Nov 2021 14:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-5-yunfei.dong@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_053418_051186_79DB1A29 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org CkxlIDI5LzExLzIwMjEgw6AgMDQ6NDEsIFl1bmZlaSBEb25nIGEgw6ljcml0wqA6Cj4gUmVnaXN0 ZXIgZWFjaCBoYXJkd2FyZSBhcyBwbGF0Zm9ybSBkZXZpY2UsIG5lZWQgdG8gY2FsbCBwbSBmdW5j dGlvbnMKPiB0byBvcGVuL2Nsb3NlIHBvd2VyIGFuZCBjbG9jayBmcm9tIG1vZHVsZSBtdGstdmNv ZGVjLWRlYywgZXhwb3J0IHRoZXNlCj4gZnVuY3Rpb25zLgoKVGhlIGNvbW1pdCBtZXNzYWdlIGNv bmZ1c2UgbWUsIG1heWJlIHNvbWV0aGluZyBsaWtlOgoiV2hlbiBtdGsgdmNvZGVjIGRlY29kZXIg aXMgYnVpbGQgYXMgYSBtb2R1bGUgd2UgbmVlZCB0byBleHBvcnQKbXRrLXZjb2RlYy1kZWMgcG0g ZnVuY3Rpb25zIHRvIG1ha2UgdGhlbSB2aXNpYmxlIGJ5IHRoZSBvdGhlciBjb21wb25lbnRzIgoK V2l0aCB0aGF0OgpSZXZpZXdlZC1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWdu YXJkQGNvbGxhYm9yYS5jb20+Cgo+Cj4gU2lnbmVkLW9mZi1ieTogWXVuZmVpIERvbmcgPHl1bmZl aS5kb25nQG1lZGlhdGVrLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRr LXZjb2RlYy9tdGtfdmNvZGVjX2RlY19wbS5jIHwgNiArKysrKysKPiAgIDEgZmlsZSBjaGFuZ2Vk LCA2IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L210ay12Y29kZWMvbXRrX3Zjb2RlY19kZWNfcG0uYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v bXRrLXZjb2RlYy9tdGtfdmNvZGVjX2RlY19wbS5jCj4gaW5kZXggMjBiZDE1N2E4NTVjLi4yMjFj ZjYwZTlmYmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVj L210a192Y29kZWNfZGVjX3BtLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay12 Y29kZWMvbXRrX3Zjb2RlY19kZWNfcG0uYwo+IEBAIC03NywxMiArNzcsMTQgQEAgaW50IG10a192 Y29kZWNfaW5pdF9kZWNfcG0oc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiAgIAlwdXRf ZGV2aWNlKHBtLT5sYXJidmRlYyk7Cj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPiArRVhQT1JUX1NZ TUJPTF9HUEwobXRrX3Zjb2RlY19pbml0X2RlY19wbSk7Cj4gICAKPiAgIHZvaWQgbXRrX3Zjb2Rl Y19yZWxlYXNlX2RlY19wbShzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0pCj4gICB7Cj4gICAJcG1f cnVudGltZV9kaXNhYmxlKHBtLT5kZXYpOwo+ICAgCXB1dF9kZXZpY2UocG0tPmxhcmJ2ZGVjKTsK PiAgIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwobXRrX3Zjb2RlY19yZWxlYXNlX2RlY19wbSk7Cj4g ICAKPiAgIGludCBtdGtfdmNvZGVjX2RlY19wd19vbihzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0p Cj4gICB7Cj4gQEAgLTk0LDYgKzk2LDcgQEAgaW50IG10a192Y29kZWNfZGVjX3B3X29uKHN0cnVj dCBtdGtfdmNvZGVjX3BtICpwbSkKPiAgIAo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gK0VYUE9S VF9TWU1CT0xfR1BMKG10a192Y29kZWNfZGVjX3B3X29uKTsKPiAgIAo+ICAgdm9pZCBtdGtfdmNv ZGVjX2RlY19wd19vZmYoc3RydWN0IG10a192Y29kZWNfcG0gKnBtKQo+ICAgewo+IEBAIC0xMDMs NiArMTA2LDcgQEAgdm9pZCBtdGtfdmNvZGVjX2RlY19wd19vZmYoc3RydWN0IG10a192Y29kZWNf cG0gKnBtKQo+ICAgCWlmIChyZXQpCj4gICAJCW10a192NGwyX2VycigicG1fcnVudGltZV9wdXRf c3luYyBmYWlsICVkIiwgcmV0KTsKPiAgIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwobXRrX3Zjb2Rl Y19kZWNfcHdfb2ZmKTsKPiAgIAo+ICAgdm9pZCBtdGtfdmNvZGVjX2RlY19jbG9ja19vbihzdHJ1 Y3QgbXRrX3Zjb2RlY19wbSAqcG0pCj4gICB7Cj4gQEAgLTEyOSw2ICsxMzMsNyBAQCB2b2lkIG10 a192Y29kZWNfZGVjX2Nsb2NrX29uKHN0cnVjdCBtdGtfdmNvZGVjX3BtICpwbSkKPiAgIAlmb3Ig KGkgLT0gMTsgaSA+PSAwOyBpLS0pCj4gICAJCWNsa19kaXNhYmxlX3VucHJlcGFyZShkZWNfY2xr LT5jbGtfaW5mb1tpXS52Y29kZWNfY2xrKTsKPiAgIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwobXRr X3Zjb2RlY19kZWNfY2xvY2tfb24pOwo+ICAgCj4gICB2b2lkIG10a192Y29kZWNfZGVjX2Nsb2Nr X29mZihzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0pCj4gICB7Cj4gQEAgLTEzOSwzICsxNDQsNCBA QCB2b2lkIG10a192Y29kZWNfZGVjX2Nsb2NrX29mZihzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0p Cj4gICAJZm9yIChpID0gZGVjX2Nsay0+Y2xrX251bSAtIDE7IGkgPj0gMDsgaS0tKQo+ICAgCQlj bGtfZGlzYWJsZV91bnByZXBhcmUoZGVjX2Nsay0+Y2xrX2luZm9baV0udmNvZGVjX2Nsayk7Cj4g ICB9Cj4gK0VYUE9SVF9TWU1CT0xfR1BMKG10a192Y29kZWNfZGVjX2Nsb2NrX29mZik7CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRl ayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A9B8C433FE for ; Tue, 30 Nov 2021 13:34:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BFD7A89FC9; Tue, 30 Nov 2021 13:34:19 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 915DB89FC9 for ; Tue, 30 Nov 2021 13:34:17 +0000 (UTC) Received: from [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5] (unknown [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 331AC1F450C4; Tue, 30 Nov 2021 13:34:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638279251; bh=8dFt0ved6B1YlHXel+R6Z2zNSNgLE7JvZbncVuRC5Qw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CXXTXeNJfZ9/XZgE6YFUstBI4Ouw4A5FsgohbT2N95JbtcK2UIipznG5/gVg8Sfem JCpbIkg8WQz69wj4MwV68UV40duRU21gjgJFkjoUma0tvpF6V3TmFiLdyhORfTItD9 /R124eq8PRPWQYM4QqhiMUgfBZnzdfyvYb3rb37PdMwAOuSOQGehdscmDifViugAFH mEhQ/PuzYsPcY/L0OCUhp4r0Gf/lYpE1D+9ZT3iiYuLqFxocIyV+GNSdae1CRYolzI 2PMMkcwokvYFBO1SwrmmVUTFgsj8//HfcsE9pyAjEBFQtt3oBrbKPl3TbheQKrlmRO 8jrbiFcGxJf1A== Subject: Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-5-yunfei.dong@mediatek.com> From: Benjamin Gaignard Message-ID: <2fa4e19f-d57c-6264-4284-8387c4182d1f@collabora.com> Date: Tue, 30 Nov 2021 14:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-5-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Irui Wang , Dafna Hirschfeld , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Fritz Koenig , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le 29/11/2021 à 04:41, Yunfei Dong a écrit : > Register each hardware as platform device, need to call pm functions > to open/close power and clock from module mtk-vcodec-dec, export these > functions. The commit message confuse me, maybe something like: "When mtk vcodec decoder is build as a module we need to export mtk-vcodec-dec pm functions to make them visible by the other components" With that: Reviewed-by: Benjamin Gaignard > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > index 20bd157a855c..221cf60e9fbf 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c > @@ -77,12 +77,14 @@ int mtk_vcodec_init_dec_pm(struct platform_device *pdev, > put_device(pm->larbvdec); > return ret; > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_init_dec_pm); > > void mtk_vcodec_release_dec_pm(struct mtk_vcodec_pm *pm) > { > pm_runtime_disable(pm->dev); > put_device(pm->larbvdec); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_release_dec_pm); > > int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm) > { > @@ -94,6 +96,7 @@ int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm) > > return ret; > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_pw_on); > > void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm) > { > @@ -103,6 +106,7 @@ void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm) > if (ret) > mtk_v4l2_err("pm_runtime_put_sync fail %d", ret); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_pw_off); > > void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm) > { > @@ -129,6 +133,7 @@ void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm) > for (i -= 1; i >= 0; i--) > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_clock_on); > > void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm) > { > @@ -139,3 +144,4 @@ void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm) > for (i = dec_clk->clk_num - 1; i >= 0; i--) > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk); > } > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_clock_off); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 183A1C433F5 for ; Tue, 30 Nov 2021 13:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3bwwQ0YDKiaBQwbCrSmM02HyUf1GkhzRSQrSfC+cgTw=; b=zaJyxE8OEODi2sS47nBhydoIBX Q+l7WMfX5Fy/Nn5jd9LdlMmL6qM7Huwu1qfU2smEKt9Ef2YOvP1DlFrUrT9cUz3J3tcGiwO0YK+Jk hwPNo8/aQivzHujyJ+7rfbzG14eJNA17JLuygaTh+RXuf058VdI0ShGwzXvUN0RNJGJb23f6+5TbN mlrQjGFUoOKwB9aJz4EZ8RUAp+6GTIiDeXjPxy59q4EFIcojj4hxEGw+l/3TkntkAdcPg/qg+koQW mxAG91uukReZcQiG44kAXTSWcKUmvplmx9L0iZPEEOIyYleQXsEAw1YDXHFxaoq4sMeemMLD8UQJq +CFVi2zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3H4-005Lwx-5P; Tue, 30 Nov 2021 13:34:22 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3Gz-005LvY-OQ; Tue, 30 Nov 2021 13:34:19 +0000 Received: from [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5] (unknown [IPv6:2a01:e0a:120:3210:b422:9841:4afb:11b5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 331AC1F450C4; Tue, 30 Nov 2021 13:34:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638279251; bh=8dFt0ved6B1YlHXel+R6Z2zNSNgLE7JvZbncVuRC5Qw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CXXTXeNJfZ9/XZgE6YFUstBI4Ouw4A5FsgohbT2N95JbtcK2UIipznG5/gVg8Sfem JCpbIkg8WQz69wj4MwV68UV40duRU21gjgJFkjoUma0tvpF6V3TmFiLdyhORfTItD9 /R124eq8PRPWQYM4QqhiMUgfBZnzdfyvYb3rb37PdMwAOuSOQGehdscmDifViugAFH mEhQ/PuzYsPcY/L0OCUhp4r0Gf/lYpE1D+9ZT3iiYuLqFxocIyV+GNSdae1CRYolzI 2PMMkcwokvYFBO1SwrmmVUTFgsj8//HfcsE9pyAjEBFQtt3oBrbKPl3TbheQKrlmRO 8jrbiFcGxJf1A== Subject: Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-5-yunfei.dong@mediatek.com> From: Benjamin Gaignard Message-ID: <2fa4e19f-d57c-6264-4284-8387c4182d1f@collabora.com> Date: Tue, 30 Nov 2021 14:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-5-yunfei.dong@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_053418_051186_79DB1A29 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkxlIDI5LzExLzIwMjEgw6AgMDQ6NDEsIFl1bmZlaSBEb25nIGEgw6ljcml0wqA6Cj4gUmVnaXN0 ZXIgZWFjaCBoYXJkd2FyZSBhcyBwbGF0Zm9ybSBkZXZpY2UsIG5lZWQgdG8gY2FsbCBwbSBmdW5j dGlvbnMKPiB0byBvcGVuL2Nsb3NlIHBvd2VyIGFuZCBjbG9jayBmcm9tIG1vZHVsZSBtdGstdmNv ZGVjLWRlYywgZXhwb3J0IHRoZXNlCj4gZnVuY3Rpb25zLgoKVGhlIGNvbW1pdCBtZXNzYWdlIGNv bmZ1c2UgbWUsIG1heWJlIHNvbWV0aGluZyBsaWtlOgoiV2hlbiBtdGsgdmNvZGVjIGRlY29kZXIg aXMgYnVpbGQgYXMgYSBtb2R1bGUgd2UgbmVlZCB0byBleHBvcnQKbXRrLXZjb2RlYy1kZWMgcG0g ZnVuY3Rpb25zIHRvIG1ha2UgdGhlbSB2aXNpYmxlIGJ5IHRoZSBvdGhlciBjb21wb25lbnRzIgoK V2l0aCB0aGF0OgpSZXZpZXdlZC1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWdu YXJkQGNvbGxhYm9yYS5jb20+Cgo+Cj4gU2lnbmVkLW9mZi1ieTogWXVuZmVpIERvbmcgPHl1bmZl aS5kb25nQG1lZGlhdGVrLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRr LXZjb2RlYy9tdGtfdmNvZGVjX2RlY19wbS5jIHwgNiArKysrKysKPiAgIDEgZmlsZSBjaGFuZ2Vk LCA2IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L210ay12Y29kZWMvbXRrX3Zjb2RlY19kZWNfcG0uYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v bXRrLXZjb2RlYy9tdGtfdmNvZGVjX2RlY19wbS5jCj4gaW5kZXggMjBiZDE1N2E4NTVjLi4yMjFj ZjYwZTlmYmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVj L210a192Y29kZWNfZGVjX3BtLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay12 Y29kZWMvbXRrX3Zjb2RlY19kZWNfcG0uYwo+IEBAIC03NywxMiArNzcsMTQgQEAgaW50IG10a192 Y29kZWNfaW5pdF9kZWNfcG0oc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiAgIAlwdXRf ZGV2aWNlKHBtLT5sYXJidmRlYyk7Cj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPiArRVhQT1JUX1NZ TUJPTF9HUEwobXRrX3Zjb2RlY19pbml0X2RlY19wbSk7Cj4gICAKPiAgIHZvaWQgbXRrX3Zjb2Rl Y19yZWxlYXNlX2RlY19wbShzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0pCj4gICB7Cj4gICAJcG1f cnVudGltZV9kaXNhYmxlKHBtLT5kZXYpOwo+ICAgCXB1dF9kZXZpY2UocG0tPmxhcmJ2ZGVjKTsK PiAgIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwobXRrX3Zjb2RlY19yZWxlYXNlX2RlY19wbSk7Cj4g ICAKPiAgIGludCBtdGtfdmNvZGVjX2RlY19wd19vbihzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0p Cj4gICB7Cj4gQEAgLTk0LDYgKzk2LDcgQEAgaW50IG10a192Y29kZWNfZGVjX3B3X29uKHN0cnVj dCBtdGtfdmNvZGVjX3BtICpwbSkKPiAgIAo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gK0VYUE9S VF9TWU1CT0xfR1BMKG10a192Y29kZWNfZGVjX3B3X29uKTsKPiAgIAo+ICAgdm9pZCBtdGtfdmNv ZGVjX2RlY19wd19vZmYoc3RydWN0IG10a192Y29kZWNfcG0gKnBtKQo+ICAgewo+IEBAIC0xMDMs NiArMTA2LDcgQEAgdm9pZCBtdGtfdmNvZGVjX2RlY19wd19vZmYoc3RydWN0IG10a192Y29kZWNf cG0gKnBtKQo+ICAgCWlmIChyZXQpCj4gICAJCW10a192NGwyX2VycigicG1fcnVudGltZV9wdXRf c3luYyBmYWlsICVkIiwgcmV0KTsKPiAgIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwobXRrX3Zjb2Rl Y19kZWNfcHdfb2ZmKTsKPiAgIAo+ICAgdm9pZCBtdGtfdmNvZGVjX2RlY19jbG9ja19vbihzdHJ1 Y3QgbXRrX3Zjb2RlY19wbSAqcG0pCj4gICB7Cj4gQEAgLTEyOSw2ICsxMzMsNyBAQCB2b2lkIG10 a192Y29kZWNfZGVjX2Nsb2NrX29uKHN0cnVjdCBtdGtfdmNvZGVjX3BtICpwbSkKPiAgIAlmb3Ig KGkgLT0gMTsgaSA+PSAwOyBpLS0pCj4gICAJCWNsa19kaXNhYmxlX3VucHJlcGFyZShkZWNfY2xr LT5jbGtfaW5mb1tpXS52Y29kZWNfY2xrKTsKPiAgIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwobXRr X3Zjb2RlY19kZWNfY2xvY2tfb24pOwo+ICAgCj4gICB2b2lkIG10a192Y29kZWNfZGVjX2Nsb2Nr X29mZihzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0pCj4gICB7Cj4gQEAgLTEzOSwzICsxNDQsNCBA QCB2b2lkIG10a192Y29kZWNfZGVjX2Nsb2NrX29mZihzdHJ1Y3QgbXRrX3Zjb2RlY19wbSAqcG0p Cj4gICAJZm9yIChpID0gZGVjX2Nsay0+Y2xrX251bSAtIDE7IGkgPj0gMDsgaS0tKQo+ICAgCQlj bGtfZGlzYWJsZV91bnByZXBhcmUoZGVjX2Nsay0+Y2xrX2luZm9baV0udmNvZGVjX2Nsayk7Cj4g ICB9Cj4gK0VYUE9SVF9TWU1CT0xfR1BMKG10a192Y29kZWNfZGVjX2Nsb2NrX29mZik7CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==