From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37518C04AB5 for ; Tue, 4 Jun 2019 01:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11D8C261F5 for ; Tue, 4 Jun 2019 01:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbfFDBqu (ORCPT ); Mon, 3 Jun 2019 21:46:50 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:38100 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725876AbfFDBqt (ORCPT ); Mon, 3 Jun 2019 21:46:49 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7BA1C55AF8D62E01697B; Tue, 4 Jun 2019 09:46:47 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Jun 2019 09:46:44 +0800 Subject: Re: [PATCH v3 3/4] f2fs: Fix accounting for unusable blocks To: Jaegeuk Kim CC: Daniel Rosenberg , Jonathan Corbet , , , , , References: <20190530004906.261170-1-drosen@google.com> <20190530004906.261170-4-drosen@google.com> <20190603202630.GB34729@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <2fbeda5b-50d6-a8c2-06a9-dddf5d466de8@huawei.com> Date: Tue, 4 Jun 2019 09:46:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190603202630.GB34729@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/6/4 4:26, Jaegeuk Kim wrote: > On 06/03, Chao Yu wrote: >> On 2019/5/30 8:49, Daniel Rosenberg wrote: >>> Fixes possible underflows when dealing with unusable blocks. >>> >>> Signed-off-by: Daniel Rosenberg >>> --- >>> fs/f2fs/f2fs.h | 15 ++++++++++----- >>> 1 file changed, 10 insertions(+), 5 deletions(-) >>> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>> index 9b3d9977cd1ef..a39cc4ffeb4b1 100644 >>> --- a/fs/f2fs/f2fs.h >>> +++ b/fs/f2fs/f2fs.h >>> @@ -1769,8 +1769,12 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi, >>> >>> if (!__allow_reserved_blocks(sbi, inode, true)) >>> avail_user_block_count -= F2FS_OPTION(sbi).root_reserved_blocks; >>> - if (unlikely(is_sbi_flag_set(sbi, SBI_CP_DISABLED))) >>> - avail_user_block_count -= sbi->unusable_block_count; >>> + if (unlikely(is_sbi_flag_set(sbi, SBI_CP_DISABLED))) { >>> + if (avail_user_block_count > sbi->unusable_block_count) >>> + avail_user_block_count = 0; >> >> avail_user_block_count -= sbi->unusable_block_count; >> >>> + else >>> + avail_user_block_count -= sbi->unusable_block_count; >> >> avail_user_block_count = 0; >> > > I fixed this. Okay, if there is no v4, please add Reviewed-by: Chao Yu Thanks, > > Thanks, > >> Thanks, >> >>> + } >>> if (unlikely(sbi->total_valid_block_count > avail_user_block_count)) { >>> diff = sbi->total_valid_block_count - avail_user_block_count; >>> if (diff > *count) >>> @@ -1970,7 +1974,7 @@ static inline int inc_valid_node_count(struct f2fs_sb_info *sbi, >>> struct inode *inode, bool is_inode) >>> { >>> block_t valid_block_count; >>> - unsigned int valid_node_count; >>> + unsigned int valid_node_count, user_block_count; >>> int err; >>> >>> if (is_inode) { >>> @@ -1997,10 +2001,11 @@ static inline int inc_valid_node_count(struct f2fs_sb_info *sbi, >>> >>> if (!__allow_reserved_blocks(sbi, inode, false)) >>> valid_block_count += F2FS_OPTION(sbi).root_reserved_blocks; >>> + user_block_count = sbi->user_block_count; >>> if (unlikely(is_sbi_flag_set(sbi, SBI_CP_DISABLED))) >>> - valid_block_count += sbi->unusable_block_count; >>> + user_block_count -= sbi->unusable_block_count; >>> >>> - if (unlikely(valid_block_count > sbi->user_block_count)) { >>> + if (unlikely(valid_block_count > user_block_count)) { >>> spin_unlock(&sbi->stat_lock); >>> goto enospc; >>> } >>> > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH v3 3/4] f2fs: Fix accounting for unusable blocks Date: Tue, 4 Jun 2019 09:46:43 +0800 Message-ID: <2fbeda5b-50d6-a8c2-06a9-dddf5d466de8@huawei.com> References: <20190530004906.261170-1-drosen@google.com> <20190530004906.261170-4-drosen@google.com> <20190603202630.GB34729@jaegeuk-macbookpro.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hXyXT-00030V-HI for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Jun 2019 01:46:59 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hXyXR-004vaC-Fq for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Jun 2019 01:46:59 +0000 In-Reply-To: <20190603202630.GB34729@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: Daniel Rosenberg , linux-doc@vger.kernel.org, Jonathan Corbet , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, kernel-team@android.com On 2019/6/4 4:26, Jaegeuk Kim wrote: > On 06/03, Chao Yu wrote: >> On 2019/5/30 8:49, Daniel Rosenberg wrote: >>> Fixes possible underflows when dealing with unusable blocks. >>> >>> Signed-off-by: Daniel Rosenberg >>> --- >>> fs/f2fs/f2fs.h | 15 ++++++++++----- >>> 1 file changed, 10 insertions(+), 5 deletions(-) >>> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>> index 9b3d9977cd1ef..a39cc4ffeb4b1 100644 >>> --- a/fs/f2fs/f2fs.h >>> +++ b/fs/f2fs/f2fs.h >>> @@ -1769,8 +1769,12 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi, >>> >>> if (!__allow_reserved_blocks(sbi, inode, true)) >>> avail_user_block_count -= F2FS_OPTION(sbi).root_reserved_blocks; >>> - if (unlikely(is_sbi_flag_set(sbi, SBI_CP_DISABLED))) >>> - avail_user_block_count -= sbi->unusable_block_count; >>> + if (unlikely(is_sbi_flag_set(sbi, SBI_CP_DISABLED))) { >>> + if (avail_user_block_count > sbi->unusable_block_count) >>> + avail_user_block_count = 0; >> >> avail_user_block_count -= sbi->unusable_block_count; >> >>> + else >>> + avail_user_block_count -= sbi->unusable_block_count; >> >> avail_user_block_count = 0; >> > > I fixed this. Okay, if there is no v4, please add Reviewed-by: Chao Yu Thanks, > > Thanks, > >> Thanks, >> >>> + } >>> if (unlikely(sbi->total_valid_block_count > avail_user_block_count)) { >>> diff = sbi->total_valid_block_count - avail_user_block_count; >>> if (diff > *count) >>> @@ -1970,7 +1974,7 @@ static inline int inc_valid_node_count(struct f2fs_sb_info *sbi, >>> struct inode *inode, bool is_inode) >>> { >>> block_t valid_block_count; >>> - unsigned int valid_node_count; >>> + unsigned int valid_node_count, user_block_count; >>> int err; >>> >>> if (is_inode) { >>> @@ -1997,10 +2001,11 @@ static inline int inc_valid_node_count(struct f2fs_sb_info *sbi, >>> >>> if (!__allow_reserved_blocks(sbi, inode, false)) >>> valid_block_count += F2FS_OPTION(sbi).root_reserved_blocks; >>> + user_block_count = sbi->user_block_count; >>> if (unlikely(is_sbi_flag_set(sbi, SBI_CP_DISABLED))) >>> - valid_block_count += sbi->unusable_block_count; >>> + user_block_count -= sbi->unusable_block_count; >>> >>> - if (unlikely(valid_block_count > sbi->user_block_count)) { >>> + if (unlikely(valid_block_count > user_block_count)) { >>> spin_unlock(&sbi->stat_lock); >>> goto enospc; >>> } >>> > . >