From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5A95C433F5 for ; Mon, 24 Jan 2022 11:50:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E082310E669; Mon, 24 Jan 2022 11:50:29 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88C5D10E669 for ; Mon, 24 Jan 2022 11:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643025027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnozPUrejpB8IY9KHbWAe0uFCpl2C3OVRF4UKq2Q7OA=; b=dvCAHkI356POfHW+B8c3F65OPSLOPVmKTaZGlF1g/GjgwTFAkn1JqhabKIGhE2x7UHy6rz I8YTdGGz6PzyDv6o4MsrOfc5SjmI9A3W8YR0uD6tJskV0HkORUMTfU8hE+INcAClo71pRS oBjzP9UjQFaJTMwqraatVc4pX6GrR6I= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-d6aUxfsjO_a6gfnXFqLhsw-1; Mon, 24 Jan 2022 06:50:24 -0500 X-MC-Unique: d6aUxfsjO_a6gfnXFqLhsw-1 Received: by mail-wr1-f72.google.com with SMTP id t13-20020adfa2cd000000b001d09443ee4fso1768158wra.3 for ; Mon, 24 Jan 2022 03:50:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SnozPUrejpB8IY9KHbWAe0uFCpl2C3OVRF4UKq2Q7OA=; b=LeQTTy6RdaJMfYBjBCYrfhm9/DXsFFtHGlf8bSrkeNwjMfl7dQZmiTscTOVecm7b2n MD0RDKm5OYDuOAmms/xwQUaAkN+3CIalPgVBFF1yqkEwDM8Fvl4zxG9ttdq0yzK3vdcw KvUiu0H2F4xeEkI0tT6XnL1peMTI/5Dab1JUYHNArIl0QOQ3huwGlBompGLGXmMNwMEO aJh7QcLoySnPHK9D+HuPMyNfQ6oXxYMqk/NFgPS5aQzZ6oy7/FTeM5WH20OW3z0v3Jai DWjA9/YW8vibfFZobWSrQ8/XKNrnM+1vJ8B2fPmzX3TmSp37PSmeoYfnfyV+HVZ30b+j zltQ== X-Gm-Message-State: AOAM531W1i/GJ4R8I1JZYf1F40kgGXi6w9nlYJXgttIXZrLhIdArfVku aWKG4v191AEz2wxhPYcy3toYdZ60gUjKUlEMiSjtkQQYzZ+iZh6H/v+KsYRG/wwB++yExWIfGgY FafLstAOKgqV+9Ka4BkOtOa2g7pcE X-Received: by 2002:a5d:588d:: with SMTP id n13mr14154332wrf.153.1643025022929; Mon, 24 Jan 2022 03:50:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwc+T8f2EA0pQatiSUAYWsweg14f3Fap55QqOPYFQTgJZjANOOALIERHOvplEdlRysuwhZ5oQ== X-Received: by 2002:a5d:588d:: with SMTP id n13mr14154313wrf.153.1643025022753; Mon, 24 Jan 2022 03:50:22 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id o12sm6904445wry.115.2022.01.24.03.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 03:50:22 -0800 (PST) Message-ID: <2fc200bb-4b40-7833-31c9-90a78512b601@redhat.com> Date: Mon, 24 Jan 2022 12:50:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" To: Thomas Zimmermann , Helge Deller , Gerd Hoffmann References: <20220119110839.33187-1-deller@gmx.de> <20220119110839.33187-3-deller@gmx.de> <6c000477-002b-d125-b945-2c4831bad8a5@gmx.de> <20220121072006.ylw2hdl7jbkbwnre@sirius.home.kraxel.org> <64fd46cb-9746-3fd0-ec92-c64dba76875a@gmx.de> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Sven Schnelle , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Linus Torvalds , Tomi Valkeinen , Claudio Suarez , Pavel Machek , Daniel Vetter , Geert Uytterhoeven , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/24/22 12:33, Thomas Zimmermann wrote: [snip] >> Thoughts? > > I can't say I approve keeping fbdev alive, but... > > With fbdev emulation, every DRM driver is an fbdev driver too. So > CONFIG_FB_DRIVER is somewhat misleading. Better add an option like > CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that > absolutely need HW acceleration. That option would then protect the rsp > code. > Agreed that this option would be better and allow distros to disable the code that was reverted. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE87C433EF for ; Mon, 24 Jan 2022 11:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238020AbiAXLvB (ORCPT ); Mon, 24 Jan 2022 06:51:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58879 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232727AbiAXLu0 (ORCPT ); Mon, 24 Jan 2022 06:50:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643025025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnozPUrejpB8IY9KHbWAe0uFCpl2C3OVRF4UKq2Q7OA=; b=JVTEjfW/LMZ7ET7+DToX28Y9KUrB0pHMR2Si9QwtKiOtVZXKU8dQ4/Tu1SU3qwnaK568rf 2cjMT1E1bxNKwxaoTyqLhdI5dbYh+qTntTW912HUVojVZvnd0e3pc7IXRWpUTm+ZUpt/2v Fn0bty+/AahGfeTKUHr+RUlnYsVFNZ0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-394-x7h2y1_WMWuJmnQqXXIWPw-1; Mon, 24 Jan 2022 06:50:24 -0500 X-MC-Unique: x7h2y1_WMWuJmnQqXXIWPw-1 Received: by mail-wr1-f70.google.com with SMTP id a6-20020adfbc46000000b001d7370ace6eso1770367wrh.9 for ; Mon, 24 Jan 2022 03:50:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SnozPUrejpB8IY9KHbWAe0uFCpl2C3OVRF4UKq2Q7OA=; b=jHi6VadODXiQgeEp+UrnQpsseLDOAqNfKB02ppPht1oYOu7ew2N8gue4kO+A/KEhzu uJhGphkd8WRYfP5OYW0Pz9hYxu/xVDU0y/9CojyZ2ekJCSF4SkQbDGldRgsGfc4sAczP zGMu+h5NEpOqflZbXBEMk9Mh9K5EOxmdbguhe/nzjLWQitJpgxLCgGzifLnBJLVatgjS dqSYy3R+QzbhPpe95Mfu4u+vmddQUkUvltnH3QONy+FZ0+xcyYQTsm33yg3UTmMn1okb Bnq/zMTVOVFsFRc3mC55k5zmoo08erWgG82K8x7rDZqLZyb4DpmLXfammgd6ACMerom1 dmWg== X-Gm-Message-State: AOAM530OhUwJBv3kjbZ6h6C59XghrggUsrb7JYl+f7GJyTgeuFBL9BiG E6Knbb23IHDtZP3U3vOcqyIZYDhxdtY5nZb1BZZ7t5VJ9UEw/2iXXD5OU9zUjzQ440e8w37Crna xULhG3knNzChrORm6PEtry57o X-Received: by 2002:a5d:588d:: with SMTP id n13mr14154334wrf.153.1643025022929; Mon, 24 Jan 2022 03:50:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwc+T8f2EA0pQatiSUAYWsweg14f3Fap55QqOPYFQTgJZjANOOALIERHOvplEdlRysuwhZ5oQ== X-Received: by 2002:a5d:588d:: with SMTP id n13mr14154313wrf.153.1643025022753; Mon, 24 Jan 2022 03:50:22 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id o12sm6904445wry.115.2022.01.24.03.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 03:50:22 -0800 (PST) Message-ID: <2fc200bb-4b40-7833-31c9-90a78512b601@redhat.com> Date: Mon, 24 Jan 2022 12:50:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Content-Language: en-US To: Thomas Zimmermann , Helge Deller , Gerd Hoffmann Cc: linux-fbdev@vger.kernel.org, Pavel Machek , Sam Ravnborg , Greg Kroah-Hartman , Sven Schnelle , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Claudio Suarez , Tomi Valkeinen , Geert Uytterhoeven , Daniel Vetter , Linus Torvalds References: <20220119110839.33187-1-deller@gmx.de> <20220119110839.33187-3-deller@gmx.de> <6c000477-002b-d125-b945-2c4831bad8a5@gmx.de> <20220121072006.ylw2hdl7jbkbwnre@sirius.home.kraxel.org> <64fd46cb-9746-3fd0-ec92-c64dba76875a@gmx.de> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/22 12:33, Thomas Zimmermann wrote: [snip] >> Thoughts? > > I can't say I approve keeping fbdev alive, but... > > With fbdev emulation, every DRM driver is an fbdev driver too. So > CONFIG_FB_DRIVER is somewhat misleading. Better add an option like > CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that > absolutely need HW acceleration. That option would then protect the rsp > code. > Agreed that this option would be better and allow distros to disable the code that was reverted. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat