All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 7/8] configure, meson: move config-poison.h to meson
Date: Tue, 21 Dec 2021 13:54:32 -0800	[thread overview]
Message-ID: <2fcd10a3-19d0-5aad-b3c0-9ba5947b4442@linaro.org> (raw)
In-Reply-To: <20211221110526.351709-8-pbonzini@redhat.com>

On 12/21/21 3:05 AM, Paolo Bonzini wrote:
> +genh += custom_target('config-poison.h',
> +                      input: [target_configs_h],
> +                      output: 'config-poison.h',
> +                      capture: true,
> +                      command: [find_program('scripts/make-config-poison.sh')] +
> +                               (target_configs_h.length() > 0 ? ['@INPUT@'] : []))

Using length + @INPUT@ seems needlessly around the bush.
Perhaps better as

   [find_program...] + target_configs_h

Otherwise it looks ok.


r~


  reply	other threads:[~2021-12-21 21:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 11:05 [PATCH 0/8] Next round of configure/meson cleanups Paolo Bonzini
2021-12-21 11:05 ` [PATCH 1/8] configure: simplify creation of plugin symbol list Paolo Bonzini
2021-12-21 20:50   ` Richard Henderson
2021-12-21 11:05 ` [PATCH 2/8] configure: do not set bsd_user/linux_user early Paolo Bonzini
2021-12-21 20:55   ` Richard Henderson
2021-12-21 11:05 ` [PATCH 3/8] configure, makefile: remove traces of really old files Paolo Bonzini
2021-12-21 20:59   ` Richard Henderson
2021-12-21 11:05 ` [PATCH 4/8] configure: parse --enable/--disable-strip automatically, flip default Paolo Bonzini
2021-12-21 11:05 ` [PATCH 5/8] configure: move non-command-line variables away from command-line parsing section Paolo Bonzini
2021-12-21 11:30   ` Philippe Mathieu-Daudé
2021-12-21 11:05 ` [PATCH 6/8] meson: build contrib/ executables after generated headers Paolo Bonzini
2021-12-21 11:32   ` Philippe Mathieu-Daudé
2021-12-21 11:05 ` [PATCH 7/8] configure, meson: move config-poison.h to meson Paolo Bonzini
2021-12-21 21:54   ` Richard Henderson [this message]
2021-12-21 11:05 ` [PATCH 8/8] meson: add comments in the target-specific flags section Paolo Bonzini
2021-12-21 11:32   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fcd10a3-19d0-5aad-b3c0-9ba5947b4442@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.