From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2C64C38A2A for ; Sat, 9 May 2020 03:13:22 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4B68F216FD for ; Sat, 9 May 2020 03:13:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B68F216FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCF411BF8F; Sat, 9 May 2020 05:13:20 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 836D11DB8; Sat, 9 May 2020 05:13:18 +0200 (CEST) IronPort-SDR: 3pSlaHl6hr4OtLlPT5Weqz4ePQnvQ0XPeHowqmB32Tn+COPa0sc5Y+nnfw+qLXdi1GfRk8DaFx Of3beUqdBJVw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 20:13:17 -0700 IronPort-SDR: CnkfC48dnBfTlroYEDAtsvALBhWS+NfBS5Gh0XkZyJcIuievWdt6AwjzHgHI56JTUGd+uV5Fj0 jabPATS0kxlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,370,1583222400"; d="scan'208";a="408313220" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 08 May 2020 20:13:17 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 20:13:16 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 9 May 2020 11:13:14 +0800 Received: from shsmsx604.ccr.corp.intel.com ([10.109.6.214]) by SHSMSX604.ccr.corp.intel.com ([10.109.6.214]) with mapi id 15.01.1713.004; Sat, 9 May 2020 11:13:14 +0800 From: "Jiang, YuX" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Sun, GuinanX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Thread-Index: AQHWJRVw4Qxx1lh7dEO6Nlj4oef6WaifFUJg Date: Sat, 9 May 2020 03:13:14 +0000 Message-ID: <2fd507e9d5774171b14792c6fa3b8d62@intel.com> References: <20200508082939.32525-1-guinanx.sun@intel.com> In-Reply-To: <20200508082939.32525-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Jiang, YuX -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Guinan Sun Sent: Friday, May 8, 2020 4:30 PM To: dev@dpdk.org Cc: Sun, GuinanX ; stable@dpdk.org Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control= mode The register autoneg can't be updated synchronously with flow control mode = setting in the state of port start , so NIC statistics error occurs. The pa= tch fixes the issue. Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") Cc: stable@dpdk.org Signed-off-by: Guinan Sun --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_eth= dev.c index cf5f1fe70..e6c747aef 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struc= t ixgbe_hw *hw) int err; uint32_t mflcn; =20 + hw->mac.ops.setup_fc(hw); + err =3D ixgbe_fc_enable(hw); =20 /* Not negotiated is not an error case */ -- 2.17.1