From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] net: designware: fix tx packet length
Date: Mon, 10 Dec 2018 05:08:50 +0100 [thread overview]
Message-ID: <2fe15f23-4c7f-d078-8585-f83750aeab0b@denx.de> (raw)
In-Reply-To: <49b819c6-836c-0923-a19d-493705b63274@gmail.com>
On 12/09/2018 09:50 PM, Simon Goldschmidt wrote:
> Am 17.11.2018 um 17:02 schrieb Joe Hershberger:
>> On Sat, Nov 17, 2018 at 3:25 AM Simon Goldschmidt
>> <simon.k.r.goldschmidt@gmail.com> wrote:
>>>
>>> The designware driver has a bug in setting the tx length into the dma
>>> descriptor: it always or's the length into the descriptor without
>>> zeroing out the length mask before.
>>>
>>> This results in occasional packets being transmitted with a length
>>> greater than they should be (trailer). Due to the nature of Ethernet
>>> allowing such a trailer, most packets seem to be parsed fine by remote
>>> hosts, which is probably why this hasn't been noticed.
>>>
>>> Fix this by correctly clearing the size mask before setting the new
>>> length.
>>>
>>> Tested on socfpga gen5.
>>>
>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>
>
> Marek, this and 2/2 is a assigned to you in patchwork, will you push
> them or is it Joe's code as u-boot-net maintainer?
This is net , so Joe should pick it .
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-12-10 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 9:24 [U-Boot] [PATCH 1/2] net: designware: fix tx packet length Simon Goldschmidt
2018-11-17 9:24 ` [U-Boot] [PATCH 2/2] net: designware: clear padding bytes Simon Goldschmidt
2018-11-17 16:03 ` Joe Hershberger
2018-11-24 19:08 ` Simon Goldschmidt
2019-01-24 17:37 ` [U-Boot] " Joe Hershberger
2018-11-17 16:02 ` [U-Boot] [PATCH 1/2] net: designware: fix tx packet length Joe Hershberger
2018-12-09 20:50 ` Simon Goldschmidt
2018-12-10 4:08 ` Marek Vasut [this message]
2019-01-14 15:35 ` Simon Goldschmidt
2018-12-09 21:36 ` Philipp Tomsich
2019-01-24 17:37 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fe15f23-4c7f-d078-8585-f83750aeab0b@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.