From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31692C2D0E4 for ; Tue, 17 Nov 2020 04:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB2152469C for ; Tue, 17 Nov 2020 04:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727023AbgKQEOX (ORCPT ); Mon, 16 Nov 2020 23:14:23 -0500 Received: from m9785.mail.qiye.163.com ([220.181.97.85]:3709 "EHLO m9785.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbgKQEOW (ORCPT ); Mon, 16 Nov 2020 23:14:22 -0500 Received: from [192.168.188.14] (unknown [106.75.220.2]) by m9785.mail.qiye.163.com (Hmail) with ESMTPA id 03CC05C1955; Tue, 17 Nov 2020 12:01:42 +0800 (CST) Subject: Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support. To: Cong Wang Cc: Jakub Kicinski , Marcelo Ricardo Leitner , Vlad Buslov , Linux Kernel Network Developers References: <1605151497-29986-1-git-send-email-wenxu@ucloud.cn> <1605151497-29986-4-git-send-email-wenxu@ucloud.cn> <459a1453-8026-cca1-fb7c-ded0890992cf@ucloud.cn> From: wenxu Message-ID: <2fe1ec73-eeeb-f32e-b006-afd135e03433@ucloud.cn> Date: Tue, 17 Nov 2020 12:01:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSUI3V1ktWUFJV1kPCR oVCBIfWUFZHxlPT0JOTEtPSkJIVkpNS05OQ05MS0hJTklVGRETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKQ1VLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Mz46Kzo5Qz0yCD1KS0gpAQNM EgIaChFVSlVKTUtOTkNOTEtIT0lMVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpLTVVM TlVJSUtVSVlXWQgBWUFISENDNwY+ X-HM-Tid: 0a75d45d91252087kuqy03cc05c1955 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/17/2020 3:01 AM, Cong Wang wrote: > On Sun, Nov 15, 2020 at 5:06 AM wenxu wrote: >> >> 在 2020/11/15 2:05, Cong Wang 写道: >>> On Wed, Nov 11, 2020 at 9:44 PM wrote: >>>> diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c >>>> new file mode 100644 >>>> index 0000000..3a7ab92 >>>> --- /dev/null >>>> +++ b/net/sched/act_frag.c >>> It is kinda confusing to see this is a module. It provides some >>> wrappers and hooks the dev_xmit_queue(), it belongs more to >>> the core tc code than any modularized code. How about putting >>> this into net/sched/sch_generic.c? >>> >>> Thanks. >> All the operations in the act_frag are single L3 action. >> >> So we put in a single module. to keep it as isolated/contained as possible > Yeah, but you hook dev_queue_xmit() which is L2. > >> Maybe put this in a single file is better than a module? Buildin in the tc core code or not. >> >> Enable this feature in Kconifg with NET_ACT_FRAG? > Sort of... If this is not an optional feature, that is a must-have > feature for act_ct, > we should just get rid of this Kconfig. > > Also, you need to depend on CONFIG_INET somewhere to use the IP > fragment, no? > > Thanks. Maybe the act_frag should rename to sch_frag and buildin kernel. This fcuntion can be used for all tc subsystem. There is no need for CONFIG_INET. The sched system depends on NET. >