Re: [RFC PATCH v1 6/8] xen: sched: Credit2 group-scheduling: selecting next vcpu to run

[George Dunlap <george.dunlap@citrix.com>]

On 10/12/18 6:44 PM, Dario Faggioli wrote:
> When chosing which vcpu to run next, on a CPU which is in a group where
> other vcpus are running already, only consider vcpus of the same domain
> (of those vcpus that are running already!).
> 
> This is as easy as, in runq_candidate(), while traversing the runqueue,
> skipping the vcpus that do not satisfy the group-scheduling constraints.
> 
> And now that such constraints are actually enforced, also add an ASSERT()
> that checks that we really respect them.
> 
> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>

As a data point in the "number of tags" question:
1. my normal way of importing a series is to use `stg import` on a
single mbox file;
2. if something doesn't apply cleanly, I often fix it up and re-apply
using `-i` to say, "ignore already-applied-patches"
3. stgit seems to use the name of the patch to determine if the patch
has been applied or not
4. For 'name', it only uses the first four words it can see.

So, after fixing up some trivial porting issues in earlier patches, I
got this:

$ stg import -i --reject -M "/tmp/dariof.credit2-core-scheduling.rfc-v1"
Checking for changes in the working directory ... done
Ignoring already applied patch "xen-sched-credit2-during"
Ignoring already applied patch "xen-sched-credit2-avoid"
Ignoring already applied patch "xen-sched-credit2-show"
Ignoring already applied patch "xen-sched-credit2-generalize"
Ignoring already applied patch "xen-sched-credit2-group"
Ignoring already applied patch "xen-sched-credit2-group"
Ignoring already applied patch "xen-sched-credit2-group"
Ignoring already applied patch "xen-sched-credit2-group"
Now at patch "xen-sched-credit2-group"

That is, it only applied the first of the last four patches, because
they all look the same to it.

Obviously that's somewhat of a deficiency in stackgit, but it
demonstrates the weird issues you run into when your description line
has too many tags. :-)

I'll pull the branch from xenbits mentioned in the cover letter.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel