From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct Date: Fri, 27 Feb 2015 15:52:11 +0100 Message-ID: <3000732.Asrn3KzfLt@xps13> References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: "Liang, Cunming" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-27 11:28, Liang, Cunming: > From: David Marchand [mailto:david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Friday, February 27, 2015 6:33 PM > > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang wrote: > > > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts= .h > > > +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts= .h > > > @@ -38,6 +38,9 @@ > > >=20 > > > #ifndef _RTE_LINUXAPP_INTERRUPTS_H_ > > > #define _RTE_LINUXAPP_INTERRUPTS_H_ > > >=20 > > > +#define VFIO_MAX_RXTX_INTR_ID 32 > > > +#define VFIO_MAX_QUEUE_ID VFIO_MAX_RXTX_INTR_ID > >=20 > > This is a little weird to talk about vfio here. > > This file is "generic". > >=20 > > Ok, you will store vfio eventfds here, but vfio is an implementatio= n, > > not the abstraction. >=20 > [Liang, Cunming] If looking at the rte_intr_hanle_type, it includes U= IO/VFIO_LEGACY/VFIO_MSI/VFIO_MSIX. > I agree, VFIO is an implementation, but the different type combinatio= n is a kind of =E2=80=98abstraction=E2=80=99. > So in rte_intr_handle (like a multiplexing), some specified field for= vfio interrupter mapping, I feel it=E2=80=99s reasonable. Not sure to understand. Are we trying to mask the different kernel driv= ers from an application point of view, and provide a generic interrupt mech= anism? If yes, why some VFIO constants are needed? I'm not saying that the current implementation is perfect, but we shoul= d try to improve it. Thanks