From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862E8C433EF for ; Tue, 17 May 2022 06:52:20 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8284A4068B; Tue, 17 May 2022 08:52:19 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 5C20C40041 for ; Tue, 17 May 2022 08:52:18 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0C0725C019C; Tue, 17 May 2022 02:52:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 17 May 2022 02:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652770337; x= 1652856737; bh=E0HwrukomQ2xwDVN4StcaefmApq3eu3cNHGl6ccSkfw=; b=D iCqZWW9gxrydtkMVxLpOn0dvz/+906nEPOCZvAioZpoFIIDyCOJHAwxP7Uw/RkpM p9mNUTrdVx1TPZAc8KbI8opzLWpo/MErntPdEy7h/jjMQufcBJDQ24Ui12S4+5sL nXs8sbret3QUEUCk/ufeZ/WJb13sxceOKgL8PLf/M0L4MwD8eBRLsXEBtIJACLdR SE/NNLsVSv6CibSjNm/465IT+sfNSMAvwwGTE912Wmlq0Mmy9SMN+c2wuPGoqot4 3Z/rBwvdlUifTklOUAw6qpkT16Svloc1LZgbI7YZ7QYoNs3uhdcenjX2t8lwOdhu NeumN1XGXeFBInGAEkJgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652770337; x= 1652856737; bh=E0HwrukomQ2xwDVN4StcaefmApq3eu3cNHGl6ccSkfw=; b=M G6evys7eB8XH2suL+H3MW6U5b8gdDk0m1jwuGYSX6qvFU+4MtlFZb6qvPLWqa0yv hekh+akdx2S6IfsyHComdTFC6YoVJenwC9iflQ0X3QUdO5EQqfE4Ay5pMdmqAH+5 uxM3Pb8+obD60QWzQ+c6SlMrb0/R3/KWvPPF9s5WSFgYRZOxXQjVsxC0nGSKAVl9 /Iw/DusZxDf44AOhOMyOosCZ/nv57nt9ugQl3C9/1A25IHJUm/5cvP6mmbGmuuHs qZY2K8q076SP0IF4luogyzlexvWs8JCjpq4Bw8MUwPF/KLvfSc57EKZOysdHBT7Y 9sRnSZDVLy+JwZrcy3hbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheeigdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 May 2022 02:52:15 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: "Wu, Wenjun1" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: Re: [PATCH v1] net/iavf: fix resource leak issue Date: Tue, 17 May 2022 08:52:07 +0200 Message-ID: <3000980.U7HbjWM52l@thomas> In-Reply-To: References: <20220510005425.1648591-1-wenjun1.wu@intel.com> <4f57fe1f407d4cec8d506fdf3339d645@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/05/2022 02:59, Zhang, Qi Z: > From: Zhang, Qi Z > > From: Thomas Monjalon > > > 12/05/2022 02:20, Zhang, Qi Z: > > > > From: Thomas Monjalon > > > > > 11/05/2022 17:31, Zhang, Qi Z: > > > > > > From: Thomas Monjalon > > > > > > > 11/05/2022 13:46, Zhang, Qi Z: > > > > > > > > From: Wu, Wenjun1 > > > > > > > > > > > > > > > > > > This patch fixes resource leak issue reported by coverity. > > > > > > > > > > > > > > > > > > Coverity issue: 378017 > > > > > > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size > > > > > > > > > configuration") > > > > > > > > > > > > > > > > > > Signed-off-by: Wenjun Wu > > > > > > > > > > > > > > > > Acked-by: Qi Zhang > > > > > > > > > > > > > > > > Applied to dpdk-next-net-intel. > > > > > > > > > > > > > > In the title, the word "issue" is useless. > > > > > > > It would be more interesting to precise where is the leak. > > > > > > > > > > > > > > > > > > > Added below into commit log in dpdk-next-net-intel. > > > > > > > > > > > > kvlist should be freed before return an error due to invalid quanta size. > > > > > > > > > > It does not explain what is the scenario. What is the impacted feature? > > > > > > > > I think the scenario has been explained as > > > > > > > > "kvlist should be freed before return an error due to invalid quanta size" > > > > the impact has been mentioned as "resource leak" I guess this is how > > > > Coverity describe the issue > > > > > > No, it does not say how to reproduce (the scenario). > > > We have no idea where it is in the code. > > > > set an invalid quanta size from devargs will reproduce the issue > > > > > > > Refine the Title / commit log in dpdk-next-net-intel as below to answer Thomas's questions > > net/iavf: fix memory leak issue A memory leak is an issue for sure, so no need to add "issue". > Set an invalid quanta size from devargs will cause memory leak and this Set -> Setting > is reported by coverity. > > The patch fix the issue by correcting the error handle. handle -> handling Thanks