From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caraman Mihai Claudiu-B02008 Subject: RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs Date: Thu, 5 Jul 2012 12:54:07 +0000 Message-ID: <300B73AA675FCE4A93EB4FC1D42459FF15B38A@039-SN2MPN1-013.039d.mgd.msft.net> References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-4-git-send-email-mihai.caraman@freescale.com> <4E5FF9AC-1759-423F-A918-3BA0AEAE5349@suse.de> <300B73AA675FCE4A93EB4FC1D42459FF15B220@039-SN2MPN1-013.039d.mgd.msft.net> <4FF584AE.1080805@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "qemu-ppc@nongnu.org" To: Alexander Graf Return-path: Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.31]:2481 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932438Ab2GEMyP convert rfc822-to-8bit (ORCPT ); Thu, 5 Jul 2012 08:54:15 -0400 In-Reply-To: <4FF584AE.1080805@suse.de> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Alexander Graf [mailto:agraf@suse.de] > Sent: Thursday, July 05, 2012 3:13 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; qemu-ppc@nongnu.org > Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > support in sregs > > On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: > >> -----Original Message----- > >> From: Alexander Graf [mailto:agraf@suse.de] > >> Sent: Wednesday, July 04, 2012 4:34 PM > >> To: Caraman Mihai Claudiu-B02008 > >> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > >> dev@lists.ozlabs.org; qemu-ppc@nongnu.org > >> Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > >> support in sregs > >> > >> > >> On 25.06.2012, at 14:26, Mihai Caraman wrote: > >> > >>> Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs > >>> for 64-bit hosts. > >> Please also implement a ONE_REG interface while at it. Over time, I'd > >> like to move towards ONE_REG instead of the messy regs/sregs API. > > ONE_REG doesn't seem to be implemented at all for book3e, I looked at > > kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. > > > > I can take care of it soon but in a different patch set. It's ok like > this? > > Do it in a different patch, but as part of this patch set. Hmm ... then if you don't disagree I will do it as a prerequisite patch since I want to keep this patchset strictly for 64-bit support. I am not familiar with ONE_REG, is qemu tailored to use it? I need a way to test it. -Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe001.messaging.microsoft.com [216.32.180.11]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4E6262C0201 for ; Thu, 5 Jul 2012 22:54:20 +1000 (EST) From: Caraman Mihai Claudiu-B02008 To: Alexander Graf Subject: RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs Date: Thu, 5 Jul 2012 12:54:07 +0000 Message-ID: <300B73AA675FCE4A93EB4FC1D42459FF15B38A@039-SN2MPN1-013.039d.mgd.msft.net> References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-4-git-send-email-mihai.caraman@freescale.com> <4E5FF9AC-1759-423F-A918-3BA0AEAE5349@suse.de> <300B73AA675FCE4A93EB4FC1D42459FF15B220@039-SN2MPN1-013.039d.mgd.msft.net> <4FF584AE.1080805@suse.de> In-Reply-To: <4FF584AE.1080805@suse.de> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Cc: "qemu-ppc@nongnu.org" , "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -----Original Message----- > From: Alexander Graf [mailto:agraf@suse.de] > Sent: Thursday, July 05, 2012 3:13 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; qemu-ppc@nongnu.org > Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > support in sregs >=20 > On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: > >> -----Original Message----- > >> From: Alexander Graf [mailto:agraf@suse.de] > >> Sent: Wednesday, July 04, 2012 4:34 PM > >> To: Caraman Mihai Claudiu-B02008 > >> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > >> dev@lists.ozlabs.org; qemu-ppc@nongnu.org > >> Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > >> support in sregs > >> > >> > >> On 25.06.2012, at 14:26, Mihai Caraman wrote: > >> > >>> Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs > >>> for 64-bit hosts. > >> Please also implement a ONE_REG interface while at it. Over time, I'd > >> like to move towards ONE_REG instead of the messy regs/sregs API. > > ONE_REG doesn't seem to be implemented at all for book3e, I looked at > > kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. > > > > I can take care of it soon but in a different patch set. It's ok like > this? >=20 > Do it in a different patch, but as part of this patch set. Hmm ... then if you don't disagree I will do it as a prerequisite patch sin= ce I want to keep this patchset strictly for 64-bit support. I am not familiar with ONE_REG, is qemu tailored to use it? I need a way to= test it. -Mike From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caraman Mihai Claudiu-B02008 Date: Thu, 05 Jul 2012 12:54:07 +0000 Subject: RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs Message-Id: <300B73AA675FCE4A93EB4FC1D42459FF15B38A@039-SN2MPN1-013.039d.mgd.msft.net> List-Id: References: <1340627195-11544-1-git-send-email-mihai.caraman@freescale.com> <1340627195-11544-4-git-send-email-mihai.caraman@freescale.com> <4E5FF9AC-1759-423F-A918-3BA0AEAE5349@suse.de> <300B73AA675FCE4A93EB4FC1D42459FF15B220@039-SN2MPN1-013.039d.mgd.msft.net> <4FF584AE.1080805@suse.de> In-Reply-To: <4FF584AE.1080805@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "qemu-ppc@nongnu.org" > -----Original Message----- > From: Alexander Graf [mailto:agraf@suse.de] > Sent: Thursday, July 05, 2012 3:13 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; qemu-ppc@nongnu.org > Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > support in sregs > > On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: > >> -----Original Message----- > >> From: Alexander Graf [mailto:agraf@suse.de] > >> Sent: Wednesday, July 04, 2012 4:34 PM > >> To: Caraman Mihai Claudiu-B02008 > >> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > >> dev@lists.ozlabs.org; qemu-ppc@nongnu.org > >> Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > >> support in sregs > >> > >> > >> On 25.06.2012, at 14:26, Mihai Caraman wrote: > >> > >>> Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs > >>> for 64-bit hosts. > >> Please also implement a ONE_REG interface while at it. Over time, I'd > >> like to move towards ONE_REG instead of the messy regs/sregs API. > > ONE_REG doesn't seem to be implemented at all for book3e, I looked at > > kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. > > > > I can take care of it soon but in a different patch set. It's ok like > this? > > Do it in a different patch, but as part of this patch set. Hmm ... then if you don't disagree I will do it as a prerequisite patch since I want to keep this patchset strictly for 64-bit support. I am not familiar with ONE_REG, is qemu tailored to use it? I need a way to test it. -Mike