From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active Date: Thu, 11 Apr 2013 11:53:16 +0200 Message-ID: <3010836.mDNO71IiS7@linux-5eaq.site> References: <20110727141246.GC29616@orbit.nwl.cc> <2552222.23e5DWG2Z9@linux-5eaq.site> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Dan Williams , Elina Pasheva , Network Development , linux-usb , Rory Filer , Phil Sutter To: Ming Lei Return-path: Received: from smtp-out002.kontent.com ([81.88.40.216]:39889 "EHLO smtp-out002.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961Ab3DKJwb (ORCPT ); Thu, 11 Apr 2013 05:52:31 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thursday 11 April 2013 16:09:16 Ming Lei wrote: > On Thu, Apr 11, 2013 at 2:50 PM, Oliver Neukum wrote: > > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > > > >> 'mem_flags' isn't needed any more since we can apply allocation > >> of GFP_NOIO automatically in resume path now, and you can always > >> use GFP_KERNEL safely. Considered that it is a API, please don't > >> introduce it. > > > > The automatic system goes a long way, but there are corner cases, for example > > work queues, which still need mem_flags. > > Could you explain why work queue need GFP_NOIO? Your fix for the memory allocation depends on it happening in the same context. If you execute code on a work queue this happens in the context of a kernel thread. > and the use case for > usbnet? Processing your response from a work queue. Regards Oliver