From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Thu, 13 Jul 2017 14:01:50 +0000 Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Message-Id: <3012281.mcLmPQijCc@amdc3058> List-Id: References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <1734271.ijK3T0ECI9@amdc3058> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Linux Fbdev development list , DRI Development On Wednesday, July 12, 2017 05:07:42 PM Daniel Vetter wrote: > On Wed, Jul 12, 2017 at 2:54 PM, Bartlomiej Zolnierkiewicz > wrote: > > On Wednesday, July 12, 2017 02:42:14 PM Daniel Vetter wrote: > >> On Wed, Jul 12, 2017 at 12:41:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > >> > On Tuesday, July 11, 2017 04:52:19 PM Daniel Vetter wrote: > >> > > Instead check info->ops->owner, which amounts to the same. > >> > > > >> > > Spotted because I want to remove the pile of broken and cargo-culted > >> > > fb_info->flags assignments in drm drivers. > >> > > > >> > > v2: Fixup matrox (reported by kbuild). Also nuke FBINFO_FLAG_* defines > >> > > that I've failed to spot. > >> > > > >> > > v3: Don't nuke FBINFO_FLAG_DEFAULT, that's used all over the place. > >> > > > >> > > Cc: Bartlomiej Zolnierkiewicz > >> > > Cc: linux-fbdev@vger.kernel.org > >> > > Signed-off-by: Daniel Vetter > >> > > >> > Acked-by: Bartlomiej Zolnierkiewicz > >> > >> Do you plan to pick these two patches up yourself, or do you expect me to > >> merge them? > > > > Since the original patchset contained DRM changes (two last patches) > > depending on fbdev changes (two first patches, the patch being discussed > > was the second one) I assumed that you would like to take them all > > through DRM tree. If this is not what is preferred, please tell me. > > There's no direct depency between 1&2 and 3&4, the only effect of > merging them through separate trees is that the bootup logo might not > show up when it's expected, until the trees are merged together. We > could merge them through separate trees if you prefer that (I forgot > to mention that in the cover letter), but I'm fine with putting them > all into drm-misc with your ack for 4.14. > > Whatever you prefer, I don't mind either way. Then I will merge patches 1&2 for v4.14 through fbdev tree (there are some other changes pending touching fbdev core and I would like to avoid conflicts between fbdev & drm-misc trees). Thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Date: Thu, 13 Jul 2017 16:01:50 +0200 Message-ID: <3012281.mcLmPQijCc@amdc3058> References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <1734271.ijK3T0ECI9@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Linux Fbdev development list , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCBKdWx5IDEyLCAyMDE3IDA1OjA3OjQyIFBNIERhbmllbCBWZXR0ZXIgd3Jv dGU6Cj4gT24gV2VkLCBKdWwgMTIsIDIwMTcgYXQgMjo1NCBQTSwgQmFydGxvbWllaiBab2xuaWVy a2lld2ljego+IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+IHdyb3RlOgo+ID4gT24gV2VkbmVz ZGF5LCBKdWx5IDEyLCAyMDE3IDAyOjQyOjE0IFBNIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4g T24gV2VkLCBKdWwgMTIsIDIwMTcgYXQgMTI6NDE6MzRQTSArMDIwMCwgQmFydGxvbWllaiBab2xu aWVya2lld2ljeiB3cm90ZToKPiA+PiA+IE9uIFR1ZXNkYXksIEp1bHkgMTEsIDIwMTcgMDQ6NTI6 MTkgUE0gRGFuaWVsIFZldHRlciB3cm90ZToKPiA+PiA+ID4gSW5zdGVhZCBjaGVjayBpbmZvLT5v cHMtPm93bmVyLCB3aGljaCBhbW91bnRzIHRvIHRoZSBzYW1lLgo+ID4+ID4gPgo+ID4+ID4gPiBT cG90dGVkIGJlY2F1c2UgSSB3YW50IHRvIHJlbW92ZSB0aGUgcGlsZSBvZiBicm9rZW4gYW5kIGNh cmdvLWN1bHRlZAo+ID4+ID4gPiBmYl9pbmZvLT5mbGFncyBhc3NpZ25tZW50cyBpbiBkcm0gZHJp dmVycy4KPiA+PiA+ID4KPiA+PiA+ID4gdjI6IEZpeHVwIG1hdHJveCAocmVwb3J0ZWQgYnkga2J1 aWxkKS4gQWxzbyBudWtlIEZCSU5GT19GTEFHXyogZGVmaW5lcwo+ID4+ID4gPiB0aGF0IEkndmUg ZmFpbGVkIHRvIHNwb3QuCj4gPj4gPiA+Cj4gPj4gPiA+IHYzOiBEb24ndCBudWtlIEZCSU5GT19G TEFHX0RFRkFVTFQsIHRoYXQncyB1c2VkIGFsbCBvdmVyIHRoZSBwbGFjZS4KPiA+PiA+ID4KPiA+ PiA+ID4gQ2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5n LmNvbT4KPiA+PiA+ID4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+ID4+ID4gPiBT aWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+ PiA+Cj4gPj4gPiBBY2tlZC1ieTogQmFydGxvbWllaiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVy a2llQHNhbXN1bmcuY29tPgo+ID4+Cj4gPj4gRG8geW91IHBsYW4gdG8gcGljayB0aGVzZSB0d28g cGF0Y2hlcyB1cCB5b3Vyc2VsZiwgb3IgZG8geW91IGV4cGVjdCBtZSB0bwo+ID4+IG1lcmdlIHRo ZW0/Cj4gPgo+ID4gU2luY2UgdGhlIG9yaWdpbmFsIHBhdGNoc2V0IGNvbnRhaW5lZCBEUk0gY2hh bmdlcyAodHdvIGxhc3QgcGF0Y2hlcykKPiA+IGRlcGVuZGluZyBvbiBmYmRldiBjaGFuZ2VzICh0 d28gZmlyc3QgcGF0Y2hlcywgdGhlIHBhdGNoIGJlaW5nIGRpc2N1c3NlZAo+ID4gd2FzIHRoZSBz ZWNvbmQgb25lKSBJIGFzc3VtZWQgdGhhdCB5b3Ugd291bGQgbGlrZSB0byB0YWtlIHRoZW0gYWxs Cj4gPiB0aHJvdWdoIERSTSB0cmVlLiBJZiB0aGlzIGlzIG5vdCB3aGF0IGlzIHByZWZlcnJlZCwg cGxlYXNlIHRlbGwgbWUuCj4gCj4gVGhlcmUncyBubyBkaXJlY3QgZGVwZW5jeSBiZXR3ZWVuIDEm MiBhbmQgMyY0LCB0aGUgb25seSBlZmZlY3Qgb2YKPiBtZXJnaW5nIHRoZW0gdGhyb3VnaCBzZXBh cmF0ZSB0cmVlcyBpcyB0aGF0IHRoZSBib290dXAgbG9nbyBtaWdodCBub3QKPiBzaG93IHVwIHdo ZW4gaXQncyBleHBlY3RlZCwgdW50aWwgdGhlIHRyZWVzIGFyZSBtZXJnZWQgdG9nZXRoZXIuIFdl Cj4gY291bGQgbWVyZ2UgdGhlbSB0aHJvdWdoIHNlcGFyYXRlIHRyZWVzIGlmIHlvdSBwcmVmZXIg dGhhdCAoSSBmb3Jnb3QKPiB0byBtZW50aW9uIHRoYXQgaW4gdGhlIGNvdmVyIGxldHRlciksIGJ1 dCBJJ20gZmluZSB3aXRoIHB1dHRpbmcgdGhlbQo+IGFsbCBpbnRvIGRybS1taXNjIHdpdGggeW91 ciBhY2sgZm9yIDQuMTQuCj4gCj4gV2hhdGV2ZXIgeW91IHByZWZlciwgSSBkb24ndCBtaW5kIGVp dGhlciB3YXkuCgpUaGVuIEkgd2lsbCBtZXJnZSBwYXRjaGVzIDEmMiBmb3IgdjQuMTQgdGhyb3Vn aCBmYmRldiB0cmVlICh0aGVyZSBhcmUKc29tZSBvdGhlciBjaGFuZ2VzIHBlbmRpbmcgdG91Y2hp bmcgZmJkZXYgY29yZSBhbmQgSSB3b3VsZCBsaWtlIHRvIGF2b2lkCmNvbmZsaWN0cyBiZXR3ZWVu IGZiZGV2ICYgZHJtLW1pc2MgdHJlZXMpLiBUaGFua3MhCgpCZXN0IHJlZ2FyZHMsCi0tCkJhcnRs b21pZWogWm9sbmllcmtpZXdpY3oKU2Ftc3VuZyBSJkQgSW5zdGl0dXRlIFBvbGFuZApTYW1zdW5n IEVsZWN0cm9uaWNzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK