Re: [PATCH] sunrpc: Remove unused function ip_map_lookup

From: Chuck Lever III <chuck.lever@oracle.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Bruce Fields <bfields@fieldses.org>,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: Remove unused function ip_map_lookup
Date: Tue, 6 Apr 2021 15:57:46 +0000	[thread overview]
Message-ID: <3020346E-BD5C-45C6-8775-C791578FED0F@oracle.com> (raw)
In-Reply-To: <1617680819-9058-1-git-send-email-jiapeng.chong@linux.alibaba.com>

Hello-

> On Apr 5, 2021, at 11:46 PM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> 
> Fix the following clang warnings:
> 
> net/sunrpc/svcauth_unix.c:306:30: warning: unused function
> 'ip_map_lookup' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

This has been pushed to the for-next topic branch in:

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

> ---
> net/sunrpc/svcauth_unix.c | 9 ---------
> 1 file changed, 9 deletions(-)
> 
> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
> index 97c0bdd..35b7966 100644
> --- a/net/sunrpc/svcauth_unix.c
> +++ b/net/sunrpc/svcauth_unix.c
> @@ -303,15 +303,6 @@ static struct ip_map *__ip_map_lookup(struct cache_detail *cd, char *class,
> 		return NULL;
> }
> 
> -static inline struct ip_map *ip_map_lookup(struct net *net, char *class,
> -		struct in6_addr *addr)
> -{
> -	struct sunrpc_net *sn;
> -
> -	sn = net_generic(net, sunrpc_net_id);
> -	return __ip_map_lookup(sn->ip_map_cache, class, addr);
> -}
> -
> static int __ip_map_update(struct cache_detail *cd, struct ip_map *ipm,
> 		struct unix_domain *udom, time64_t expiry)
> {
> -- 
> 1.8.3.1
> 

--
Chuck Lever