From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Josue David Hernandez Gutierrez
<josue.d.hernandez.gutierrez@intel.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: host: xhci: Move msi/msi-x functions to xhci-pci
Date: Wed, 30 Mar 2022 10:36:06 +0300 [thread overview]
Message-ID: <3028aa38-bd85-1e04-e2e0-6229d6320b89@linux.intel.com> (raw)
In-Reply-To: <YkMv9wB1zXtMQgWN@kroah.com>
On 29.3.2022 19.12, Greg KH wrote:
> On Tue, Mar 29, 2022 at 09:44:06AM -0600, Josue David Hernandez Gutierrez wrote:
>> There were sync and cleanup msi/msix functions in xhci inside a #ifdef
>> macro to check if PCI module is being compiling. These functions has
>
> "have"?
>
>> been moved to xhci-pci where they belong.
>
> Again, move first, modify second.
>
In this case a small modification first makes moving the code a lot easier.
But yes, patches could be split into clearer functional and "moving" changes.
Thanks
Mathias
next prev parent reply other threads:[~2022-03-30 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:44 [PATCH 1/2] usb: host: xhci: Remove msi irq reconfigure on resume Josue David Hernandez Gutierrez
2022-03-29 15:44 ` [PATCH 2/2] usb: host: xhci: Move msi/msi-x functions to xhci-pci Josue David Hernandez Gutierrez
2022-03-29 16:12 ` Greg KH
2022-03-30 7:36 ` Mathias Nyman [this message]
2022-03-29 16:11 ` [PATCH 1/2] usb: host: xhci: Remove msi irq reconfigure on resume Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3028aa38-bd85-1e04-e2e0-6229d6320b89@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=josue.d.hernandez.gutierrez@intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.