From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755413AbcIVLRp (ORCPT ); Thu, 22 Sep 2016 07:17:45 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:53615 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbcIVLRn (ORCPT ); Thu, 22 Sep 2016 07:17:43 -0400 Subject: Re: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support To: Mugunthan V N , Vignesh R , References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-3-mugunthanvnm@ti.com> <1dbd7bbd-36ac-4433-79bf-8975a06dd07e@ti.com> <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com> CC: Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Lee Jones , "Andrew F . Davis" , , , , , Sekhar Nori From: Peter Ujfalusi Message-ID: <30294b90-af44-d8cf-d70b-92a9461f1e5f@ti.com> Date: Thu, 22 Sep 2016 14:16:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/16 13:45, Mugunthan V N wrote: >>> + if (!dma->chan) >>> + return -ENODEV; >>> + >>> + /* RX buffer */ >>> + dma->buf = dma_alloc_coherent(dma->chan->device->dev, DMA_BUFFER_SIZE, >>> + &dma->addr, GFP_KERNEL); >>> + if (!dma->buf) >>> + goto err; >>> + >>> + dev_dbg_ratelimited(adc_dev->mfd_tscadc->dev, "got dma channel\n"); >> >> Do we need _ratelimited? AFAICS, this print is called only once. > > True, will change to dev_dbg. It would be better to remove it. It gives no useful debuggin information apart from the fact that the driver did not failed to probe. -- Péter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support Date: Thu, 22 Sep 2016 14:16:42 +0300 Message-ID: <30294b90-af44-d8cf-d70b-92a9461f1e5f@ti.com> References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-3-mugunthanvnm@ti.com> <1dbd7bbd-36ac-4433-79bf-8975a06dd07e@ti.com> <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Mugunthan V N , Vignesh R , linux-iio@vger.kernel.org Cc: Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Lee Jones , "Andrew F . Davis" , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sekhar Nori List-Id: devicetree@vger.kernel.org On 09/22/16 13:45, Mugunthan V N wrote: >>> + if (!dma->chan) >>> + return -ENODEV; >>> + >>> + /* RX buffer */ >>> + dma->buf = dma_alloc_coherent(dma->chan->device->dev, DMA_BUFFER_SIZE, >>> + &dma->addr, GFP_KERNEL); >>> + if (!dma->buf) >>> + goto err; >>> + >>> + dev_dbg_ratelimited(adc_dev->mfd_tscadc->dev, "got dma channel\n"); >> >> Do we need _ratelimited? AFAICS, this print is called only once. > > True, will change to dev_dbg. It would be better to remove it. It gives no useful debuggin information apart from the fact that the driver did not failed to probe. -- Péter From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Thu, 22 Sep 2016 14:16:42 +0300 Subject: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support In-Reply-To: <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com> References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-3-mugunthanvnm@ti.com> <1dbd7bbd-36ac-4433-79bf-8975a06dd07e@ti.com> <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com> Message-ID: <30294b90-af44-d8cf-d70b-92a9461f1e5f@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/22/16 13:45, Mugunthan V N wrote: >>> + if (!dma->chan) >>> + return -ENODEV; >>> + >>> + /* RX buffer */ >>> + dma->buf = dma_alloc_coherent(dma->chan->device->dev, DMA_BUFFER_SIZE, >>> + &dma->addr, GFP_KERNEL); >>> + if (!dma->buf) >>> + goto err; >>> + >>> + dev_dbg_ratelimited(adc_dev->mfd_tscadc->dev, "got dma channel\n"); >> >> Do we need _ratelimited? AFAICS, this print is called only once. > > True, will change to dev_dbg. It would be better to remove it. It gives no useful debuggin information apart from the fact that the driver did not failed to probe. -- P?ter