From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754585AbbDMWEG (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Apr 2015 18:04:06 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:50951 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751717AbbDMWEC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Apr 2015 18:04:02 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        dingtianhong <dingtianhong@huawei.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Dan Carpenter <dan.carpenter@oracle.com>, netdev@vger.kernel.org
Subject: Re: [patch 4/5] net: hip04: Make tx coalesce timer actually work
Date: Tue, 14 Apr 2015 00:03:12 +0200
Message-ID: <3040901.Bp3bfgc1te@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <alpine.DEB.2.11.1504132338080.3845@nanos>
References: <20150413210009.682000343@linutronix.de> <9614284.QjZ4xls6zV@wuerfel> <alpine.DEB.2.11.1504132338080.3845@nanos>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:MuC7cmkugo4SwDkNyaQNvXrp4gREjtJiKAIw6+m77Z/CoS9Wlrk
 G1MHgPbSGDqDJc2r+gAms9oNhOAKcKwoLGg3/y2qD6QF23QHl90lUgtVtdWjn2RiaKzIwK2
 jom5RcANiTdh8BnnbYzbqhaqAiv3RJonKPQ4POAy1Yj0P+8QnX+m+JbgzPn0fK4sDILEt72
 +TQK6QxWSyy2o0DqBXUyQ==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 13 April 2015 23:42:03 Thomas Gleixner wrote:
> > 
> > Question: this looks to me like it sets both the minimum and maximum
> > time to priv->tx_coalesce_usecs/2, when the intention was to set
> > the minimum to priv->tx_coalesce_usecs/2 and the maximum to
> > priv->tx_coalesce_usecs. Am I missing something subtle here, or did
> > you just misread my original intention from the botched code?
> 
> Yes, I missed that. Simple fix for this is:
> 
>   unsigned long t_ns = priv->tx_coalesce_usecs * NSEC_PER_USEC / 2;
>   
>   hrtimer_start_range_ns(&priv->tx_coalesce_timer, ns_to_ktime(t_ns),
>                          t_ns, HRTIMER_MODE_REL);

Ah, good. I have to admit that I'd probably make the same mistake
again if I was to do this for another driver and you hadn't sent
the fix. The hrtimer_set_expires_range() function just looked like
it had been designed for the use case I was interested in ;-).

Any idea how to prevent the next person from making the same mistake?

	Arnd