From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
Subject: Re: [PATCH v6 2/9] null: fix segfault when null_pmd
 added to bonding
Date: Fri, 30 Oct 2015 13:50:13 +0000
Message-ID: <3042915272161B4EB253DA4D77EB373A14E0E823@IRSMSX102.ger.corp.intel.com>
References: <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com>
 <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com>
 <1444989651-6236-3-git-send-email-tomaszx.kulasek@intel.com>
 <7064813.L2uCrhhELF@xps13>
 <3042915272161B4EB253DA4D77EB373A14E0C5E1@IRSMSX102.ger.corp.intel.com>
 <5631C878.8060003@igel.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7C0F48E9A
 for <dev@dpdk.org>; Fri, 30 Oct 2015 14:50:16 +0100 (CET)
In-Reply-To: <5631C878.8060003@igel.co.jp>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Thursday, October 29, 2015 08:19
> To: Kulasek, TomaszX
> Cc: Thomas Monjalon; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd
> added to bonding
>=20
> On 2015/10/28 22:43, Kulasek, TomaszX wrote:
> >> -----Original Message-----
> >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >> Sent: Tuesday, October 27, 2015 17:59
> >> To: Kulasek, TomaszX
> >> Cc: dev@dpdk.org; Tetsuya Mukawa
> >> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when
> >> null_pmd added to bonding
> >>
> >> Hi,
> >> There is no change in v6 for this patch which was acked by Tetsuya.
> >> So why not keep the Acked-by below your Signed-off-by?
> >>
> >> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
> >> Other acks I'm missing?
> >>
> > Hi,
> >
> > Patches 4 and 5 were changed due to the Tetsuya's suggestions and
> already reviewed. There are not big changes, but I'm not sure if it
> should be reacked by Tetsuya, or I can just copy ack?
> >
> > Tomasz
>=20
> Hi Tomasz,
>=20
> Could you please check Bernard's patch series?
>  - [PATCH v5 00/28] remove pci driver from vdevs He tries to remove
> pci_drv from PMD.
>=20
> It seems your below patch will be affected by his patch.
>  - null: fix segfault when null_pmd added to bonding
>=20
> I just wonder your bonding RSS patch works without below fixing.
> drivers/net/null/rte_eth_null.c :
> +       pci_dev->driver =3D &rte_null_pmd.pci_drv;
>=20
> Anyway, Could you please check him patches?
>=20
> Thanks,
> Tetsuya

Hi Tetsuya,

I've just checked Bernard's patches and it seems that it can be safely remo=
ved from here. It's not used in RSS implementation, so have no impact on it=
.

I'm sending patchset v7 with copied your acks, as Thomas suggested, if you =
have no other objections.

Tomasz