From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v6 2/4] Documentation: dt: add bindings for ti-cpufreq Date: Fri, 10 Feb 2017 13:28 +0100 Message-ID: <3046998.7dExGlRDb3@aspire.rjw.lan> References: <20170203172929.23940-3-d-gerlach@ti.com> <20170210031349.GG14503@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170210031349.GG14503@vireshk-i7> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Viresh Kumar Cc: Nishanth Menon , "devicetree@vger.kernel.org" , Dave Gerlach , Tony Lindgren , Linux PM , "Rafael J. Wysocki" , Lukasz Majewski , Rob Herring , Linux OMAP Mailing List , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Friday, February 10, 2017 08:43:49 AM Viresh Kumar wrote: > On 09-02-17, 23:03, Rafael J. Wysocki wrote: > > In particular, Viresh, if you ACK something, please make sure that it > > doesn't conflict with your own patches. > > I hope you are talking about the patch 3/4 for which Arnd also sent a > fix. I acked it back on 18th of January and Dave has been carrying my > Ack since then. When he posted again, I didn't went into reviewing it > again as I saw my Ack being there. Well, OK, but you did know that the OPP API had changed in the meantime, so it wouldn't have hurt to double check I suppose? > Yes, he ended up using an API which just got updated after 18th of Jan > and yes both me and Dave missed that. But I feel it is difficult to > take care of scenarios like this. Perhaps he should have made sure > that he base it of pm/linux-next and nothing would have gone wrong. Yes, that would help, but then how to enforce that? Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 From: rjw@rjwysocki.net (Rafael J. Wysocki) Date: Fri, 10 Feb 2017 13:28 +0100 Subject: [PATCH v6 2/4] Documentation: dt: add bindings for ti-cpufreq In-Reply-To: <20170210031349.GG14503@vireshk-i7> References: <20170203172929.23940-3-d-gerlach@ti.com> <20170210031349.GG14503@vireshk-i7> Message-ID: <3046998.7dExGlRDb3@aspire.rjw.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday, February 10, 2017 08:43:49 AM Viresh Kumar wrote: > On 09-02-17, 23:03, Rafael J. Wysocki wrote: > > In particular, Viresh, if you ACK something, please make sure that it > > doesn't conflict with your own patches. > > I hope you are talking about the patch 3/4 for which Arnd also sent a > fix. I acked it back on 18th of January and Dave has been carrying my > Ack since then. When he posted again, I didn't went into reviewing it > again as I saw my Ack being there. Well, OK, but you did know that the OPP API had changed in the meantime, so it wouldn't have hurt to double check I suppose? > Yes, he ended up using an API which just got updated after 18th of Jan > and yes both me and Dave missed that. But I feel it is difficult to > take care of scenarios like this. Perhaps he should have made sure > that he base it of pm/linux-next and nothing would have gone wrong. Yes, that would help, but then how to enforce that? Thanks, Rafael