All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
@ 2021-01-28 14:41 Vladimir Sementsov-Ogievskiy
  2021-01-28 15:09 ` Markus Armbruster
  2021-01-28 16:22 ` Max Reitz
  0 siblings, 2 replies; 13+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-01-28 14:41 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, Vladimir Sementsov-Ogievskiy, jsnow, qemu-devel, mreitz

I'm developing Qemu backup for several years, and finally new backup
architecture, including block-copy generic engine and backup-top filter
landed upstream, great thanks to reviewers and especially to
Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that
we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into
"Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
qemu-co-shared-resource can be reused somewhere else, but I'd keep an
eye on them in context of block-jobs) and add myself as co-maintainer.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 34359a99b8..9957f39eba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2207,6 +2207,7 @@ F: scsi/*
 
 Block Jobs
 M: John Snow <jsnow@redhat.com>
+M: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: blockjob.c
@@ -2219,6 +2220,14 @@ F: block/commit.c
 F: block/stream.c
 F: block/mirror.c
 F: qapi/job.json
+F: block/block-copy.c
+F: include/block/block-copy.c
+F: block/backup-top.h
+F: block/backup-top.c
+F: include/block/aio_task.h
+F: block/aio_task.c
+F: util/qemu-co-shared-resource.c
+F: include/qemu/co-shared-resource.h
 T: git https://gitlab.com/jsnow/qemu.git jobs
 
 Block QAPI, monitor, command line
-- 
2.29.2



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-01-28 14:41 [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs Vladimir Sementsov-Ogievskiy
@ 2021-01-28 15:09 ` Markus Armbruster
  2021-01-28 15:28   ` John Snow
  2021-01-28 16:22 ` Max Reitz
  1 sibling, 1 reply; 13+ messages in thread
From: Markus Armbruster @ 2021-01-28 15:09 UTC (permalink / raw)
  To: Vladimir Sementsov-Ogievskiy; +Cc: kwolf, jsnow, qemu-devel, qemu-block, mreitz

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> I'm developing Qemu backup for several years, and finally new backup
> architecture, including block-copy generic engine and backup-top filter
> landed upstream, great thanks to reviewers and especially to
> Max Reitz!
>
> I also have plans of moving other block-jobs onto block-copy, so that
> we finally have one generic block copying path, fast and well-formed.
>
> So, now I suggest to bring all parts of backup architecture into
> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
> eye on them in context of block-jobs) and add myself as co-maintainer.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

With pleasure:
Reviewed-by: Markus Armbruster <armbru@redhat.com>



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-01-28 15:09 ` Markus Armbruster
@ 2021-01-28 15:28   ` John Snow
  2021-02-01 11:03     ` Vladimir Sementsov-Ogievskiy
  0 siblings, 1 reply; 13+ messages in thread
From: John Snow @ 2021-01-28 15:28 UTC (permalink / raw)
  To: Markus Armbruster, Vladimir Sementsov-Ogievskiy
  Cc: kwolf, qemu-devel, qemu-block, mreitz

On 1/28/21 10:09 AM, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> 
>> I'm developing Qemu backup for several years, and finally new backup
>> architecture, including block-copy generic engine and backup-top filter
>> landed upstream, great thanks to reviewers and especially to
>> Max Reitz!
>>
>> I also have plans of moving other block-jobs onto block-copy, so that
>> we finally have one generic block copying path, fast and well-formed.
>>
>> So, now I suggest to bring all parts of backup architecture into
>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
>> eye on them in context of block-jobs) and add myself as co-maintainer.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> 
> With pleasure:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 

Absolutely! Glad to see it.

Reviewed-by: John Snow <jsnow@redhat.com>



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-01-28 14:41 [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs Vladimir Sementsov-Ogievskiy
  2021-01-28 15:09 ` Markus Armbruster
@ 2021-01-28 16:22 ` Max Reitz
  1 sibling, 0 replies; 13+ messages in thread
From: Max Reitz @ 2021-01-28 16:22 UTC (permalink / raw)
  To: Vladimir Sementsov-Ogievskiy, qemu-block; +Cc: kwolf, jsnow, qemu-devel

On 28.01.21 15:41, Vladimir Sementsov-Ogievskiy wrote:
> I'm developing Qemu backup for several years, and finally new backup
> architecture, including block-copy generic engine and backup-top filter
> landed upstream, great thanks to reviewers and especially to
> Max Reitz!
> 
> I also have plans of moving other block-jobs onto block-copy, so that
> we finally have one generic block copying path, fast and well-formed.
> 
> So, now I suggest to bring all parts of backup architecture into
> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
> eye on them in context of block-jobs) and add myself as co-maintainer.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   MAINTAINERS | 9 +++++++++
>   1 file changed, 9 insertions(+)

Great! :)

Reviewed-by: Max Reitz <mreitz@redhat.com>



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-01-28 15:28   ` John Snow
@ 2021-02-01 11:03     ` Vladimir Sementsov-Ogievskiy
  2021-02-01 13:50       ` Alex Bennée
  2021-02-01 14:50       ` Kevin Wolf
  0 siblings, 2 replies; 13+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-02-01 11:03 UTC (permalink / raw)
  To: John Snow, Markus Armbruster; +Cc: kwolf, qemu-devel, qemu-block, mreitz

28.01.2021 18:28, John Snow wrote:
> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>
>>> I'm developing Qemu backup for several years, and finally new backup
>>> architecture, including block-copy generic engine and backup-top filter
>>> landed upstream, great thanks to reviewers and especially to
>>> Max Reitz!
>>>
>>> I also have plans of moving other block-jobs onto block-copy, so that
>>> we finally have one generic block copying path, fast and well-formed.
>>>
>>> So, now I suggest to bring all parts of backup architecture into
>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
>>> eye on them in context of block-jobs) and add myself as co-maintainer.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>> With pleasure:
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>
> 
> Absolutely! Glad to see it.
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 

[..]

> Great!
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>


Thanks!

Could someone pull it?

I don't have any signed PGP key for now, to send pull requests :\  Interesting, could I get one while sitting in Moscow?


-- 
Best regards,
Vladimir


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 11:03     ` Vladimir Sementsov-Ogievskiy
@ 2021-02-01 13:50       ` Alex Bennée
  2021-02-01 14:35         ` Daniel P. Berrangé
  2021-02-01 14:50       ` Kevin Wolf
  1 sibling, 1 reply; 13+ messages in thread
From: Alex Bennée @ 2021-02-01 13:50 UTC (permalink / raw)
  To: Vladimir Sementsov-Ogievskiy
  Cc: kwolf, qemu-block, qemu-devel, Markus Armbruster, mreitz, John Snow


Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> 28.01.2021 18:28, John Snow wrote:
>> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>>
>>>> I'm developing Qemu backup for several years, and finally new backup
>>>> architecture, including block-copy generic engine and backup-top filter
>>>> landed upstream, great thanks to reviewers and especially to
>>>> Max Reitz!
<snip>
>> Great!
>>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
>
> Thanks!
>
> Could someone pull it?
>
> I don't have any signed PGP key for now, to send pull requests :\
> Interesting, could I get one while sitting in Moscow?

Hmm this does point somewhat to a hole in our maintainer process that has
previously relied on semi-regular physical meet-up for key signing
purposes. It might be some time before we return to a new normal. Are
there any other maintainers in Moscow that you could safely meet for a
socially distanced key-signing?

-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 13:50       ` Alex Bennée
@ 2021-02-01 14:35         ` Daniel P. Berrangé
  0 siblings, 0 replies; 13+ messages in thread
From: Daniel P. Berrangé @ 2021-02-01 14:35 UTC (permalink / raw)
  To: Alex Bennée
  Cc: kwolf, Vladimir Sementsov-Ogievskiy, qemu-block,
	Markus Armbruster, qemu-devel, mreitz, John Snow

On Mon, Feb 01, 2021 at 01:50:26PM +0000, Alex Bennée wrote:
> 
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> 
> > 28.01.2021 18:28, John Snow wrote:
> >> On 1/28/21 10:09 AM, Markus Armbruster wrote:
> >>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> >>>
> >>>> I'm developing Qemu backup for several years, and finally new backup
> >>>> architecture, including block-copy generic engine and backup-top filter
> >>>> landed upstream, great thanks to reviewers and especially to
> >>>> Max Reitz!
> <snip>
> >> Great!
> >>
> >> Reviewed-by: Max Reitz <mreitz@redhat.com>
> >
> >
> > Thanks!
> >
> > Could someone pull it?
> >
> > I don't have any signed PGP key for now, to send pull requests :\
> > Interesting, could I get one while sitting in Moscow?
> 
> Hmm this does point somewhat to a hole in our maintainer process that has
> previously relied on semi-regular physical meet-up for key signing
> purposes. It might be some time before we return to a new normal. Are
> there any other maintainers in Moscow that you could safely meet for a
> socially distanced key-signing?

AFAIK, we've never actually set expectations for what process a key
signing must use. Merely that key should be signed by one or more
people who are already QEMU maintainers. It is more or less up to
the person signing the key what hoops they want to jump through
before adding their signature.

So while physically meeting is a traditional standard, some might
be fine to do key signing verification over a video conference
system, especially if both sides already know each other by sight
after previous physical meetings.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 11:03     ` Vladimir Sementsov-Ogievskiy
  2021-02-01 13:50       ` Alex Bennée
@ 2021-02-01 14:50       ` Kevin Wolf
  2021-02-01 16:20         ` Vladimir Sementsov-Ogievskiy
  1 sibling, 1 reply; 13+ messages in thread
From: Kevin Wolf @ 2021-02-01 14:50 UTC (permalink / raw)
  To: Vladimir Sementsov-Ogievskiy
  Cc: mreitz, John Snow, Markus Armbruster, qemu-block, qemu-devel

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 28.01.2021 18:28, John Snow wrote:
> > On 1/28/21 10:09 AM, Markus Armbruster wrote:
> > > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> > > 
> > > > I'm developing Qemu backup for several years, and finally new backup
> > > > architecture, including block-copy generic engine and backup-top filter
> > > > landed upstream, great thanks to reviewers and especially to
> > > > Max Reitz!
> > > > 
> > > > I also have plans of moving other block-jobs onto block-copy, so that
> > > > we finally have one generic block copying path, fast and well-formed.
> > > > 
> > > > So, now I suggest to bring all parts of backup architecture into
> > > > "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
> > > > qemu-co-shared-resource can be reused somewhere else, but I'd keep an
> > > > eye on them in context of block-jobs) and add myself as co-maintainer.
> > > > 
> > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > 
> > > With pleasure:
> > > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > > 
> > 
> > Absolutely! Glad to see it.
> > 
> > Reviewed-by: John Snow <jsnow@redhat.com>
> > 
> 
> [..]
> 
> > Great!
> > 
> > Reviewed-by: Max Reitz <mreitz@redhat.com>
> 
> Thanks!
> 
> Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in
the subject line), but I don't know when I'll send the next pull
request. If someone else sends one first, feel free to include it with:

Acked-by: Kevin Wolf <kwolf@redhat.com>

> I don't have any signed PGP key for now, to send pull requests :\
> Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be
added to the MAINTAINERS sections, too?

Kevin



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 14:50       ` Kevin Wolf
@ 2021-02-01 16:20         ` Vladimir Sementsov-Ogievskiy
  2021-02-01 16:58           ` Kevin Wolf
  2021-02-03  8:22           ` Vladimir Sementsov-Ogievskiy
  0 siblings, 2 replies; 13+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-02-01 16:20 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: mreitz, John Snow, Markus Armbruster, qemu-block, qemu-devel

01.02.2021 17:50, Kevin Wolf wrote:
> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> 28.01.2021 18:28, John Snow wrote:
>>> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>>>
>>>>> I'm developing Qemu backup for several years, and finally new backup
>>>>> architecture, including block-copy generic engine and backup-top filter
>>>>> landed upstream, great thanks to reviewers and especially to
>>>>> Max Reitz!
>>>>>
>>>>> I also have plans of moving other block-jobs onto block-copy, so that
>>>>> we finally have one generic block copying path, fast and well-formed.
>>>>>
>>>>> So, now I suggest to bring all parts of backup architecture into
>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
>>>>> eye on them in context of block-jobs) and add myself as co-maintainer.
>>>>>
>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>
>>>> With pleasure:
>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>>
>>>
>>> Absolutely! Glad to see it.
>>>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>>
>>
>> [..]
>>
>>> Great!
>>>
>>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>
>> Thanks!
>>
>> Could someone pull it?
> 
> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in
> the subject line), but I don't know when I'll send the next pull
> request. If someone else sends one first, feel free to include it with:
> 
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> 
>> I don't have any signed PGP key for now, to send pull requests :\
>> Interesting, could I get one while sitting in Moscow?
> 
> If you're planning to send pull requests, should a git tree of yours be
> added to the MAINTAINERS sections, too?
> 

I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.

I think it's appropriate to add

T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs


-- 
Best regards,
Vladimir


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 16:20         ` Vladimir Sementsov-Ogievskiy
@ 2021-02-01 16:58           ` Kevin Wolf
  2021-02-01 17:08             ` Vladimir Sementsov-Ogievskiy
  2021-02-03  8:22           ` Vladimir Sementsov-Ogievskiy
  1 sibling, 1 reply; 13+ messages in thread
From: Kevin Wolf @ 2021-02-01 16:58 UTC (permalink / raw)
  To: Vladimir Sementsov-Ogievskiy
  Cc: mreitz, John Snow, Markus Armbruster, qemu-block, qemu-devel

Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 01.02.2021 17:50, Kevin Wolf wrote:
> > Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 28.01.2021 18:28, John Snow wrote:
> > > > On 1/28/21 10:09 AM, Markus Armbruster wrote:
> > > > > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> > > > > 
> > > > > > I'm developing Qemu backup for several years, and finally new backup
> > > > > > architecture, including block-copy generic engine and backup-top filter
> > > > > > landed upstream, great thanks to reviewers and especially to
> > > > > > Max Reitz!
> > > > > > 
> > > > > > I also have plans of moving other block-jobs onto block-copy, so that
> > > > > > we finally have one generic block copying path, fast and well-formed.
> > > > > > 
> > > > > > So, now I suggest to bring all parts of backup architecture into
> > > > > > "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
> > > > > > qemu-co-shared-resource can be reused somewhere else, but I'd keep an
> > > > > > eye on them in context of block-jobs) and add myself as co-maintainer.
> > > > > > 
> > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > > > 
> > > > > With pleasure:
> > > > > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > > > > 
> > > > 
> > > > Absolutely! Glad to see it.
> > > > 
> > > > Reviewed-by: John Snow <jsnow@redhat.com>
> > > > 
> > > 
> > > [..]
> > > 
> > > > Great!
> > > > 
> > > > Reviewed-by: Max Reitz <mreitz@redhat.com>
> > > 
> > > Thanks!
> > > 
> > > Could someone pull it?
> > 
> > I've put it in my block branch (with s/suggest myself/Add Vladimir/ in
> > the subject line), but I don't know when I'll send the next pull
> > request. If someone else sends one first, feel free to include it with:
> > 
> > Acked-by: Kevin Wolf <kwolf@redhat.com>
> > 
> > > I don't have any signed PGP key for now, to send pull requests :\
> > > Interesting, could I get one while sitting in Moscow?
> > 
> > If you're planning to send pull requests, should a git tree of yours be
> > added to the MAINTAINERS sections, too?
> > 
> 
> I didn't add it because of signed key absence. As it turned out, Denis
> Lunev (my boss) already has a signed key, so it's not a problem.
> 
> I think it's appropriate to add
> 
> T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs

I've added it to the patch in my queue. Now you just need to actually
create that branch. :-)

Kevin



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 16:58           ` Kevin Wolf
@ 2021-02-01 17:08             ` Vladimir Sementsov-Ogievskiy
  0 siblings, 0 replies; 13+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-02-01 17:08 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: mreitz, John Snow, Markus Armbruster, qemu-block, qemu-devel

01.02.2021 19:58, Kevin Wolf wrote:
> Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> 01.02.2021 17:50, Kevin Wolf wrote:
>>> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>> 28.01.2021 18:28, John Snow wrote:
>>>>> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>>>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>>>>>
>>>>>>> I'm developing Qemu backup for several years, and finally new backup
>>>>>>> architecture, including block-copy generic engine and backup-top filter
>>>>>>> landed upstream, great thanks to reviewers and especially to
>>>>>>> Max Reitz!
>>>>>>>
>>>>>>> I also have plans of moving other block-jobs onto block-copy, so that
>>>>>>> we finally have one generic block copying path, fast and well-formed.
>>>>>>>
>>>>>>> So, now I suggest to bring all parts of backup architecture into
>>>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
>>>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
>>>>>>> eye on them in context of block-jobs) and add myself as co-maintainer.
>>>>>>>
>>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>>>
>>>>>> With pleasure:
>>>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>>>>
>>>>>
>>>>> Absolutely! Glad to see it.
>>>>>
>>>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>>>>
>>>>
>>>> [..]
>>>>
>>>>> Great!
>>>>>
>>>>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>>>
>>>> Thanks!
>>>>
>>>> Could someone pull it?
>>>
>>> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in
>>> the subject line), but I don't know when I'll send the next pull
>>> request. If someone else sends one first, feel free to include it with:
>>>
>>> Acked-by: Kevin Wolf <kwolf@redhat.com>
>>>
>>>> I don't have any signed PGP key for now, to send pull requests :\
>>>> Interesting, could I get one while sitting in Moscow?
>>>
>>> If you're planning to send pull requests, should a git tree of yours be
>>> added to the MAINTAINERS sections, too?
>>>
>>
>> I didn't add it because of signed key absence. As it turned out, Denis
>> Lunev (my boss) already has a signed key, so it's not a problem.
>>
>> I think it's appropriate to add
>>
>> T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs
> 
> I've added it to the patch in my queue. Now you just need to actually
> create that branch. :-)
> 

done :)


-- 
Best regards,
Vladimir


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-01 16:20         ` Vladimir Sementsov-Ogievskiy
  2021-02-01 16:58           ` Kevin Wolf
@ 2021-02-03  8:22           ` Vladimir Sementsov-Ogievskiy
  2021-02-03 15:57             ` John Snow
  1 sibling, 1 reply; 13+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-02-03  8:22 UTC (permalink / raw)
  To: Kevin Wolf
  Cc: qemu-block, qemu-devel, John Snow, Markus Armbruster, mreitz,
	Stefan Hajnoczi, Denis V. Lunev

01.02.2021 19:20, Vladimir Sementsov-Ogievskiy wrote:
> 01.02.2021 17:50, Kevin Wolf wrote:
>> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>> 28.01.2021 18:28, John Snow wrote:
>>>> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>>>>
>>>>>> I'm developing Qemu backup for several years, and finally new backup
>>>>>> architecture, including block-copy generic engine and backup-top filter
>>>>>> landed upstream, great thanks to reviewers and especially to
>>>>>> Max Reitz!
>>>>>>
>>>>>> I also have plans of moving other block-jobs onto block-copy, so that
>>>>>> we finally have one generic block copying path, fast and well-formed.
>>>>>>
>>>>>> So, now I suggest to bring all parts of backup architecture into
>>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
>>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd keep an
>>>>>> eye on them in context of block-jobs) and add myself as co-maintainer.
>>>>>>
>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>>
>>>>> With pleasure:
>>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>>>
>>>>
>>>> Absolutely! Glad to see it.
>>>>
>>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>>>
>>>
>>> [..]
>>>
>>>> Great!
>>>>
>>>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>>
>>> Thanks!
>>>
>>> Could someone pull it?
>>
>> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in
>> the subject line), but I don't know when I'll send the next pull
>> request. If someone else sends one first, feel free to include it with:
>>
>> Acked-by: Kevin Wolf <kwolf@redhat.com>
>>
>>> I don't have any signed PGP key for now, to send pull requests :\
>>> Interesting, could I get one while sitting in Moscow?
>>
>> If you're planning to send pull requests, should a git tree of yours be
>> added to the MAINTAINERS sections, too?
>>
> 
> I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.
> 

Unfortunately, Den doesn't have an access to his private key, so this variant doesn't work. So, probably someone could recognize me in a video call?

My key is here: http://keys.gnupg.net/pks/lookup?search=Vladimir+Sementsov-Ogievskiy&fingerprint=on&op=index  (note that there is only one Vladimir Sementsov-Ogievskiy, so I can't imagine who can that be other than me :)

-- 
Best regards,
Vladimir


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs
  2021-02-03  8:22           ` Vladimir Sementsov-Ogievskiy
@ 2021-02-03 15:57             ` John Snow
  0 siblings, 0 replies; 13+ messages in thread
From: John Snow @ 2021-02-03 15:57 UTC (permalink / raw)
  To: Vladimir Sementsov-Ogievskiy, Kevin Wolf, Peter Maydell
  Cc: qemu-block, qemu-devel, Markus Armbruster, mreitz,
	Stefan Hajnoczi, Denis V. Lunev

On 2/3/21 3:22 AM, Vladimir Sementsov-Ogievskiy wrote:
> 01.02.2021 19:20, Vladimir Sementsov-Ogievskiy wrote:
>> 01.02.2021 17:50, Kevin Wolf wrote:
>>> Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>> 28.01.2021 18:28, John Snow wrote:
>>>>> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>>>>>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>>>>>
>>>>>>> I'm developing Qemu backup for several years, and finally new backup
>>>>>>> architecture, including block-copy generic engine and backup-top 
>>>>>>> filter
>>>>>>> landed upstream, great thanks to reviewers and especially to
>>>>>>> Max Reitz!
>>>>>>>
>>>>>>> I also have plans of moving other block-jobs onto block-copy, so 
>>>>>>> that
>>>>>>> we finally have one generic block copying path, fast and 
>>>>>>> well-formed.
>>>>>>>
>>>>>>> So, now I suggest to bring all parts of backup architecture into
>>>>>>> "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
>>>>>>> qemu-co-shared-resource can be reused somewhere else, but I'd 
>>>>>>> keep an
>>>>>>> eye on them in context of block-jobs) and add myself as 
>>>>>>> co-maintainer.
>>>>>>>
>>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy 
>>>>>>> <vsementsov@virtuozzo.com>
>>>>>>
>>>>>> With pleasure:
>>>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>>>>
>>>>>
>>>>> Absolutely! Glad to see it.
>>>>>
>>>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>>>>
>>>>
>>>> [..]
>>>>
>>>>> Great!
>>>>>
>>>>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>>>
>>>> Thanks!
>>>>
>>>> Could someone pull it?
>>>
>>> I've put it in my block branch (with s/suggest myself/Add Vladimir/ in
>>> the subject line), but I don't know when I'll send the next pull
>>> request. If someone else sends one first, feel free to include it with:
>>>
>>> Acked-by: Kevin Wolf <kwolf@redhat.com>
>>>
>>>> I don't have any signed PGP key for now, to send pull requests :\
>>>> Interesting, could I get one while sitting in Moscow?
>>>
>>> If you're planning to send pull requests, should a git tree of yours be
>>> added to the MAINTAINERS sections, too?
>>>
>>
>> I didn't add it because of signed key absence. As it turned out, Denis 
>> Lunev (my boss) already has a signed key, so it's not a problem.
>>
> 
> Unfortunately, Den doesn't have an access to his private key, so this 
> variant doesn't work. So, probably someone could recognize me in a video 
> call?
> 
> My key is here: 
> http://keys.gnupg.net/pks/lookup?search=Vladimir+Sementsov-Ogievskiy&fingerprint=on&op=index  
> (note that there is only one Vladimir Sementsov-Ogievskiy, so I can't 
> imagine who can that be other than me :)
> 

I'm not sure what protocol here is, but you and I and several others met 
face to face in edinburgh and could at least weakly identify you. Maybe 
we can sign with a low level of trust for now, and improve it when we 
get a chance to do a real key signing meetup later?

I think Peter needs to trust your key, ultimately, so I think it's up to 
him for what criteria he will personally trust.

--js



^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-02-03 15:58 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 14:41 [PATCH] MAINTAINERS: suggest myself as co-maintainer for Block Jobs Vladimir Sementsov-Ogievskiy
2021-01-28 15:09 ` Markus Armbruster
2021-01-28 15:28   ` John Snow
2021-02-01 11:03     ` Vladimir Sementsov-Ogievskiy
2021-02-01 13:50       ` Alex Bennée
2021-02-01 14:35         ` Daniel P. Berrangé
2021-02-01 14:50       ` Kevin Wolf
2021-02-01 16:20         ` Vladimir Sementsov-Ogievskiy
2021-02-01 16:58           ` Kevin Wolf
2021-02-01 17:08             ` Vladimir Sementsov-Ogievskiy
2021-02-03  8:22           ` Vladimir Sementsov-Ogievskiy
2021-02-03 15:57             ` John Snow
2021-01-28 16:22 ` Max Reitz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.