From: Bean Huo <huobean@gmail.com>
To: Avri Altman <avri.altman@wdc.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
alim.akhtar@samsung.com, asutoshd@codeaurora.org,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <avi.shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
cang@codeaurora.org, stanley.chu@mediatek.com
Subject: Re: [PATCH v2 0/9] Add Host control mode to HPB
Date: Fri, 05 Feb 2021 12:43:23 +0100 [thread overview]
Message-ID: <304cb44c67dc1d5fe081ea4450823c1c3b456284.camel@gmail.com> (raw)
In-Reply-To: <ec32248a3e56eef83744cd4844210d347add27d3.camel@gmail.com>
On Fri, 2021-02-05 at 12:36 +0100, Bean Huo wrote:
> > to whatever recommendation received from the device - In host
> > control
> > mode, the host uses its own algorithms to decide which regions
> > should
> > be activated or inactivated.
> >
> > We kept the host managed heuristic simple and concise.
> >
> > Aside from adding a by-spec functionality, host control mode
> > entails
> > some further potential benefits: makes the hpb logic transparent
> > and
> > readable, while allow tuning / scaling its various parameters, and
> > utilize system-wide info to optimize HPB potential.
>
> Hi Avri
> In addition to the above advantage of HPB device mode, would you
> please
> share the performance comparison data with host mode? that will draw
> more attention, since you mentioned "you tested on Galaxy S20, and
> Xiaomi Mi10 pro", I think you have this kind of data.
>
> Your HPB host driver sits in the ufs driver. Since my HPB host mode
> driver is also implemented in the UFS driver layer, I did test my HPB
> driver between device mode and host mode. Saw there is an
> improvement,
> but not significant. If you can share your HPB drviver data, that
> will
> be awesome.
>
> Kind regards,
> Bean
So sorry, there are several typos, easily confused you. correct them as
below:
Hi Avri
In addition to the above advantage of HPB "host control mode", would
you please share the performance comparison data with "device control
mode"? that will draw more attention, since you mentioned "you tested
on Galaxy S20, and Xiaomi Mi10 pro", I think you have this kind of
data.
Your HPB "host control mode" driver sits in the ufs driver. Since my
HPB "host control mode" driver is also implemented in the UFS driver
layer, I did test my HPB driver between device mode and host mode. Saw
UFS HPB "host control mode" driver has performance gain comparing to
HPB "device control mode" driver, but not significant. If you can share
your HPB host control mode drviver data, that will be awesome.
Kind regards,
Bean
next prev parent reply other threads:[~2021-02-05 11:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 8:29 [PATCH v2 0/9] Add Host control mode to HPB Avri Altman
2021-02-02 8:29 ` [PATCH v2 1/9] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-02-02 8:30 ` [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-02-02 11:13 ` Greg KH
2021-02-02 11:24 ` Avri Altman
2021-02-02 11:51 ` Greg KH
2021-02-02 11:54 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter Avri Altman
2021-02-02 11:15 ` Greg KH
2021-02-02 11:23 ` Avri Altman
2021-02-02 11:51 ` Greg KH
2021-02-02 11:16 ` Greg KH
2021-02-02 11:22 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 4/9] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-02-02 8:30 ` [PATCH v2 5/9] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-02-02 8:30 ` [PATCH v2 6/9] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-02-08 6:34 ` Can Guo
2021-02-08 7:50 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 7/9] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-02-02 8:30 ` [PATCH v2 8/9] scsi: ufshpb: Add support for host control mode Avri Altman
2021-02-02 8:30 ` [PATCH v2 9/9] scsi: ufshpb: Make host mode parameters configurable Avri Altman
2021-02-02 11:17 ` Greg KH
2021-02-02 11:21 ` Avri Altman
[not found] ` <CGME20210202112157epcas2p3b04677e1380e0fa2c3f38217dfcba8bf@epcms2p8>
2021-02-04 0:48 ` Daejun Park
2021-02-02 11:18 ` Greg KH
2021-02-02 11:20 ` Avri Altman
2021-02-05 11:36 ` [PATCH v2 0/9] Add Host control mode to HPB Bean Huo
2021-02-05 11:43 ` Bean Huo [this message]
2021-02-07 14:07 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304cb44c67dc1d5fe081ea4450823c1c3b456284.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avi.shchislowski@wdc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.