All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	patches@linaro.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH V3 0/2] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc
Date: Wed, 14 Aug 2013 13:30 +0200	[thread overview]
Message-ID: <3054059.xbBShFpfCt@amdc1227> (raw)
In-Reply-To: <1376478181-27539-1-git-send-email-vikas.sajjan@linaro.org>

Hi Vikas,

On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote:
> changes since v2:
> 	- split the 5250 related modifications into a separate patch.

I'm not sure whether Kukjin's comment was about this, as it introduces a 
short bisect breakage between patch 1 and patch 2 from this series.

IMHO it would be more sensible to make first patch simply fix name of the 
node and then a separate patch adding the rtc node for exynos5420.

Best regards,
Tomasz

> 	- placed the RTC node as per the alphabetical order in the DTS file as
> 	suggested by Kukjin Kim <kgene@kernel.org>.
> 
> changes since v1:
> 	- made DT node status as "okay" in the dtsi file itself.
> -
> Vikas Sajjan (2):
>   ARM: dts: Add RTC DT node to Exynos5420 SoC
>   ARM: dts: Fix the RTC DT node name for Exynos5250 SoC
> 
>  arch/arm/boot/dts/exynos5.dtsi    |    2 +-
>  arch/arm/boot/dts/exynos5250.dtsi |    3 ++-
>  arch/arm/boot/dts/exynos5420.dtsi |    6 ++++++
>  3 files changed, 9 insertions(+), 2 deletions(-)

  parent reply	other threads:[~2013-08-14 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 11:02 [PATCH V3 0/2] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc Vikas Sajjan
2013-08-14 11:03 ` [PATCH V3 1/2] ARM: dts: Add RTC DT node to Exynos5420 SoC Vikas Sajjan
2013-08-14 11:03 ` [PATCH V3 2/2] ARM: dts: Fix the RTC DT node name for Exynos5250 SoC Vikas Sajjan
2013-08-14 11:30 ` Tomasz Figa [this message]
2013-08-14 12:07   ` [PATCH V3 0/2] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc Vikas Sajjan
2013-08-14 12:27     ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3054059.xbBShFpfCt@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=vikas.sajjan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.