All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings
Date: Fri, 26 Oct 2018 14:48:20 +0200	[thread overview]
Message-ID: <305a3492-4b16-84b2-2757-1c8e1cf481da@redhat.com> (raw)
In-Reply-To: <20181025144107.GB2697@umbus.hotspot.internet-for-guests.com>


> 
> It's not obvious to me why this looks so different from the code in
> parse_type_int64().  Should we be using qemu_strtoi64() in the
> pre-existing function, instead of what's there now?

The existing function has to be that complicated because it calls into
the same function used to parse ranges. We don't need ranges (or
create/modify) any, so this is not necessary.

This function is similar to the other parse functions (not parsing
ranges), e.g. parse_type_bool(). Thanks!

> 
>>  
>>  static void parse_type_size(Visitor *v, const char *name, uint64_t *obj,
> 


-- 

Thanks,

David / dhildenb

  reply	other threads:[~2018-10-26 12:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 15:22 [Qemu-devel] [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups David Hildenbrand
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str David Hildenbrand
2018-10-25 14:37   ` David Gibson
2018-10-31 14:40   ` Markus Armbruster
2018-10-31 16:47     ` David Hildenbrand
2018-10-31 17:55       ` Markus Armbruster
2018-10-31 18:01         ` David Hildenbrand
2018-11-05 15:37           ` Markus Armbruster
2018-11-05 15:53             ` David Hildenbrand
2018-11-05 16:48               ` Eric Blake
2018-11-06  9:20                 ` David Hildenbrand
2018-11-05 20:43               ` Markus Armbruster
2018-11-06  9:19                 ` David Hildenbrand
2018-11-07 15:29                   ` Markus Armbruster
2018-11-07 20:02                     ` David Hildenbrand
2018-11-08  8:39                       ` Markus Armbruster
2018-11-08  8:54                         ` David Hildenbrand
2018-11-08  9:13                           ` Markus Armbruster
2018-11-08 13:05                             ` David Hildenbrand
2018-11-08 14:36                               ` Markus Armbruster
2018-11-08 14:46                                 ` David Hildenbrand
2018-11-08 14:42                               ` Eric Blake
2018-11-08 14:49                                 ` David Hildenbrand
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings David Hildenbrand
2018-10-25 14:41   ` David Gibson
2018-10-26 12:48     ` David Hildenbrand [this message]
2018-10-31 14:32   ` Markus Armbruster
2018-10-31 14:44     ` Markus Armbruster
2018-10-31 17:19       ` David Hildenbrand
2018-10-31 17:18     ` David Hildenbrand
2018-11-04  3:27       ` David Gibson
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 3/7] range: pass const pointer where possible David Hildenbrand
2018-10-25 14:41   ` David Gibson
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 4/7] range: add some more functions David Hildenbrand
2018-11-01 10:00   ` Igor Mammedov
2018-11-01 10:29     ` David Hildenbrand
2018-11-01 11:05       ` Igor Mammedov
2018-11-05 10:30         ` David Hildenbrand
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 5/7] memory-device: use QEMU_IS_ALIGNED David Hildenbrand
2018-10-25 14:44   ` David Gibson
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 6/7] memory-device: avoid overflows on very huge devices David Hildenbrand
2018-10-25 14:44   ` David Gibson
2018-10-25 14:45   ` Igor Mammedov
2018-10-23 15:23 ` [Qemu-devel] [PATCH v3 7/7] memory-device: rewrite address assignment using ranges David Hildenbrand
2018-11-12 14:07   ` David Hildenbrand
2018-11-13 12:26   ` Igor Mammedov
2018-11-13 12:41     ` David Hildenbrand
2018-11-13 13:01   ` [Qemu-devel] [PATCH v4] " David Hildenbrand
2018-10-31 10:14 ` [Qemu-devel] [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups David Hildenbrand
2018-10-31 19:43   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=305a3492-4b16-84b2-2757-1c8e1cf481da@redhat.com \
    --to=david@redhat.com \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.