From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library
Date: Tue, 08 May 2018 16:42:53 +0200
Message-ID: <3063017.5QX4IrYKZL@xps>
References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com>
 <1525789143-138168-1-git-send-email-rosen.xu@intel.com>
 <1525789143-138168-2-git-send-email-rosen.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, declan.doherty@intel.com, bruce.richardson@intel.com,
 shreyansh.jain@nxp.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
 tianfei.zhang@intel.com, song.liu@intel.com, hao.wu@intel.com,
 gaetan.rivet@6wind.com
To: "Xu, Rosen" <rosen.xu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 72A8EAABF
 for <dev@dpdk.org>; Tue,  8 May 2018 16:42:59 +0200 (CEST)
In-Reply-To: <1525789143-138168-2-git-send-email-rosen.xu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

08/05/2018 16:19, Xu, Rosen:
> --- /dev/null
> +++ b/drivers/bus/ifpga/rte_bus_ifpga_version.map
> +	ifpga_get_integer32_arg;
> +	ifpga_get_string_arg;
> +	rte_ifpga_driver_register;
> +	rte_ifpga_driver_unregister;

All exported symbols must start with rte_


> --- a/drivers/bus/meson.build
> +++ b/drivers/bus/meson.build
> -drivers = ['dpaa', 'fslmc', 'pci', 'vdev']
> +drivers = ['dpaa', 'fslmc', 'pci', 'vdev', 'ifpga']

Would be better sorted in alphabetical order (between fslmc and pci).
Same comment in files config/common_base and drivers/bus/Makefile.