From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id B1EBC76775 for ; Fri, 7 Aug 2015 09:51:15 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 07 Aug 2015 02:51:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,629,1432623600"; d="scan'208";a="621079591" Received: from jsmcbrid-mobl2.ger.corp.intel.com (HELO peggleto-mobl.ger.corp.intel.com) ([10.252.24.154]) by orsmga003.jf.intel.com with ESMTP; 07 Aug 2015 02:51:15 -0700 From: Paul Eggleton To: Khem Raj Date: Fri, 07 Aug 2015 10:51:14 +0100 Message-ID: <3064000.UnunBGI2RM@peggleto-mobl.ger.corp.intel.com> Organization: Intel Corporation User-Agent: KMail/4.14.9 (Linux/4.0.8-200.fc21.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: References: <1438851969-4340-1-git-send-email-amarnath.valluri@intel.com> <13325469.N9zhAzKaIU@peggleto-mobl.ger.corp.intel.com> MIME-Version: 1.0 Cc: Patches and discussions about the oe-core layer Subject: Re: [meta-oe][PATCH] dosfstools-2.11: Fix memory leak in mkdosfs X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2015 09:51:21 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday 06 August 2015 19:52:28 Khem Raj wrote: > On Thu, Aug 6, 2015 at 2:25 AM, Paul Eggleton > > wrote: > > On Thursday 06 August 2015 12:12:35 Alexander Kanavin wrote: > >> On 08/06/2015 12:06 PM, Amarnath Valluri wrote: > >> > Added new patch that fixes the memory leak that was introduced in > >> > mkdosfs-dir.patch. > >> > >> You should update the original patch then, not pile additional patches > >> on top. The least painful way is: > >> > >> 1) unpack the sources (manually from tarball, or using bitbake -c unpack) > >> 2) 'git init; git add *; git commit' to create an git repository from > >> the sources > >> 3) apply the patch that needs fixing, then do the fix > >> 4) make a git commit, then produce a patch using git format-patch, then > >> move the new patch back to the recipe directory and update the recipe > >> 5) build the recipe to make sure it still builds > >> 6) make a git commit with the recipe update, and submit it here :) > > > > On the contrary - the much less painful way (as of fido) is to use > > devtool: > > > > 1) Extract source and set the build system up to use it: > > devtool modify dosfstools -x ~/projects/dosfstools > > > > 2) Make whatever changes you want to in the git tree that has been set up > > in the specified path > > > > 3) Build the recipe (as you would normally) to make sure it still builds > > > > 4) Write the modified/added commits as patches back to the recipe: > > devtool update-recipe dosfstools > > > > 5) Make a git commit with the recipe update, and submit it here :) > > > > I'd really like people to start using devtool for this kind of thing. If > > it's not working for some reason please do let me know. > > This assumes either we use OE-Core or poky, I dont get it to work with > angstrom out of box > what am I missing Well, whatever error / problem you are experiencing seems to be missing at least ;) Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre