From: Joe Perches <joe@perches.com>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>, apw@canonical.com
Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] checkpatch: get default codespell dictionary path from package location
Date: Tue, 12 Oct 2021 06:57:28 -0700 [thread overview]
Message-ID: <307188c4a27dc488437e74d5f8980dfcad65ecbd.camel@perches.com> (raw)
In-Reply-To: <20211012112918.19166-1-peter.ujfalusi@linux.intel.com>
On Tue, 2021-10-12 at 14:29 +0300, Peter Ujfalusi wrote:
> The standard location of dictionary.txt is under codespell's package, on
> my machine atm (codespell 2.1, Artix Linux):
> /usr/lib/python3.9/site-packages/codespell_lib/data/dictionary.txt
>
> Since we enable the codespell by default for SOF I have constant:
> No codespell typos will be found - \
> file '/usr/share/codespell/dictionary.txt': No such file or directory
>
> The patch proposes to try to fix up the path following the recommendation
> found here:
> https://github.com/codespell-project/codespell/issues/1540
trivia:
> @@ -325,9 +326,31 @@ GetOptions(
> 'kconfig-prefix=s' => \${CONFIG_},
> 'h|help' => \$help,
> 'version' => \$help
> -) or help(1);
> +) or $help = 2;
> +
> +my $python_codespell_dict = << "EOF";
Because you add a semicolon after "EOF"
> +import os.path as op
> +import codespell_lib
> +codespell_dir = op.dirname(codespell_lib.__file__)
> +codespell_file = op.join(codespell_dir, 'data', 'dictionary.txt')
> +print(codespell_file, end='')
> +EOF
> +;
this is an extra semicolon
> +if ($user_codespellfile) {
> + # Use the user provided codespell file unconditionally
> + $codespellfile = $user_codespellfile;
> +} else {
> + # Try to find the codespell install location to use it as default path
> + if (($codespell || $help) && which("codespell") ne "" && which("python") ne "") {
and I would keep the my $python_codespell_dict definition local to this block.
> + my $codespell_dict = `python3 -c "$python_codespell_dict" 2> /dev/null`;
> + $codespellfile = $codespell_dict if (-e $codespell_dict);
> + }
> +}
It's wrong to check which("python") and then exec `python3 ...`
next prev parent reply other threads:[~2021-10-12 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:29 [PATCH v5] checkpatch: get default codespell dictionary path from package location Peter Ujfalusi
2021-10-12 13:57 ` Joe Perches [this message]
2021-10-12 17:57 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307188c4a27dc488437e74d5f8980dfcad65ecbd.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.