From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: change init macro as exec environment
	specific
Date: Wed, 11 Oct 2017 15:02:51 +0200
Message-ID: <30782747.pV0nTTKWH9@xps>
References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EA7E2378B
 for <dev@dpdk.org>; Wed, 11 Oct 2017 15:02:52 +0200 (CEST)
In-Reply-To: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/08/2017 14:04, Jerin Jacob:
> baremetal execution environments may have a different
> method to enable RTE_INIT instead of using compiler
> constructor scheme. Move RTE_INIT* definition under
> exec-env to support different execution environments.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  app/test-eventdev/evt_test.h                       |  2 +-
>  lib/librte_eal/bsdapp/eal/Makefile                 |  2 +-
>  .../bsdapp/eal/include/exec-env/rte_eal.h          | 51 ++++++++++++++++++++++
>  lib/librte_eal/common/eal_common_log.c             |  2 +
>  lib/librte_eal/common/include/rte_bus.h            |  2 +
>  lib/librte_eal/common/include/rte_eal.h            |  6 ---
>  lib/librte_eal/common/include/rte_tailq.h          |  2 +
>  lib/librte_eal/linuxapp/eal/Makefile               |  2 +-
>  .../linuxapp/eal/include/exec-env/rte_eal.h        | 51 ++++++++++++++++++++++
>  9 files changed, 111 insertions(+), 9 deletions(-)
>  create mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_eal.h
>  create mode 100644 lib/librte_eal/linuxapp/eal/include/exec-env/rte_eal.h

I am not a big fan of duplicating code for Linux and BSD.

Maybe we should have different splits and include a common file
in Linux and BSD?

I feel it would be easier to think about the split when adding
a new environment.
It is also an open question whether we want to support (again) some
bare metal environments.