[PATCH 1/2] drm/amd/display: remove set but unused variable

[PATCH 1/2] drm/amd/display: remove set but unused variable

[Alex Deucher]

Fixes the following:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hwseq.c:428:33: warning: variable 'old_pipe' set but not used

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
index baaeaaff23df..3f42df525c0a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
@@ -425,11 +425,10 @@ void dcn32_subvp_pipe_control_lock(struct dc *dc,
 	bool subvp_immediate_flip = false;
 	bool subvp_in_use = false;
 	bool drr_pipe = false;
-	struct pipe_ctx *pipe, *old_pipe;
+	struct pipe_ctx *pipe;
 
 	for (i = 0; i < dc->res_pool->pipe_count; i++) {
 		pipe = &context->res_ctx.pipe_ctx[i];
-		old_pipe = &dc->current_state->res_ctx.pipe_ctx[i];
 
 		if (pipe->stream && pipe->plane_state && pipe->stream->mall_stream_config.type == SUBVP_MAIN) {
 			subvp_in_use = true;
-- 
2.35.3

[PATCH 2/2] drm/amd/display: make get_refresh_rate() static

[Alex Deucher]

It's not used outside of dcn30_resource.c.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
index 4f684235a413..7f01463942fb 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
@@ -1899,7 +1899,7 @@ noinline bool dcn30_internal_validate_bw(
 	return out;
 }
 
-int get_refresh_rate(struct dc_state *context)
+static int get_refresh_rate(struct dc_state *context)
 {
 	int refresh_rate = 0;
 	int h_v_total = 0;
-- 
2.35.3

Re: [PATCH 2/2] drm/amd/display: make get_refresh_rate() static

[Harry Wentland]

On 2022-07-06 10:08, Alex Deucher wrote:
> It's not used outside of dcn30_resource.c.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---

Both patches are
Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

>  drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> index 4f684235a413..7f01463942fb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> @@ -1899,7 +1899,7 @@ noinline bool dcn30_internal_validate_bw(
>  	return out;
>  }
>  
> -int get_refresh_rate(struct dc_state *context)
> +static int get_refresh_rate(struct dc_state *context)
>  {
>  	int refresh_rate = 0;
>  	int h_v_total = 0;