All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: Gleb Natapov <gleb@redhat.com>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: [PATCH 1/3] tile: clean up relocate_kernel_64 debug code
Date: Tue, 3 Sep 2013 14:13:31 -0400	[thread overview]
Message-ID: <309272f99f3e65b9bb5c49a2901c63a1859172f3.1378235372.git.cmetcalf@tilera.com> (raw)
In-Reply-To: <20130903173931.GO10142@redhat.com>

We remove some debug code in relocate_kernel_64.S that made raw
calls to the hv_console_putc Tilera hypervisor API, since everything
should funnel through the early_hv_write() API.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
 arch/tile/kernel/relocate_kernel_64.S | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/tile/kernel/relocate_kernel_64.S b/arch/tile/kernel/relocate_kernel_64.S
index 1c09a4f..02bc446 100644
--- a/arch/tile/kernel/relocate_kernel_64.S
+++ b/arch/tile/kernel/relocate_kernel_64.S
@@ -34,11 +34,11 @@ STD_ENTRY(relocate_new_kernel)
 	addi	sp, sp, -8
 	/* we now have a stack (whether we need one or not) */
 
+#ifdef RELOCATE_NEW_KERNEL_VERBOSE
 	moveli	r40, hw2_last(hv_console_putc)
 	shl16insli r40, r40, hw1(hv_console_putc)
 	shl16insli r40, r40, hw0(hv_console_putc)
 
-#ifdef RELOCATE_NEW_KERNEL_VERBOSE
 	moveli	r0, 'r'
 	jalr	r40
 
@@ -176,10 +176,12 @@ STD_ENTRY(relocate_new_kernel)
 
 	/* we should not get here */
 
+#ifdef RELOCATE_NEW_KERNEL_VERBOSE
 	moveli	r0, '?'
 	jalr	r40
 	moveli	r0, '\n'
 	jalr	r40
+#endif
 
 	j	.Lhalt
 
@@ -237,7 +239,9 @@ STD_ENTRY(relocate_new_kernel)
 	j	.Lloop
 
 
-.Lerr:	moveli	r0, 'e'
+.Lerr:
+#ifdef RELOCATE_NEW_KERNEL_VERBOSE
+	moveli	r0, 'e'
 	jalr	r40
 	moveli	r0, 'r'
 	jalr	r40
@@ -245,6 +249,7 @@ STD_ENTRY(relocate_new_kernel)
 	jalr	r40
 	moveli	r0, '\n'
 	jalr	r40
+#endif
 .Lhalt:
 	moveli r41, hw2_last(hv_halt)
 	shl16insli r41, r41, hw1(hv_halt)
-- 
1.8.3.1


  parent reply	other threads:[~2013-09-03 19:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 15:24 [PATCH] tile: support KVM for tilegx Chris Metcalf
2013-08-12 17:08 ` Jan Kiszka
2013-08-12 20:24   ` [PATCH v2] " Chris Metcalf
2013-08-25 11:39     ` Gleb Natapov
2013-08-26  1:26       ` Chris Metcalf
2013-08-26 12:04         ` Gleb Natapov
2013-08-28 19:45           ` [PATCH v3 1/3] tile: support KVM host mode Chris Metcalf
2013-09-10 10:53             ` Gleb Natapov
2013-09-10 11:59               ` Paolo Bonzini
2013-09-30 20:11               ` Chris Metcalf
2013-10-01 15:21                 ` Gleb Natapov
2013-08-28 20:57           ` [PATCH v3 2/3] tile: enable building as a paravirtualized KVM_GUEST Chris Metcalf
2013-08-28 20:58           ` [PATCH v3 3/3] tile: enable VIRTIO support for KVM Chris Metcalf
2013-09-10 12:47             ` Paolo Bonzini
2013-09-30 20:11               ` Chris Metcalf
2013-10-01  6:39                 ` Paolo Bonzini
2013-08-29  0:26           ` [PATCH v2] tile: support KVM for tilegx Chris Metcalf
2013-09-03 17:32           ` Chris Metcalf
2013-09-03 17:39             ` Gleb Natapov
2013-09-03 17:46               ` Chris Metcalf
2013-09-03 18:13               ` Chris Metcalf [this message]
2013-09-03 18:41               ` [PATCH 3/3] tile: parameterize VA and PA space more cleanly Chris Metcalf
2013-09-03 18:45               ` [PATCH 2/3] tile: don't assume user privilege is zero Chris Metcalf
2013-09-03 19:09               ` [PATCH 0/3] tile prerequisites for KVM support Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309272f99f3e65b9bb5c49a2901c63a1859172f3.1378235372.git.cmetcalf@tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.