[Intel-wired-lan] [PATCH net-next v5 1/4] igb: add support of RX network flow classification

[Brown, Aaron F <aaron.f.brown@intel.com>]

> -----Original Message-----
> From: 'Matt Porter' [mailto:mporter at konsulko.com]
> Sent: Thursday, June 30, 2016 9:16 AM
> To: Brown, Aaron F <aaron.f.brown@intel.com>
> Cc: 'Gangfeng' <gangfeng.huang@ni.com>; 'intel-wired-lan at lists.osuosl.org'
> <intel-wired-lan@lists.osuosl.org>; 'Ruhao Gao' <ruhao.gao@ni.com>
> Subject: Re: [Intel-wired-lan] [PATCH net-next v5 1/4] igb: add support of RX
> network flow classification
>
<snip>
> 
> Ok, the full oops output made me notice the problem. Can you try the
> following untested fix on your failing system? It'll apply against
> patch 1/4 and is build tested against the next-queue dev-queue branch.
> 
> -Matt
> 
> From 8773d0f09741d7a318cdd96cf5aad2ddb79096e7 Mon Sep 17 00:00:00
> 2001
> From: Matt Porter <mporter@konsulko.com>
> Date: Thu, 30 Jun 2016 11:47:50 -0400
> Subject: [PATCH] igb: Fix missing lock init in rx network flow classification
>  support
> 
> "[net-next,v5,1/4] igb: add support of RX network flow classification"
> adds a new nfc_lock to each adapter to protect the rx filter hash list.
> This lock is not initialized before use which results in intermittent
> oopses. Initialize this lock during probe to fix the issue.
> 
> Signed-off-by: Matt Porter <mporter@konsulko.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index c04b1c2..e5a4949 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -3075,6 +3075,7 @@ static int igb_sw_init(struct igb_adapter *adapter)
>  				  VLAN_HLEN;
>  	adapter->min_frame_size = ETH_ZLEN + ETH_FCS_LEN;
> 
> +	spin_lock_init(&adapter->nfc_lock);
>  	spin_lock_init(&adapter->stats64_lock);
>  #ifdef CONFIG_PCI_IOV
>  	switch (hw->mac.type) {
> --
> 2.7.0

Bingo!  That resolved it.  I can now load and bind (with ifconfig) on all the systems that were previously giving me the splat without seeing anything out of the ordinary.

Thanks,
Aaron