All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brown, Aaron F <aaron.f.brown@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/3] e1000e: Set HTHRESH when PTHRESH is used
Date: Wed, 22 Nov 2017 05:34:34 +0000	[thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C6EFA57@ORSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <20171107221332.28283-1-mattst88@gmail.com>

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf
> Of Matt Turner
> Sent: Tuesday, November 7, 2017 2:14 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Turner, Matt <matt.turner@intel.com>
> Subject: [Intel-wired-lan] [PATCH 1/3] e1000e: Set HTHRESH when PTHRESH
> is used
> 
> From: Matt Turner <matt.turner@intel.com>
> 
> According to section 12.0.3.4.13 "Receive Descriptor Control - RXDCTL"
> of the Intel? 82579 Gigabit Ethernet PHY Datasheet v2.1:
> 
>     "HTHRESH should be given a non zero value when ever PTHRESH is
>      used."
> 
> In RXDCTL(0), PTHRESH lives at bits 5:0, and HTHREST lives at bits 13:8.
> Set only bit 8 of HTHREST as is done in e1000_flush_rx_ring(). Found by
> inspection.
> 
> Signed-off-by: Matt Turner <matt.turner@intel.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Aaron Brown <aaron.f.brown@intel.com>

      parent reply	other threads:[~2017-11-22  5:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 22:13 [Intel-wired-lan] [PATCH 1/3] e1000e: Set HTHRESH when PTHRESH is used Matt Turner
2017-11-07 22:13 ` [Intel-wired-lan] [PATCH 2/3] e1000e: Alert the user that C-states will be disabled by enabling jumbo frames Matt Turner
2017-11-09  9:36   ` Neftin, Sasha
2017-11-09 22:14     ` Shannon Nelson
2017-11-14 23:51   ` Matt Turner
2017-11-15 16:48     ` Shannon Nelson
2017-11-29  2:12     ` Brown, Aaron F
2017-11-07 22:13 ` [Intel-wired-lan] [PATCH 3/3] e1000e: Disable jumbo receive workaround on Lynx Point and newer Matt Turner
2017-11-09  8:19   ` Neftin, Sasha
2017-11-09 21:40     ` Matt Turner
2017-11-09  7:04 ` [Intel-wired-lan] [PATCH 1/3] e1000e: Set HTHRESH when PTHRESH is used Neftin, Sasha
2017-11-22  5:34 ` Brown, Aaron F [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309B89C4C689E141A5FF6A0C5FB2118B8C6EFA57@ORSMSX101.amr.corp.intel.com \
    --to=aaron.f.brown@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.