From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DD3C4321D for ; Thu, 23 Aug 2018 21:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 879532150F for ; Thu, 23 Aug 2018 21:05:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 879532150F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727633AbeHXAhD convert rfc822-to-8bit (ORCPT ); Thu, 23 Aug 2018 20:37:03 -0400 Received: from mga07.intel.com ([134.134.136.100]:58669 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727180AbeHXAhC (ORCPT ); Thu, 23 Aug 2018 20:37:02 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 14:05:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,279,1531810800"; d="scan'208";a="257532039" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga006.fm.intel.com with ESMTP; 23 Aug 2018 14:05:33 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.46]) by ORSMSX103.amr.corp.intel.com ([169.254.5.166]) with mapi id 14.03.0319.002; Thu, 23 Aug 2018 14:05:33 -0700 From: "Brown, Aaron F" To: Jia-Ju Bai , "Kirsher, Jeffrey T" CC: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback() Thread-Topic: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback() Thread-Index: AQHUJYDvfM5CImqE2UeML7hSqVxIEaTN/uqg Date: Thu, 23 Aug 2018 21:05:33 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B96550235@ORSMSX101.amr.corp.intel.com> References: <20180727080738.3301-1-baijiaju1990@gmail.com> In-Reply-To: <20180727080738.3301-1-baijiaju1990@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Jia-Ju Bai > Sent: Friday, July 27, 2018 1:08 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; Jia-Ju Bai ; intel- > wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with > msleep() in igb_integrated_phy_loopback() > > igb_integrated_phy_loopback() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Aaron Brown From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brown, Aaron F Date: Thu, 23 Aug 2018 21:05:33 +0000 Subject: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback() In-Reply-To: <20180727080738.3301-1-baijiaju1990@gmail.com> References: <20180727080738.3301-1-baijiaju1990@gmail.com> Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B96550235@ORSMSX101.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On > Behalf Of Jia-Ju Bai > Sent: Friday, July 27, 2018 1:08 AM > To: Kirsher, Jeffrey T > Cc: netdev at vger.kernel.org; Jia-Ju Bai ; intel- > wired-lan at lists.osuosl.org; linux-kernel at vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with > msleep() in igb_integrated_phy_loopback() > > igb_integrated_phy_loopback() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Aaron Brown