From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839ADC6787C for ; Sat, 13 Oct 2018 00:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2880A20868 for ; Sat, 13 Oct 2018 00:11:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2880A20868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbeJMHqa convert rfc822-to-8bit (ORCPT ); Sat, 13 Oct 2018 03:46:30 -0400 Received: from mga02.intel.com ([134.134.136.20]:29550 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbeJMHq3 (ORCPT ); Sat, 13 Oct 2018 03:46:29 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2018 17:11:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,374,1534834800"; d="scan'208";a="82221003" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga006.jf.intel.com with ESMTP; 12 Oct 2018 17:11:38 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Oct 2018 17:11:38 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.122]) by ORSMSX116.amr.corp.intel.com ([169.254.7.58]) with mapi id 14.03.0319.002; Fri, 12 Oct 2018 17:11:38 -0700 From: "Brown, Aaron F" To: Lance Roy , "linux-kernel@vger.kernel.org" CC: "Paul E. McKenney" , "Kirsher, Jeffrey T" , "David S. Miller" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH 05/16] igbvf: Replace spin_is_locked() with lockdep Thread-Topic: [PATCH 05/16] igbvf: Replace spin_is_locked() with lockdep Thread-Index: AQHUWtu+IcNCVZ3vS0qf/ftsJ7vWgaUcXMDg Date: Sat, 13 Oct 2018 00:11:37 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B9657ABF9@ORSMSX101.amr.corp.intel.com> References: <20181003053902.6910-1-ldr709@gmail.com> <20181003053902.6910-6-ldr709@gmail.com> In-Reply-To: <20181003053902.6910-6-ldr709@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of Lance Roy > Sent: Tuesday, October 2, 2018 10:39 PM > To: linux-kernel@vger.kernel.org > Cc: Paul E. McKenney ; Lance Roy > ; Kirsher, Jeffrey T ; David > S. Miller ; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org > Subject: [PATCH 05/16] igbvf: Replace spin_is_locked() with lockdep > > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy > Cc: Jeff Kirsher > Cc: "David S. Miller" > Cc: intel-wired-lan@lists.osuosl.org > Cc: > --- > drivers/net/ethernet/intel/igbvf/mbx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Tested-by: Aaron Brown From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brown, Aaron F Date: Sat, 13 Oct 2018 00:11:37 +0000 Subject: [Intel-wired-lan] [PATCH 05/16] igbvf: Replace spin_is_locked() with lockdep In-Reply-To: <20181003053902.6910-6-ldr709@gmail.com> References: <20181003053902.6910-1-ldr709@gmail.com> <20181003053902.6910-6-ldr709@gmail.com> Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B9657ABF9@ORSMSX101.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > From: netdev-owner at vger.kernel.org [mailto:netdev- > owner at vger.kernel.org] On Behalf Of Lance Roy > Sent: Tuesday, October 2, 2018 10:39 PM > To: linux-kernel at vger.kernel.org > Cc: Paul E. McKenney ; Lance Roy > ; Kirsher, Jeffrey T ; David > S. Miller ; intel-wired-lan at lists.osuosl.org; > netdev at vger.kernel.org > Subject: [PATCH 05/16] igbvf: Replace spin_is_locked() with lockdep > > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy > Cc: Jeff Kirsher > Cc: "David S. Miller" > Cc: intel-wired-lan at lists.osuosl.org > Cc: > --- > drivers/net/ethernet/intel/igbvf/mbx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Tested-by: Aaron Brown