From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Brown, Aaron F" Subject: RE: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode' Date: Thu, 1 Nov 2018 19:24:35 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B96598671@ORSMSX101.amr.corp.intel.com> References: <1539952830-187358-1-git-send-email-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" To: YueHaibing , "Kirsher, Jeffrey T" , "Neftin, Sasha" Return-path: Received: from mga09.intel.com ([134.134.136.24]:40354 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbeKBE2y (ORCPT ); Fri, 2 Nov 2018 00:28:54 -0400 In-Reply-To: <1539952830-187358-1-git-send-email-yuehaibing@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of YueHaibing > Sent: Friday, October 19, 2018 5:41 AM > To: Kirsher, Jeffrey T ; Neftin, Sasha > > Cc: YueHaibing ; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; kernel-janitors@vger.kernel.org > Subject: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, > link_mode' > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_init_phy_params_base': > drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning: > variable 'ctrl_ext' set but not used [-Wunused-but-set-variable] > u32 ctrl_ext; > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_get_invariants_base': > drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning: > variable 'link_mode' set but not used [-Wunused-but-set-variable] > u32 link_mode = 0; > > It never used since introduction in > commit c0071c7aa5fe ("igc: Add HW initialization code") > > Signed-off-by: YueHaibing > --- > I'm not sure that reading IGC_CTRL_EXT is necessary. > --- > drivers/net/ethernet/intel/igc/igc_base.c | 8 -------- > 1 file changed, 8 deletions(-) > Tested-by: Aaron Brown From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Brown, Aaron F" Date: Thu, 01 Nov 2018 19:24:35 +0000 Subject: RE: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode' Message-Id: <309B89C4C689E141A5FF6A0C5FB2118B96598671@ORSMSX101.amr.corp.intel.com> List-Id: References: <1539952830-187358-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1539952830-187358-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing , "Kirsher, Jeffrey T" , "Neftin, Sasha" Cc: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of YueHaibing > Sent: Friday, October 19, 2018 5:41 AM > To: Kirsher, Jeffrey T ; Neftin, Sasha > > Cc: YueHaibing ; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; kernel-janitors@vger.kernel.org > Subject: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, > link_mode' > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_init_phy_params_base': > drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning: > variable 'ctrl_ext' set but not used [-Wunused-but-set-variable] > u32 ctrl_ext; > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_get_invariants_base': > drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning: > variable 'link_mode' set but not used [-Wunused-but-set-variable] > u32 link_mode = 0; > > It never used since introduction in > commit c0071c7aa5fe ("igc: Add HW initialization code") > > Signed-off-by: YueHaibing > --- > I'm not sure that reading IGC_CTRL_EXT is necessary. > --- > drivers/net/ethernet/intel/igc/igc_base.c | 8 -------- > 1 file changed, 8 deletions(-) > Tested-by: Aaron Brown From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brown, Aaron F Date: Thu, 1 Nov 2018 19:24:35 +0000 Subject: [Intel-wired-lan] [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode' In-Reply-To: <1539952830-187358-1-git-send-email-yuehaibing@huawei.com> References: <1539952830-187358-1-git-send-email-yuehaibing@huawei.com> Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B96598671@ORSMSX101.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > From: netdev-owner at vger.kernel.org [mailto:netdev- > owner at vger.kernel.org] On Behalf Of YueHaibing > Sent: Friday, October 19, 2018 5:41 AM > To: Kirsher, Jeffrey T ; Neftin, Sasha > > Cc: YueHaibing ; intel-wired-lan at lists.osuosl.org; > netdev at vger.kernel.org; kernel-janitors at vger.kernel.org > Subject: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, > link_mode' > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_init_phy_params_base': > drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning: > variable 'ctrl_ext' set but not used [-Wunused-but-set-variable] > u32 ctrl_ext; > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_get_invariants_base': > drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning: > variable 'link_mode' set but not used [-Wunused-but-set-variable] > u32 link_mode = 0; > > It never used since introduction in > commit c0071c7aa5fe ("igc: Add HW initialization code") > > Signed-off-by: YueHaibing > --- > I'm not sure that reading IGC_CTRL_EXT is necessary. > --- > drivers/net/ethernet/intel/igc/igc_base.c | 8 -------- > 1 file changed, 8 deletions(-) > Tested-by: Aaron Brown