From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F2EC433E0 for ; Mon, 25 May 2020 09:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60F832078B for ; Mon, 25 May 2020 09:27:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dd-wrt.com header.i=@dd-wrt.com header.b="CpCBJMCj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389330AbgEYJ1m (ORCPT ); Mon, 25 May 2020 05:27:42 -0400 Received: from mail.as201155.net ([185.84.6.188]:30072 "EHLO mail.as201155.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389266AbgEYJ1m (ORCPT ); Mon, 25 May 2020 05:27:42 -0400 Received: from smtps.newmedia-net.de ([2a05:a1c0:0:de::167]:39664 helo=webmail.newmedia-net.de) by mail.as201155.net with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1jd9OT-0002hK-0v; Mon, 25 May 2020 11:27:37 +0200 X-CTCH-RefID: str=0001.0A782F27.5ECB8F3C.0059,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=183n2q30X9kt5G1Y+EJed/eLG0YBkkzBC4KGB3jOM8E=; b=CpCBJMCjF0CH1RHbOed5fvJfZz5JbQs6vDFdd0ehaqdRUCA2u+P2ai4e9llzsjTejNUcloORBir7nOCARXV0gCn0F/Od3Q0TrzQGiWH1S9A1adgueSsV7cbsyOFWRv7C1eOWOT5YJSnAAOEGvIyxc5sget8tv/TRyb+h+ogMajU=; Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets To: Sven Eckelmann Cc: ath10k@lists.infradead.org, John Crispin , Ansuel Smith , openwrt-devel@lists.openwrt.org, Kalle Valo , Sebastian Gottschall , linux-wireless@vger.kernel.org References: <1523027875-5143-1-git-send-email-kvalo@codeaurora.org> <2468724.JaAZLprVu6@bentobox> <3608947.bSrYYtX6KI@bentobox> From: Sebastian Gottschall Message-ID: <309af858-7e38-17fa-a1db-6b9ce8544ef5@dd-wrt.com> Date: Mon, 25 May 2020 11:27:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Thunderbird/77.0 MIME-Version: 1.0 In-Reply-To: <3608947.bSrYYtX6KI@bentobox> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Received: from [2a01:7700:8040:4000:a1fd:236:8557:c23a] by webmail.newmedia-net.de with esmtpa (Exim 4.72) (envelope-from ) id 1jd9KM-00053m-6T; Mon, 25 May 2020 11:23:22 +0200 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Am 25.05.2020 um 11:22 schrieb Sven Eckelmann: > On Wednesday, 20 May 2020 09:39:45 CEST Sebastian Gottschall wrote: > [...] >> could somone clarify the state here and why it was dropped? >> the original patch i wrote does exclude the soc chipsets, but the patch >> was later reorganized and some part have been rewritten >> so i'm not sure if it covers the scenario mentioned here, which i did > [...] >>> This patch was imported to OpenWrt in commit 61d57a2f88b9 ("mac80211: ath10k >>> add leds support") and broke the 11s support for IPQ4019 and QCA4019 (5GHz) >>> firmware versions 10.4-3.5.3-00053, 10.4-3.5.3-00057, 10.4-3.6-00140: > Just noticed that there was a copy and paste error in my message. The 5GHz was > an QCA9888 [1,2] and not an QCA4019. Otherwise the _pci error wouldn't have made > any sense. > > And I can only say at the moment (remember that this was observer 14 months > ago), that it could be reproduced easily on IPQ40xx with an QCA9888 and the > given config running OpenWrt reboot-9440-g0f89c17b57. The diffconfig (seed) of > the installation was: > > CONFIG_TARGET_ipq40xx=y > CONFIG_TARGET_ipq40xx_generic=y > CONFIG_TARGET_ipq40xx_generic_DEVICE_openmesh_a62=y > CONFIG_ATH10K_LEDS=y > CONFIG_PACKAGE_ath10k-firmware-qca4019=y > # CONFIG_PACKAGE_ath10k-firmware-qca4019-ct is not set > CONFIG_PACKAGE_ath10k-firmware-qca9888=y > # CONFIG_PACKAGE_ath10k-firmware-qca9888-ct is not set > CONFIG_PACKAGE_kmod-ath10k=y > # CONFIG_PACKAGE_kmod-ath10k-ct is not set > # CONFIG_PACKAGE_kmod-hwmon-core is not set > > And it still can with this OpenWrt version. But it doesn't seem to happen with > the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000 > commits inbetween. So no idea what changed (just a timing thing or an actual > fix - no idea). > > Btw. the wireless config was given in the original mail [2,3] > > Kind regards, > Sven maybe openwrt installs a default trigger which doesnt make sense if nothing is connected to the cards gpio. we can also modify the patch to exclude the 9888 from led support. you just need to remove the led_pin defintion from the hw definition. this patch is mainly for wireless routers like the netgear r7800, r9000 and some tplink archer models. it also works on mikrotik qca988x cards. but even if the led_pin is set, it should not trigger any action until a led trigger is set with sysfs. such configurations should be architecture specific in any way Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.as201155.net ([185.84.6.188]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd9Oa-0003uJ-FJ for ath10k@lists.infradead.org; Mon, 25 May 2020 09:27:48 +0000 Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets References: <1523027875-5143-1-git-send-email-kvalo@codeaurora.org> <2468724.JaAZLprVu6@bentobox> <3608947.bSrYYtX6KI@bentobox> From: Sebastian Gottschall Message-ID: <309af858-7e38-17fa-a1db-6b9ce8544ef5@dd-wrt.com> Date: Mon, 25 May 2020 11:27:34 +0200 MIME-Version: 1.0 In-Reply-To: <3608947.bSrYYtX6KI@bentobox> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sven Eckelmann Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Sebastian Gottschall , openwrt-devel@lists.openwrt.org, Ansuel Smith , Kalle Valo Am 25.05.2020 um 11:22 schrieb Sven Eckelmann: > On Wednesday, 20 May 2020 09:39:45 CEST Sebastian Gottschall wrote: > [...] >> could somone clarify the state here and why it was dropped? >> the original patch i wrote does exclude the soc chipsets, but the patch >> was later reorganized and some part have been rewritten >> so i'm not sure if it covers the scenario mentioned here, which i did > [...] >>> This patch was imported to OpenWrt in commit 61d57a2f88b9 ("mac80211: ath10k >>> add leds support") and broke the 11s support for IPQ4019 and QCA4019 (5GHz) >>> firmware versions 10.4-3.5.3-00053, 10.4-3.5.3-00057, 10.4-3.6-00140: > Just noticed that there was a copy and paste error in my message. The 5GHz was > an QCA9888 [1,2] and not an QCA4019. Otherwise the _pci error wouldn't have made > any sense. > > And I can only say at the moment (remember that this was observer 14 months > ago), that it could be reproduced easily on IPQ40xx with an QCA9888 and the > given config running OpenWrt reboot-9440-g0f89c17b57. The diffconfig (seed) of > the installation was: > > CONFIG_TARGET_ipq40xx=y > CONFIG_TARGET_ipq40xx_generic=y > CONFIG_TARGET_ipq40xx_generic_DEVICE_openmesh_a62=y > CONFIG_ATH10K_LEDS=y > CONFIG_PACKAGE_ath10k-firmware-qca4019=y > # CONFIG_PACKAGE_ath10k-firmware-qca4019-ct is not set > CONFIG_PACKAGE_ath10k-firmware-qca9888=y > # CONFIG_PACKAGE_ath10k-firmware-qca9888-ct is not set > CONFIG_PACKAGE_kmod-ath10k=y > # CONFIG_PACKAGE_kmod-ath10k-ct is not set > # CONFIG_PACKAGE_kmod-hwmon-core is not set > > And it still can with this OpenWrt version. But it doesn't seem to happen with > the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000 > commits inbetween. So no idea what changed (just a timing thing or an actual > fix - no idea). > > Btw. the wireless config was given in the original mail [2,3] > > Kind regards, > Sven maybe openwrt installs a default trigger which doesnt make sense if nothing is connected to the cards gpio. we can also modify the patch to exclude the 9888 from led support. you just need to remove the led_pin defintion from the hw definition. this patch is mainly for wireless routers like the netgear r7800, r9000 and some tplink archer models. it also works on mikrotik qca988x cards. but even if the led_pin is set, it should not trigger any action until a led trigger is set with sysfs. such configurations should be architecture specific in any way Sebastian _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k