From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49301)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1VTyVG-0005E6-HO
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 14:29:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1VTyVA-0000Ym-Il
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 14:28:58 -0400
Received: from mail.avalus.com ([89.16.176.221]:39953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1VTyVA-0000Ya-C7
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 14:28:52 -0400
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=us-ascii
From: Alex Bligh <alex@alex.org.uk>
In-Reply-To: <52559A8A.2070201@redhat.com>
Date: Wed, 9 Oct 2013 19:28:39 +0100
Content-Transfer-Encoding: 7bit
Message-Id: <30CAC247-C396-4991-804B-DD0A0FE68674@alex.org.uk>
References: <1381259403-7386-1-git-send-email-hdegoede@redhat.com>
	<52545950.5070403@redhat.com> <52545B44.70005@redhat.com>
	<28EE4224-856B-4DC1-8159-A0C274BD269E@alex.org.uk>
	<52546000.6070308@redhat.com>
	<6CD4D4EE-341E-48D0-98F4-D55C0D3922D4@alex.org.uk>
	<52546832.9040900@redhat.com> <5254701B.5070804@redhat.com>
	<525552D9.90407@redhat.com>
	<2451DF8D-DD3E-4875-B6D6-CEF66A763D7E@alex.org.uk>
	<52559A8A.2070201@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads
	when main_loop_tlg has pending events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>


On 9 Oct 2013, at 19:03, Hans de Goede wrote:

> static void audio_reset_timer (AudioState *s)
> {
>    if (audio_is_timer_needed ()) {
>        timer_mod (s->ts, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1);
>    }
>    else {
>        timer_del (s->ts);
>    }
> }
> 
> static void audio_timer (void *opaque)
> {
>    audio_run ("timer");
>    audio_reset_timer (opaque);
> }
> 
> Note how that is using a timer which expires every freaking nano second,
> I think it is very likely that is the culprit.

Indeed. I am hoping that it is not my automated perl conversion code that
did that, because if it is, it may have broken other stuff :-/

Thanks for finding this - let me see whether the bug existed before
my automated changes commit.

-- 
Alex Bligh