From: Marek Vasut <marek.vasut@gmail.com>
To: Radu Pirea <radu.pirea@microchip.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Zhiqiang.Hou@nxp.com, pp@emlix.com, richard@nod.at,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256
Date: Wed, 16 May 2018 15:47:15 +0200 [thread overview]
Message-ID: <30ab9516-abc9-d2d5-79ea-266c682c5fa9@gmail.com> (raw)
In-Reply-To: <a34429cf43124de623fcaa645d5d7a360c755867.camel@microchip.com>
On 05/16/2018 12:05 PM, Radu Pirea wrote:
> On Wed, 2018-05-16 at 00:17 +0200, Marek Vasut wrote:
>> On 05/15/2018 06:22 PM, Radu Pirea wrote:
>>> On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote:
>>>> On Fri, 4 May 2018 18:54:04 +0300
>>>> Radu Pirea <radu.pirea@microchip.com> wrote:
>>>>
>>>>> Added geometry description for Microchip 25LC256 memory.
>>>>
>>>> Same as for the dataflash stuff you posted a few weeks ago: I
>>>> don't
>>>> think this device belongs in the SPI NOR framework.
>>>
>>> Hi Boris,
>>>
>>> 25lc256 memory is similar with mr25h256, the only difference is the
>>> page size(64 vs 256). Because mr25h256 is already in SPI NOR
>>> framework
>>> I added here 25lc256.
>>
>> I think I must be reading the wrong datasheet, but can you show me
>> how
>> does it support things like READID opcode ?
>>
> Hi Marek,
>
> I read the datasheet for 25lc256 and for mr25h256 and none of them
> supports READID. Is this required for a chip to be included in spi-nor
> framework? I just followed the mr25h256 as an example.
So I thought until you pointed out the MR25 devices.
Does the 25LC device need erase or not ? I think the MR25s didn't, but I
might be wrong.
Maybe the framework could support the 25LC afterall.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-05-16 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 15:54 [PATCH] mtd: spi-nor: add support for Microchip 25LC256 Radu Pirea
2018-05-04 17:11 ` Marek Vasut
2018-05-04 18:40 ` Boris Brezillon
2018-05-15 16:22 ` Radu Pirea
2018-05-15 22:17 ` Marek Vasut
2018-05-16 10:05 ` Radu Pirea
2018-05-16 13:47 ` Marek Vasut [this message]
2018-05-18 9:50 ` Radu Pirea
2018-05-18 10:03 ` Marek Vasut
2018-05-18 13:00 ` Radu Pirea
2018-05-18 16:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30ab9516-abc9-d2d5-79ea-266c682c5fa9@gmail.com \
--to=marek.vasut@gmail.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pp@emlix.com \
--cc=radu.pirea@microchip.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.