From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for strict data checking Date: Fri, 5 Oct 2018 13:25:22 -0600 Message-ID: <30b45b7e-cbda-e348-c5f1-5b78cfb84d2f@gmail.com> References: <20181004213355.14899-1-dsahern@kernel.org> <20181004213355.14899-12-dsahern@kernel.org> <20181005174827.iudgcjd3r2cc7xqu@brauner.io> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, jbenc@redhat.com, stephen@networkplumber.org To: Christian Brauner , David Ahern Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:38582 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728061AbeJFCZc (ORCPT ); Fri, 5 Oct 2018 22:25:32 -0400 Received: by mail-pl1-f195.google.com with SMTP id b5-v6so7273184plr.5 for ; Fri, 05 Oct 2018 12:25:24 -0700 (PDT) In-Reply-To: <20181005174827.iudgcjd3r2cc7xqu@brauner.io> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/5/18 11:48 AM, Christian Brauner wrote: > On Thu, Oct 04, 2018 at 02:33:46PM -0700, David Ahern wrote: >> From: David Ahern >> >> Update inet6_dump_ifinfo for strict data checking. If the flag is >> set, the dump request is expected to have an ifinfomsg struct as >> the header. All elements of the struct are expected to be 0 and no >> attributes can be appended. >> >> Signed-off-by: David Ahern > This is on top of current net-next? Are your patches ensuring that > ipv6 addr requests don't generate log messages anymore when a wrong > header is passed but the strict socket option is not passed? The context > here doesn't seem to indicate that. :) > this is an AF_INET6 GETLINK handler. Why? no idea, but I think you are confusing this patch with the GETADDR patch which generated the "netlink: 16 bytes leftover after parsing attributes in process `ip'." message before this set.