From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned
 Tx/Rx parameters
Date: Wed, 14 Mar 2018 15:48:57 +0000
Message-ID: <30b8575d-4aeb-912d-6f74-c49ad7ce879a@intel.com>
References: <20180307120851.5822-1-remy.horton@intel.com>
 <20180307120851.5822-2-remy.horton@intel.com>
 <023fbd6c-7cac-6c8b-9a40-7a62e5d47bb7@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id D1B925F6C
 for <dev@dpdk.org>; Wed, 14 Mar 2018 16:49:02 +0100 (CET)
In-Reply-To: <023fbd6c-7cac-6c8b-9a40-7a62e5d47bb7@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 14/03/2018 14:43, Ferruh Yigit wrote:
[..]
>>  lib/librte_ether/rte_ethdev.c | 18 ++++++++++++++++++
>>  lib/librte_ether/rte_ethdev.h | 15 +++++++++++++++
>
> Can you please remove deprecation notice in this patch.

Done.

>> +	/* Defaults for drivers that don't implement preferred
>> +	 * queue parameters.
[..]
> Not sure about having these defaults here. It is OK to have defaults in driver,
> in application or in config file, but I am not sure if putting them into device
> abstraction layer hides them.
>
> What about not providing any default in ethdev layer, and get zero as invalid
> when using them?

This is something I have been thinking about, and I am going to remove 
them for the V2. Original motive was to avoid breaking testpmd for PMDs 
that don't give defaults (i.e. almost all of them). The alternative is 
to put place-holders into all the PMDs themselves, but I am not sure if 
this is appropriate.