From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fagG5-0006Yq-P5 for qemu-devel@nongnu.org; Wed, 04 Jul 2018 07:47:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fagG4-00024X-R8 for qemu-devel@nongnu.org; Wed, 04 Jul 2018 07:47:41 -0400 References: <1530602398-16127-1-git-send-email-eric.auger@redhat.com> <1530602398-16127-8-git-send-email-eric.auger@redhat.com> <4dfad441-b94f-916f-025e-fc69b6375465@redhat.com> From: David Hildenbrand Message-ID: <30bba021-8537-8ef3-13ac-197cff7445cb@redhat.com> Date: Wed, 4 Jul 2018 13:47:31 +0200 MIME-Version: 1.0 In-Reply-To: <4dfad441-b94f-916f-025e-fc69b6375465@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v3 07/15] hw/arm/virt: Add memory hotplug framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Auger Eric , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com, imammedo@redhat.com Cc: dgilbert@redhat.com, agraf@suse.de, david@gibson.dropbear.id.au, drjones@redhat.com, wei@redhat.com On 03.07.2018 21:34, Auger Eric wrote: > Hi David, > > On 07/03/2018 08:44 PM, David Hildenbrand wrote: >> On 03.07.2018 09:19, Eric Auger wrote: >>> From: Shameer Kolothum >>> >>> This patch adds the the memory hot-plug/hot-unplug infrastructure >>> in machvirt. >>> >>> Signed-off-by: Eric Auger >>> Signed-off-by: Shameer Kolothum >>> Signed-off-by: Kwangwoo Lee >>> >>> --- >>> >>> v1 -> v2: >>> - s/virt_dimm_plug|unplug/virt_memory_plug|unplug >>> - s/pc_dimm_memory_plug/pc_dimm_plug >>> - reworded title and commit message >>> - added pre_plug cb >>> - don't handle get_memory_region failure anymore >>> --- >>> default-configs/arm-softmmu.mak | 2 ++ >>> hw/arm/virt.c | 68 ++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 69 insertions(+), 1 deletion(-) >>> >>> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak >>> index 834d45c..28fe8f3 100644 >>> --- a/default-configs/arm-softmmu.mak >>> +++ b/default-configs/arm-softmmu.mak >>> @@ -152,3 +152,5 @@ CONFIG_PCI_DESIGNWARE=y >>> CONFIG_STRONGARM=y >>> CONFIG_HIGHBANK=y >>> CONFIG_MUSICPAL=y >>> +CONFIG_MEM_HOTPLUG=y >>> + >>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >>> index 6fefb78..7190962 100644 >>> --- a/hw/arm/virt.c >>> +++ b/hw/arm/virt.c >>> @@ -60,6 +60,8 @@ >>> #include "standard-headers/linux/input.h" >>> #include "hw/arm/smmuv3.h" >>> #include "hw/acpi/acpi.h" >>> +#include "hw/mem/pc-dimm.h" >>> +#include "hw/mem/nvdimm.h" >>> >>> #define DEFINE_VIRT_MACHINE_LATEST(major, minor, latest) \ >>> static void virt_##major##_##minor##_class_init(ObjectClass *oc, \ >>> @@ -1785,6 +1787,53 @@ static const CPUArchIdList *virt_possible_cpu_arch_ids(MachineState *ms) >>> return ms->possible_cpus; >>> } >>> >>> +static void virt_memory_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev, >>> + Error **errp) >>> +{ >>> + const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM); >>> + >>> + if (is_nvdimm) { >>> + error_setg(errp, "nvdimm is not yet supported"); >>> + return; >>> + } >> >> You mention that actual hotplug is not supported, only coldplug. >> Wouldn't this be the right place to check for that? (only skimmed over >> your patches, how do you handle that?) > At the moment I don't check it. I did not look yet at ways to > discriminate both cases. Looking at dev->hotplugged should be enough I guess. > > Thanks > > Eric >> >> -- Thanks, David / dhildenb