All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 1/2] xen/grant-table: remove gnttab_*transfer*() functions
Date: Tue, 15 Mar 2022 20:52:11 -0400	[thread overview]
Message-ID: <30c3da01-5284-6915-cc91-188577ed148d@oracle.com> (raw)
In-Reply-To: <1633fb91-3771-e37c-14ce-43f1b0cda6a0@suse.com>



On 3/15/22 2:10 AM, Juergen Gross wrote:
> On 15.03.22 00:37, Boris Ostrovsky wrote:
>>
>> On 3/11/22 5:34 AM, Juergen Gross wrote:
>>> All grant table operations related to the "transfer" functionality
>>> are unused currently. There have been users in the old days of the
>>> "Xen-o-Linux" kernel, but those didn't make it upstream.
>>>
>>> So remove the "transfer" related functions.
>>
>>
>> Do we need to assert somewhere that transfer flags are not set?
> 
> This would be an orthogonal change, right? My patch is just removing
> never called functions.
> 

I was thinking of having this done as part of code removal (maybe as a separate patch).


> In any case I believe checking those flags is the job of the hypervisor.
> If an operation is illegal due to a transfer flag being set, it needs to
> be rejected at hypervisor level.

True.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

  reply	other threads:[~2022-03-16  0:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 10:34 [PATCH 0/2] xen/grant-table: do some cleanup Juergen Gross
2022-03-11 10:34 ` Juergen Gross
2022-03-11 10:34 ` Juergen Gross
2022-03-11 10:34 ` [PATCH 1/2] xen/grant-table: remove gnttab_*transfer*() functions Juergen Gross
2022-03-14 23:37   ` Boris Ostrovsky
2022-03-15  6:10     ` Juergen Gross
2022-03-16  0:52       ` Boris Ostrovsky [this message]
2022-03-16 21:47   ` Boris Ostrovsky
2022-03-11 10:34 ` [PATCH 2/2] xen/grant-table: remove readonly parameter from functions Juergen Gross
2022-03-11 10:34   ` Juergen Gross
2022-03-11 10:34   ` Juergen Gross
2022-03-11 10:47   ` Jan Beulich
2022-03-11 10:47     ` Jan Beulich
2022-03-11 10:47     ` Jan Beulich
2022-03-11 11:14   ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c3da01-5284-6915-cc91-188577ed148d@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.