From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH v2 12/29] venus: add common capability parser Date: Mon, 2 Jul 2018 12:59:07 +0300 Message-ID: <30d141b6-dffa-bf6a-dae8-79595c966a23@linaro.org> References: <20180515075859.17217-1-stanimir.varbanov@linaro.org> <20180515075859.17217-13-stanimir.varbanov@linaro.org> <13c7aec1-2bb9-f449-6b7d-7ec93be4ec71@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Figa Cc: Mauro Carvalho Chehab , Hans Verkuil , Linux Media Mailing List , Linux Kernel Mailing List , linux-arm-msm , vgarodia@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org Hi Tomasz, On 07/02/2018 12:23 PM, Tomasz Figa wrote: > On Thu, May 31, 2018 at 4:06 PM Tomasz Figa wrote: >> >> On Thu, May 31, 2018 at 1:21 AM Stanimir Varbanov >> wrote: >>> >>> Hi Tomasz, >>> >>> On 05/24/2018 05:16 PM, Tomasz Figa wrote: >>>> Hi Stanimir, >>>> >>>> On Tue, May 15, 2018 at 5:08 PM Stanimir Varbanov < > [snip] >>>> >>>>> + break; >>>>> + } >>>>> + >>>>> + word++; >>>>> + words_count--; >>>> >>>> If data is at |word + 1|, shouldn’t we increment |word| by |1 + |data >>>> size||? >>> >>> yes, that could be possible but the firmware packets are with variable >>> data length and don't want to make the code so complex. >>> >>> The idea is to search for HFI_PROPERTY_PARAM* key numbers. Yes it is not >>> optimal but this enumeration is happen only once during driver probe. >>> >> >> Hmm, do we have a guarantee that we will never find a value that >> matches HFI_PROPERTY_PARAM*, but would be actually just some data >> inside the payload? > > Ping? OK, you are right there is guarantee that we not mixing keywords and data. I can make parse_* functions to return how words they consumed and increment 'word' pointer with consumed words. -- regards, Stan